I'm working on a review (BZ#1086245) for nodejs-jsonstream.
Now the interesting thing is that the module it is packaging is actually called JSONStream in the npm registry and there is in fact a separate jsonstream module.
The general naming rules say that "You should generally use lowercase" but I guess this is a case where the node naming rules should take precedence, especially given that there is a conflict and we may need have both at some point?
Tom
On Nov 16, 2014, at 5:57 AM, Tom Hughes tom@compton.nu wrote:
I'm working on a review (BZ#1086245) for nodejs-jsonstream.
Now the interesting thing is that the module it is packaging is actually called JSONStream in the npm registry and there is in fact a separate jsonstream module.
The general naming rules say that "You should generally use lowercase" but I guess this is a case where the node naming rules should take precedence, especially given that there is a conflict and we may need have both at some point?
Before making that decision, I strongly recommend contacting both upstreams and asking them if either is willing to change their name (or if one is a dead upstream)
Differentiating by case only should be avoided wherever possible.
Tom
-- Tom Hughes (tom@compton.nu) http://compton.nu/ _______________________________________________ nodejs mailing list nodejs@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/nodejs
On Nov 16, 2014 3:57 AM, "Tom Hughes" tom@compton.nu wrote:
I'm working on a review (BZ#1086245) for nodejs-jsonstream.
Now the interesting thing is that the module it is packaging is actually
called JSONStream in the npm registry and there is in fact a separate jsonstream module.
The general naming rules say that "You should generally use lowercase"
but I guess this is a case where the node naming rules should take precedence, especially given that there is a conflict and we may need have both at some point?
Unfortunately the guidelines also forbid having two packages with names that differ only by case: http:// http://fedoraproject.org/wiki/Packaging:Conflicts#Conflicting_Package_Names fedoraproject.org http://fedoraproject.org/wiki/Packaging:Conflicts#Conflicting_Package_Names /wiki/Packaging: http://fedoraproject.org/wiki/Packaging:Conflicts#Conflicting_Package_Names Conflicts#Conflicting http://fedoraproject.org/wiki/Packaging:Conflicts#Conflicting_Package_Names _Package_Names http://fedoraproject.org/wiki/Packaging:Conflicts#Conflicting_Package_Names
Also, these days npm doesn't allow uppercase letters in package names, so stuff like this can't happen anymore: https https://github.com/npm/npm/issues/3914:// https://github.com/npm/npm/issues/3914github.com https://github.com/npm/npm/issues/3914/ https://github.com/npm/npm/issues/3914npm https://github.com/npm/npm/issues/3914/ https://github.com/npm/npm/issues/3914npm https://github.com/npm/npm/issues/3914/issues/3914 https://github.com/npm/npm/issues/3914
The uppercased version is older and more recently updated:
JSONStream: "modified":"2014-08-04T19:15:52.140Z", "created":"2011-09-23T11:01:36.806Z"
jsonstream: "modified":"2013-06-11T13:36:13.038Z", "created":"2013-06-11T13:36:11.463Z"
Therefore, I believe JSONStream the capitalized deserves the name. I'm about to send a mail to both upstreams and the npm registry admins to this effect (with you and Anish on CC). Let's wait and see what they say.
If the capitalized version keeps the name, I would strongly recommend still calling the RPM package "nodejs-JSONStream" with the capitals so users don't mistake it for the lowercased version. I think this is a sufficient enough "compelling reason to follow a different upstream convention" as required by the guidelines.
-T.C.
nodejs@lists.fedoraproject.org
-
Stephen Gallagher -
T.C. Hollingsworth -
Tom Hughes