On 23/10/15 20:13, Piotr Popieluch wrote:
But I think that in following cases it would be better to use
sources
from the upstream project:
1) When the license is not included in NPM but is in upstream project.
o Because we are not supposed to ship the license separate from the
sources.
2) When the tests are not included.
o In this case we need to download the sources from NPM and from
upstream project, which seems redundant and a waste of work.
3) When NPM content is generated and source files are not in NPM.
o This would mean to download sources from NPM and upstream project,
delete the NPM sources in prep and generate the files again.
Are there good reason to enforce the use of NPM sources which I am
missing? What is your opinion?
I would like to suggest to ad those three exceptions to the guidelines.
I agree, and in practice it is what I have been doing for some time, and
as I update older modules I tend to convert the ones that were
originally fetching tests separately to just use github as the source.
Tom
--
Tom Hughes (tom(a)compton.nu)
http://compton.nu/