On Wed, Jun 2, 2021 at 12:52 PM Neal Gompa <ngompa13(a)gmail.com> wrote:
On Wed, Jun 2, 2021 at 12:39 PM Troy Dawson <tdawson(a)redhat.com> wrote:
>
> I see two ways to do this.
> First: Since web-ext is a nodejs binary, you could create the web-ext rpm. If you
do this, make sure to use the nodejs bundled library script,[1] to bundle the build-time,
and run-time dependencies. You would then just add web-ext as a build dependency when you
are building your package.
>
> Second: You could bundle web-ext as a build-only bundle. You might need to edit the
bundler script, but it often works without modifications. If you go this route, you will
need to run the bundler script each time you do an update of your main package. This will
catch any security updates that have been released since last time. A sample spec file
will help some.[2]
>
> It's looking like you are leaning towards the second option.
>
If it's a nodejs binary, we should probably package it as an RPM and
do the bundling thing for all the stuff it needs. That way, other
extensions can use it too.
I agree, the first option is preferred.