Adding jan as he will have more insight into the flags used to build
Node.js in fedora
On Tue, Apr 1, 2025 at 12:54 PM Richard Lau <rlau(a)redhat.com> wrote:
> On Tue, 1 Apr 2025 at 17:21, Tomas Juhasz <tjuhasz(a)redhat.com> wrote:
>
>> Hello,
>>
>> Lately I have been trying to make nodejs in fedora pass annocheck tests,
>> which are a part of the gating process and I have runned into issues with
>> the cf-protection
>> <https://sourceware.org/annobin/annobin.html/Test-cf-protection.html>
>> test which verifies that Intel's CET security feature is enabled.
>>
>> In all of the guides that I have found (including the linked annocheck
>> guide) -fcf-protection flag is used to enable this feature, but in my
>> testing the inclusion didn't enable it.
>>
>> Could you please help me find some information about the upstream
>> utilization of this feature?
>> I have noticed that in openssl and zstd
>> <https://github.com/search?q=repo%3Anodejs%2Fnode%20.note.gnu.property&type=…>
>> dependencies in the source code there is an implementation for the
>> .gnu.properties instruction, but I don't know if it is supported by all
>> components of nodejs.
>>
>
> AFAIK upstream Node.js doesn't utilize this feature and if it has
> benefitted at all from dependencies enabling it that is not by design.
>
> The gating test and enablement is likely to be something added by Fedora,
> most likely the enablement is supposed to be inherited from
> redhat-rpm-config:
> https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/rawhide/f/macros#…
>
> --
>
> Richard Lau
>
> Software Engineer, Runtimes
>
> Red Hat <https://www.redhat.com/>
>
> Email: rlau(a)redhat.com
>
> Mastodon: @richardlau@fosstodon.org <https://fosstodon.org/@richardlau>
> <https://www.redhat.com/>
>
> --
> You received this message because you are subscribed to the Google Groups
> "nodeshiftcore" group.
> To view this discussion visit
> https://groups.google.com/a/redhat.com/d/msgid/nodeshiftcore/CAOPr%3DUU_pyS…
> <https://groups.google.com/a/redhat.com/d/msgid/nodeshiftcore/CAOPr%3DUU_pyS…>
> .
>