The the Node.js guidelines say about Source0 :
"The canonical method for shipping most node modules is tarballs from
the npm registry"
"This method [PP: tarbals from npm] should be preferred to using
checkouts from git or automatically generated tarballs from GitHub."
But I think that in following cases it would be better to use sources
from the upstream project:
1) When the license is not included in NPM but is in upstream project.
o Because we are not supposed to ship the license separate from the
2) When the tests are not included.
o In this case we need to download the sources from NPM and from
upstream project, which seems redundant and a waste of work.
3) When NPM content is generated and source files are not in NPM.
o This would mean to download sources from NPM and upstream project,
delete the NPM sources in prep and generate the files again.
Are there good reason to enforce the use of NPM sources which I am
missing? What is your opinion?
I would like to suggest to ad those three exceptions to the guidelines.
I have a patch prepped to update js-jquery to 3.2.1, and was wondering if I
should do it for F26.
stuffs, but jquery is a pretty simple package, and I need it for my web app.
The only significant issue I ran into is that the new version adds a build
dependency on "insight" for some sort of tracking feature. This doesn't
appear to work in Fedora (the nodejs-grunt-insight package doesn't exist?)
and the tracking feature can be easily patched out.
Does anybody have any thoughts/opinions/expertise on these matters and can
help make a decision about when to update jquery in Fedora?
I notice you've been uploading new versions of lots of nodejs modules to
the lookaside cache today.
Presumably you're planning to follow that up by pushing spec updates and
builds? Can I ask what this is all about? The fallout from such a large
set of updates is likely to be significant so the SIG should probably be
aware of what's going on before it hits....
Tom Hughes (tom(a)compton.nu)