Hi,
I've proposed #586 https://github.com/nmstate/nmstate/pull/586 but I am having some issues to test it.
Summary of the proposed solution:
If we are trying to edit an interface and it doesn't have an active profile then nmstate is going to delete all the profiles related to this interface and create a new one. If it has an active profile then use it.
Issue:
I have tested it manually and it works and also the proposed integration test works when run alone. But the proposed test doesn't work together with the rest of the integration tests because at this point nmstate have created a new active profile.
Any suggestion on how could we test this better?
Thanks, Fernando.
On Mon, Nov 18, 2019 at 10:48:16AM +0100, Fernando Fernandez Mancera wrote:
Hi,
I've proposed #586 https://github.com/nmstate/nmstate/pull/586 but I am having some issues to test it.
I have tested it manually and it works and also the proposed integration test works when run alone. But the proposed test doesn't work together with the rest of the integration tests because at this point nmstate have created a new active profile.
You may create a new fixture instead of use `eth1_up`:
@pytest.fixture def eth1_profile_created_as_down(eth1_up): nmcli c down eth1 yield
On Tue, Nov 19, 2019 at 5:43 AM Gris Ge fge@redhat.com wrote:
On Mon, Nov 18, 2019 at 10:48:16AM +0100, Fernando Fernandez Mancera wrote:
Hi,
I've proposed #586 https://github.com/nmstate/nmstate/pull/586 but I am having some issues to test it.
I have tested it manually and it works and also the proposed integration test works when run alone. But the proposed test doesn't work together with the rest of the integration tests because at this point nmstate have created a new active profile.
You may create a new fixture instead of use `eth1_up`:
@pytest.fixture def eth1_profile_created_as_down(eth1_up): nmcli c down eth1 yield
How about just creating a dummy interface profile using nmcli? I see no reason to use `eth1` in this case.
-- Gris Ge _______________________________________________ nmstate-devel mailing list -- nmstate-devel@lists.fedorahosted.org To unsubscribe send an email to nmstate-devel-leave@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/nmstate-devel@lists.fedorahoste...
nmstate-devel@lists.fedorahosted.org