Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mingw32-libgnurx - MinGW Regex library
https://bugzilla.redhat.com/show_bug.cgi?id=502534
Summary: Review Request: mingw32-libgnurx - MinGW Regex library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: erik-fedora@vanpienbroek.nl QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com, fedora-mingw@lists.fedoraproject.org Classification: Fedora
Spec URL: http://www.ftd4linux.nl/contrib/mingw32-libgnurx.spec SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-libgnurx-2.5.1-1.fc11.src.rpm Description: MinGW Windows regular expression library
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1376442
Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
Thomas Sailer t.sailer@alumni.ethz.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |t.sailer@alumni.ethz.ch AssignedTo|nobody@fedoraproject.org |t.sailer@alumni.ethz.ch Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
--- Comment #1 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-05-26 03:09:42 EDT --- Fedora review http://www.ftd4linux.nl/contrib/mingw32-libgnurx-2.5.1-1.fc11.src.rpm 2009-05-26
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1376692
rpmlint output: $ rpmlint mingw*.rpm mingw32-libgnurx.spec mingw32-libgnurx-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libregex.a mingw32-libgnurx-static.noarch: W: no-documentation 4 packages and 1 specfiles checked; 1 errors, 1 warnings.
As per Packaging/MinGW, these errors can be ignored.
+ OK ! needs attention
+ rpmlint output + Package is named according to Fedora MinGW packaging guidelines + Specfile name matches the package base name + Package follows the Fedora MinGW packaging guidelines version seems to be slightly ahead of native (1.1 vs. 1.0) please try to stick to the native version + License meets guidelines and is acceptable to Fedora LGPLv2.1 ! License matches the actual package license Its not BSD + The package contains the license file (COPYING.LIB) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm 35c8fed3101ca1f253e9b6b1966661f6 mingw-libgnurx-2.5.1-src.tar.gz 35c8fed3101ca1f253e9b6b1966661f6 x/mingw-libgnurx-2.5.1-src.tar.gz
n/a Package builds in mock n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package + Static libraries should be in -static n/a Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
--- Comment #2 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-26 04:57:16 EDT --- Spec URL: http://www.ftd4linux.nl/contrib/mingw32-libgnurx.spec SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-libgnurx-2.5.1-2.fc11.src.rpm
* Tue May 26 2009 Erik van Pienbroek epienbro@fedoraproject.org - 2.5.1-2 - Fixed license tag
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
--- Comment #3 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-05-26 05:17:39 EDT --- APPROVED by sailer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
Thomas Sailer t.sailer@alumni.ethz.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-26 05:22:24 EDT --- Thanks for the quick review!
New Package CVS Request ======================= Package Name: mingw32-libgnurx Short Description: MinGW Regex library Owners: epienbro rjones Branches: F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Jason Tibbitts tibbs@math.uh.edu 2009-05-26 18:37:27 EDT --- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2009-06-02 11:15:07 EDT --- mingw32-libgnurx-2.5.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mingw32-libgnurx-2.5.1-2.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-06-02 11:15:42 EDT --- mingw32-libgnurx-2.5.1-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-libgnurx-2.5.1-2.fc10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-06-04 17:16:08 EDT --- mingw32-libgnurx-2.5.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Fixed In Version| |2.5.1-2.fc11 Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2009-06-04 17:19:30 EDT --- mingw32-libgnurx-2.5.1-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=502534
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|2.5.1-2.fc11 |2.5.1-2.fc10