Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=490133
Richard W.M. Jones rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Richard W.M. Jones rjones@redhat.com 2009-03-13 13:52:00 EDT --- + rpmlint output + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible - upstream sources match sources in the srpm 218cef1a39ebda6cfa440a0727464275 1686166
Source URL is incorrect. It should be:
Source: http://downloads.sourceforge.net/%%7Bname1%7D/%%7Bname1%7D-%%7Bversion%7D.ta... ^^^^^^^^
+ package successfully builds on at least one architecture x86_64 n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun n/a does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf $RPM_BUILD_ROOT + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8
Optional:
n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available - reviewer should build the package in mock ? the package should build into binary RPMs on all supported architectures ? review should test the package functions as described n/a scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
----------------
Why are these lines commented out? #%{_qt4_plugindir}/designer/libqwt_designer_plugin.so #%{_mingw32_libdir}/qt4/plugins/designer/libqwt_designer_plugin.so
I will approve this package. Before uploading, please fix the Source line.
---------------- Package APPROVED by rjones. ----------------