Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642208
Kalev Lember <kalev(a)smartlink.ee> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody(a)fedoraproject.org |kalev(a)smartlink.ee
Flag| |fedora-review+
--- Comment #5 from Kalev Lember <kalev(a)smartlink.ee> 2011-05-11 02:52:29 EDT ---
No feedback to the mail, so I guess lets give it a try.
I'm approving the package based on Amorilia's review. Thanks Amorilia!
Erik, if you want to simplify some things in the spec file, then the BuildRoot
tag, the 'rm -rf $RPM_BUILD_ROOT' at the beginning of %install, the whole
%clean section, and the default %defattrs are no longer needed with current
Fedora releases.
Also, the Obsoletes and Provides currently have %dist macro in them; it's more
common to leave that out, since the 'mingw32-iconv < 1.12-14' comparison would
already match the current 'mingw32-iconv-1.12-13.fc15' package:
Obsoletes: mingw32-iconv < 1.12-14
Provides: mingw32-iconv = 1.12-14
But these are all things one would do during the normal maintenance of a
package and not blocking the review.
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.