Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: mingw32-zfstream - MinGW Windows C++ abstraction library for compressed and non-compressed file I/O Alias: mingw32-zfstream
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Summary: Review Request: mingw32-zfstream - MinGW Windows C++ abstraction library for compressed and non-compressed file I/O Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: t.sailer@alumni.ethz.ch QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com, fedora-mingw@lists.fedoraproject.org Classification: Fedora
Spec URL: http://sailer.fedorapeople.org/mingw32-zfstream.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-zfstream-20041202-3.fc11.src.rpm Description: MinGW Windows C++ abstraction library for compressed and non-compressed file I/O.
Approved MinGW packaging guidelines are here: http://fedoraproject.org/wiki/Packaging/MinGW
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Thomas Sailer t.sailer@alumni.ethz.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |438588
--- Comment #1 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-03-23 07:13:04 EDT --- Note: the review request for the native version of this library is still pending, see https://bugzilla.redhat.com/show_bug.cgi?id=438588
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Thomas Sailer t.sailer@alumni.ethz.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |498508
--- Comment #2 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-04-30 18:21:47 EDT --- Update: Spec URL: http://sailer.fedorapeople.org/mingw32-zfstream.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-zfstream-20041202-4.fc11.src.rpm
Incorporate changes to native zfstream.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |erik-fedora@vanpienbroek.nl AssignedTo|nobody@fedoraproject.org |erik-fedora@vanpienbroek.nl
Bug 491616 depends on bug 438588, which changed state.
Bug 438588 Summary: Review Request: zfstream - C++ iostream like access to compressed files https://bugzilla.redhat.com/show_bug.cgi?id=438588
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Bug 491616 depends on bug 498508, which changed state.
Bug 498508 Summary: mingw32-zlib does not build mingw32-minizip https://bugzilla.redhat.com/show_bug.cgi?id=498508
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|NEW |CLOSED
--- Comment #3 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-14 16:59:02 EDT --- Let's take this for review. Looks good at first sight :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review?
--- Comment #4 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-14 17:55:47 EDT --- - The package fails to compile due to a missing BR: mingw32-gcc-c++. After adding this, the package compiles fine - The patch contains a comment mentioning it has been sent upstream, but what does the patch actually fix?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
--- Comment #5 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-05-14 18:31:47 EDT --- (In reply to comment #4)
- The package fails to compile due to a missing BR: mingw32-gcc-c++. After
adding this, the package compiles fine
Update: Spec URL: http://sailer.fedorapeople.org/mingw32-zfstream.spec SRPM URL: http://sailer.fedorapeople.org/mingw32-zfstream-20041202-5.fc11.src.rpm
- The patch contains a comment mentioning it has been sent upstream, but what
does the patch actually fix?
The patch fixes the inability of zfstream to read/write zip files. Without the patch, it can only read/write .gz and .bz2 and uncompressed files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Wojciech Pilorz wpilorz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wpilorz@gmail.com
--- Comment #6 from Wojciech Pilorz wpilorz@gmail.com 2009-05-15 08:37:44 EDT --- There was a bug report from Hiroshi Kuno on zlib-devel mailing list at Feb 6, 2009:
Please find it attached below, as well as response form Mark Adler. I would suggest looking at the bug, as it might propagate to zfstream; --------------------------------------- I found a bug in minizip, when i create a zip file on a FD. That lose a write error (i.e. disk full), and return ZIP_OK. Thus, the minizip make a broken zip file without a error.
** Where is bug.
zipCloseFileInZipRaw() in src/contrib/minizip/zip.c
1067 if ((zi->ci.pos_in_buffered_data>0) && (err==ZIP_OK)) 1068 if (zipFlushWriteBuffer(zi)==ZIP_ERRNO) 1069 err = ZIP_ERRNO; /* 1. Here, setting ZIP_ERRNO to "err" */ 1070 1071 if ((zi->ci.method == Z_DEFLATED) && (!zi->ci.raw)) 1072 { 1073 err=deflateEnd(&zi->ci.stream); /* 2. BUG! overwriting defalteEnd()'s return-value(ZIP_OK) to "err" */ 1074 zi->ci.stream_initialised = 0; 1075 } 1076
** How to fix.
I have made a small patch that avoid to overwrite to "err", when "err" has a error code. Would you merge my patch?
ndex: /zlib/branches/BUG-write-error/src/contrib/minizip/zip.c =================================================================== --- /zlib/branches/BUG-write-error/src/contrib/minizip/zip.c (revision 537) +++ /zlib/branches/BUG-write-error/src/contrib/minizip/zip.c (revision 566) @@ -1071,5 +1071,6 @@ if ((zi->ci.method == Z_DEFLATED) && (!zi->ci.raw)) { - err=deflateEnd(&zi->ci.stream); + int tmperr=deflateEnd(&zi->ci.stream); + if (err==ZIP_OK) err = tmperr; zi->ci.stream_initialised = 0; }
-------------------------------------------- From: xxx (Mark Adler) Date: Thu, 5 Feb 2009 22:03:34 -0800 Subject: [Zlib-devel] Patch for losing a write error
Hiroshi,
Minizip is a contribution to zlib from Gilles Vollant. He is however on this list, so he may respond.
Mark
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
--- Comment #7 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-05-15 09:14:48 EDT --- (In reply to comment #6)
I would suggest looking at the bug, as it might propagate to zfstream;
Thanks for the report. zfstream is fine however, as it does not include minizip (anymore), but links to minizip provided by the zlib and mingw32-zlib packages. So this bug needs to be fixed in zlib (mingw32-zlib), then zfstream is automatically fixed, as it links dynamically to the minizip DLL / shared lib.
Have you reported the bug against zlib and mingw32-zlib?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
--- Comment #8 from Wojciech Pilorz wpilorz@gmail.com 2009-05-18 07:00:01 EDT --- No, not yet
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #9 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2009-05-20 08:01:54 EDT --- $ rpmlint mingw32-zfstream.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw32-zfstream-20041202-5.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw32-zfstream-20041202-5.fc11.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Everything's okay, no further changes required
======================================================
The package mingw32-zfstream is APPROVED by epienbro
======================================================
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Thomas Sailer t.sailer@alumni.ethz.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #10 from Thomas Sailer t.sailer@alumni.ethz.ch 2009-05-20 08:22:52 EDT --- Thank you for the review.
New Package CVS Request ======================= Package Name: mingw32-zfstream Short Description: MinGW Windows C++ abstraction library for compressed and non-compressed file I/O Owners: sailer rjones Branches: F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #11 from Kevin Fenzi kevin@tummy.com 2009-05-21 19:45:26 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2009-05-21 20:15:51 EDT --- mingw32-zfstream-20041202-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/mingw32-zfstream-20041202-5.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2009-05-25 17:20:30 EDT --- mingw32-zfstream-20041202-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=491616
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |20041202-5.fc11 Resolution| |NEXTRELEASE