[Bug 1062291] Review Request: mingw-speex - Voice compression format (codec)
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1062291
František Dvořák <valtri(a)civ.zcu.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(valtri(a)civ.zcu.cz |
|) |
--- Comment #3 from František Dvořák <valtri(a)civ.zcu.cz> ---
(In reply to David King from comment #2)
> Only one thing needs fixing, which is to place the static libraries in a
> -static subpackage.
Actually these are stub libraries needed to build SW using the dll files.
.dll.a files should be included in the main mingw32/mingw64 packages together
with the .dll
(https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW#Example...)
> I suppose that it would be nice to carry that
> improvement over to the "native" package as well.
There are no static libraries in neither speex nor mingw-speex packages.
Guidelines don't recommend static libraries, but permit them if there is reason
for them.
Many mingw packages provide static libraries, they could be added here too. But
dependency mingw-libogg has also no static libraries anyway. :-)
> Packaging the latest
> version (1.2-0.19.rc1) would be nice, but is not a requirement.
>
That's only the age, I kept the version numbering from the original review (it
is probably not needed, but I preserved the %changlog too...).
> I really look forward to using this package while creating a MinGW build of
> EasyTAG! :-)
>
Nice. :-) Thanks for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zdJkRQOucu&a=cc_unsubscribe
10 years, 3 months
[Bug 1062291] Review Request: mingw-speex - Voice compression format (codec)
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1062291
David King <amigadave(a)amigadave.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |valtri(a)civ.zcu.cz
Flags| |needinfo?(valtri(a)civ.zcu.cz
| |)
--- Comment #2 from David King <amigadave(a)amigadave.com> ---
Only one thing needs fixing, which is to place the static libraries in a
-static subpackage. I suppose that it would be nice to carry that improvement
over to the "native" package as well. Packaging the latest version
(1.2-0.19.rc1) would be nice, but is not a requirement.
I really look forward to using this package while creating a MinGW build of
EasyTAG! :-)
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable
Issues:
=======
- Header files in -devel subpackage, if present.
Note: mingw32-speex : /usr/i686-w64-mingw32/sys-
root/mingw/include/speex/speex.h mingw32-speex : /usr/i686-w64-mingw32/sys-
root/mingw/include/speex/speex_bits.h mingw32-speex : /usr/i686-w64-mingw32
/sys-root/mingw/include/speex/speex_buffer.h mingw32-speex :
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_callbacks.h
mingw32-speex : /usr/i686-w64-mingw32/sys-
root/mingw/include/speex/speex_config_types.h mingw32-speex :
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_echo.h
mingw32-speex : /usr/i686-w64-mingw32/sys-
root/mingw/include/speex/speex_header.h mingw32-speex :
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_jitter.h
mingw32-speex : /usr/i686-w64-mingw32/sys-
root/mingw/include/speex/speex_preprocess.h mingw32-speex :
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_resampler.h
mingw32-speex : /usr/i686-w64-mingw32/sys-
root/mingw/include/speex/speex_stereo.h mingw32-speex :
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_types.h
mingw64-speex : /usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex.h
mingw64-speex : /usr/x86_64-w64-mingw32/sys-
root/mingw/include/speex/speex_bits.h mingw64-speex :
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_buffer.h
mingw64-speex : /usr/x86_64-w64-mingw32/sys-
root/mingw/include/speex/speex_callbacks.h mingw64-speex :
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_config_types.h
mingw64-speex : /usr/x86_64-w64-mingw32/sys-
root/mingw/include/speex/speex_echo.h mingw64-speex :
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_header.h
mingw64-speex : /usr/x86_64-w64-mingw32/sys-
root/mingw/include/speex/speex_jitter.h mingw64-speex :
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_preprocess.h
mingw64-speex : /usr/x86_64-w64-mingw32/sys-
root/mingw/include/speex/speex_resampler.h mingw64-speex :
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_stereo.h
mingw64-speex : /usr/x86_64-w64-mingw32/sys-
root/mingw/include/speex/speex_types.h
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
Not a problem for MinGW packages.
- Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: mingw32-speex, mingw64-speex. Illegal package
name: mingw32-speex, mingw64-speex. Does not provide -static: mingw32-speex,
mingw64-speex.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
Should be fixed, by adding -static subpackages.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (3 clause)", "*No copyright* BSD (3 clause)", "LGPL (v2 or later)
(with incorrect FSF address)", "Unknown or generated". 16 files have
unknown license. Detailed output of licensecheck in
/home/david/checkout/rpms/1062291-mingw-speex/licensecheck.txt
The LGPL files from the source tarball (getopt.h, getopt1.c and getopt_win.h)
are not used on MinGW, so this is fine.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 10 files.
[!]: Package complies to the Packaging Guidelines
-static subpackage required, as above.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
mingw32-speex , mingw32-speex-tools , mingw64-speex , mingw64-speex-tools
[x]: Package functions as described.
[!]: Latest version is packaged.
Current Fedora package is at version 1.2-0.19.rc1.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
Note: mingw32-speex : /usr/i686-w64-mingw32/sys-
root/mingw/lib/pkgconfig/speex.pc mingw32-speex : /usr/i686-w64-mingw32
/sys-root/mingw/lib/pkgconfig/speexdsp.pc mingw64-speex :
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/speex.pc
mingw64-speex : /usr/x86_64-w64-mingw32/sys-
root/mingw/lib/pkgconfig/speexdsp.pc
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: mingw32-speex-1.2-0.16.rc1.fc21.noarch.rpm
mingw32-speex-tools-1.2-0.16.rc1.fc21.noarch.rpm
mingw64-speex-1.2-0.16.rc1.fc21.noarch.rpm
mingw64-speex-tools-1.2-0.16.rc1.fc21.noarch.rpm
mingw-speex-1.2-0.16.rc1.fc21.src.rpm
mingw32-speex.noarch: W: spelling-error Summary(en_US) codec -> codex, code,
codes
mingw32-speex.noarch: W: spelling-error %description -l en_US kbps -> bps,
kips, k bps
Bogus warning.
mingw32-speex.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a
mingw32-speex.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-w64-mingw32/sys-root/mingw/lib/libspeex.dll.a
Fine according to
https://fedoraproject.org/wiki/MinGW/Rpmlint#arch-independent-package-con...
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_buffer.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a
mingw32-speex.noarch: W: spurious-executable-perm
/usr/i686-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_bits.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_header.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_callbacks.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/lib/libspeex.dll.a
mingw32-speex.noarch: W: spurious-executable-perm
/usr/i686-w64-mingw32/sys-root/mingw/lib/libspeex.dll.a
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_jitter.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_echo.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_config_types.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_stereo.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/speexdsp.pc
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_types.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_preprocess.h
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/speex.pc
mingw32-speex.noarch: W: devel-file-in-non-devel-package
/usr/i686-w64-mingw32/sys-root/mingw/include/speex/speex_resampler.h
Fine according to
https://fedoraproject.org/wiki/MinGW/Rpmlint#devel-file-in-non-devel-package
mingw32-speex.noarch: W: non-standard-dir-in-usr i686-w64-mingw32
Fine according to
https://fedoraproject.org/wiki/MinGW/Rpmlint#non-standard-dir-in-usr_i686...
mingw32-speex-tools.noarch: W: spelling-error %description -l en_US kbps ->
bps, kips, k bps
mingw32-speex-tools.noarch: W: no-documentation
mingw32-speex-tools.noarch: W: non-standard-dir-in-usr i686-w64-mingw32
mingw64-speex.noarch: W: spelling-error Summary(en_US) codec -> codex, code,
codes
mingw64-speex.noarch: W: spelling-error %description -l en_US kbps -> bps,
kips, k bps
mingw64-speex.noarch: E: arch-independent-package-contains-binary-or-object
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeex.dll.a
mingw64-speex.noarch: E: arch-independent-package-contains-binary-or-object
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeex.dll.a
mingw64-speex.noarch: W: spurious-executable-perm
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeex.dll.a
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_bits.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_jitter.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/speex.pc
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/speexdsp.pc
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_buffer.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_header.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_config_types.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a
mingw64-speex.noarch: W: spurious-executable-perm
/usr/x86_64-w64-mingw32/sys-root/mingw/lib/libspeexdsp.dll.a
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_preprocess.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_types.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_callbacks.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_stereo.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_resampler.h
mingw64-speex.noarch: W: devel-file-in-non-devel-package
/usr/x86_64-w64-mingw32/sys-root/mingw/include/speex/speex_echo.h
mingw64-speex.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32
mingw64-speex-tools.noarch: W: spelling-error %description -l en_US kbps ->
bps, kips, k bps
mingw64-speex-tools.noarch: W: no-documentation
mingw64-speex-tools.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32
mingw-speex.src: W: spelling-error Summary(en_US) codec -> codex, code, codes
mingw-speex.src: W: spelling-error %description -l en_US kbps -> bps, kips, k
bps
mingw-speex.src: W: strange-permission mingw-speex.spec 0600L
5 packages and 0 specfiles checked; 4 errors, 51 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint mingw64-speex-tools mingw32-speex-tools mingw32-spe
ex mingw64-speex
mingw64-speex-tools.noarch: W: spelling-error %description -l en_US kbps ->
bps, kips, k bps
mingw64-speex-tools.noarch: W: no-documentation
mingw32-speex-tools.noarch: W: spelling-error %description -l en_US kbps ->
bps, kips, k bps
mingw32-speex-tools.noarch: W: no-documentation
mingw32-speex.noarch: W: spelling-error Summary(en_US) codec -> codex, code,
codes
mingw32-speex.noarch: W: spelling-error %description -l en_US kbps -> bps,
kips, k bps
mingw64-speex.noarch: W: spelling-error Summary(en_US) codec -> codex, code,
codes
mingw64-speex.noarch: W: spelling-error %description -l en_US kbps -> bps,
kips, k bps
4 packages and 0 specfiles checked; 0 errors, 8 warnings.
# echo 'rpmlint-done:'
Requires
--------
mingw64-speex-tools (rpmlib, GLIBC filtered):
mingw64(kernel32.dll)
mingw64(libogg-0.dll)
mingw64(libspeex-1.dll)
mingw64(libspeexdsp-1.dll)
mingw64(msvcrt.dll)
mingw64(user32.dll)
mingw64(winmm.dll)
mingw64-crt
mingw64-filesystem
mingw64-speex
mingw32-speex-tools (rpmlib, GLIBC filtered):
mingw32(kernel32.dll)
mingw32(libogg-0.dll)
mingw32(libspeex-1.dll)
mingw32(libspeexdsp-1.dll)
mingw32(msvcrt.dll)
mingw32(user32.dll)
mingw32(winmm.dll)
mingw32-crt
mingw32-filesystem
mingw32-speex
mingw32-speex (rpmlib, GLIBC filtered):
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(msvcrt.dll)
mingw32-crt
mingw32-filesystem
mingw32-pkg-config
mingw64-speex (rpmlib, GLIBC filtered):
mingw64(kernel32.dll)
mingw64(libgcc_s_seh-1.dll)
mingw64(msvcrt.dll)
mingw64-crt
mingw64-filesystem
mingw64-pkg-config
Provides
--------
mingw64-speex-tools:
mingw64-speex-tools
mingw32-speex-tools:
mingw32-speex-tools
mingw32-speex:
mingw32(libspeex-1.dll)
mingw32(libspeexdsp-1.dll)
mingw32-speex
mingw64-speex:
mingw64(libspeex-1.dll)
mingw64(libspeexdsp-1.dll)
mingw64-speex
Source checksums
----------------
http://downloads.xiph.org/releases/speex/speex-1.2rc1.tar.gz :
CHECKSUM(SHA256) this package :
342f30dc57bd4a6dad41398365baaa690429660b10d866b7d508e8f1179cb7a6
CHECKSUM(SHA256) upstream package :
342f30dc57bd4a6dad41398365baaa690429660b10d866b7d508e8f1179cb7a6
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1062291
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IsVJ7NEfXp&a=cc_unsubscribe
10 years, 3 months