[Bug 979564] Review Request: mingw-sane-backends - MinGW package for SANE
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=979564
Sandro Mani <manisandro(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--- Comment #1 from Sandro Mani <manisandro(a)gmail.com> ---
Must fix:
- mingw{32,64}-pthreads BR are missing
- ftp://ftp.sane-project.org seems down (temporary?), so Source0 does not work.
- License breakdown must be documented [1]
- Requires of -static subpackages are incorrect.
(The way I do it is to define %pkgname with the native package name, and then
prefix it with mingw32 and mingw64 as necessary, i.e.
%global pkgname sane-backends
[...]
Requires: mingw32-%{pkgname} = %{version}-%{release}
[...]
Requires: mingw64-%{pkgname} = %{version}-%{release}
)
- Unowned directories:
* %{mingw32/64_includedir}/sane
* %{mingw32_sysconfdir}/sane.d
Should fix:
- BuildRoot is not required anymore since F10 [2]
- %defattr is not needed anymore
- Add a comment explaining the patch
- Rpmlint warnings/errors:
* mingw32-sane-backends.noarch: E: incorrect-fsf-address
/usr/i686-w64-mingw32/sys-root/mingw/include/sane/saneopts.h
* mingw32-sane-backends.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw32-sane-backends-1.0.23/COPYING
* mingw32-sane-backends-static.noarch: W: summary-ended-with-dot C Static
version of the Scanner Access Now Easy (SANE) universal scanner interface.
* mingw32-sane-backends-static.noarch: E: summary-too-long C Static version of
the Scanner Access Now Easy (SANE) universal scanner interface.
* mingw32-sane-backends-static.noarch: E: description-line-too-long C Static
version of the Scanner Access Now Easy (SANE) universal scanner interface.
* mingw32-sane-backends-static.noarch: W: no-documentation
* mingw64-sane-backends.noarch: W: summary-ended-with-dot C Static version of
the Scanner Access Now Easy (SANE) universal scanner interface.
* mingw64-sane-backends.noarch: E: summary-too-long C Static version of the
Scanner Access Now Easy (SANE) universal scanner interface.
* mingw64-sane-backends.noarch: E: incorrect-fsf-address
/usr/share/doc/mingw64-sane-backends-1.0.23/COPYING
* mingw64-sane-backends.noarch: E: incorrect-fsf-address
/usr/x86_64-w64-mingw32/sys-root/mingw/include/sane/saneopts.h
* mingw64-sane-backends-static.noarch: W: summary-ended-with-dot C Static
version of the Scanner Access Now Easy (SANE) universal scanner interface.
* mingw64-sane-backends-static.noarch: E: summary-too-long C Static version of
the Scanner Access Now Easy (SANE) universal scanner interface.
* mingw64-sane-backends-static.noarch: E: description-line-too-long C Static
version of the Scanner Access Now Easy (SANE) universal scanner interface.
* mingw64-sane-backends-static.noarch: W: no-documentation
[1]
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging...
[2] http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zQ30dLEV5v&a=cc_unsubscribe
10 years, 10 months
[Bug 961408] Review Request: mingw-tesseract - MinGW Windows tesseract-ocr library
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=961408
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #2 from Michael Cronenworth <mike(a)cchtml.com> ---
$ rpmlint mingw-tesseract-3.02.02-2.fc20.src.rpm \
mingw32-tesseract-3.02.02-2.fc18.noarch.rpm \
mingw32-tesseract-static-3.02.02-2.fc18.noarch.rpm \
mingw32-tesseract-tools-3.02.02-2.fc18.noarch.rpm \
mingw64-tesseract-3.02.02-2.fc18.noarch.rpm \
mingw64-tesseract-static-3.02.02-2.fc18.noarch.rpm
mingw64-tesseract-tools-3.02.02-2.fc18.noarch.rpm \
mingw32-tesseract-debuginfo-3.02.02-2.fc18.noarch.rpm \
mingw64-tesseract-debuginfo-3.02.02-2.fc18.noarch.rpm
mingw-tesseract.src: W: spelling-error Summary(en_US) ocr -> OCR, cor, or
mingw-tesseract.src: W: spelling-error %description -l en_US ocr -> OCR, cor,
or
mingw-tesseract.src: W: invalid-url Source0:
http://leptonica.googlecode.com/files/tesseract-ocr-3.02.02.tar.gz HTTP Error
404: Not Found
mingw32-tesseract.noarch: W: spelling-error Summary(en_US) ocr -> OCR, cor, or
mingw32-tesseract.noarch: W: spelling-error %description -l en_US ocr -> OCR,
cor, or
mingw32-tesseract-static.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw32-tesseract-static.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw32-tesseract-static.noarch: W: no-documentation
mingw32-tesseract-tools.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw32-tesseract-tools.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw32-tesseract-tools.noarch: W: no-documentation
mingw64-tesseract.noarch: W: spelling-error Summary(en_US) ocr -> OCR, cor, or
mingw64-tesseract.noarch: W: spelling-error %description -l en_US ocr -> OCR,
cor, or
mingw64-tesseract-static.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw64-tesseract-static.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw64-tesseract-static.noarch: W: no-documentation
mingw64-tesseract-tools.noarch: W: spelling-error Summary(en_US) ocr -> OCR,
cor, or
mingw64-tesseract-tools.noarch: W: spelling-error %description -l en_US ocr ->
OCR, cor, or
mingw64-tesseract-tools.noarch: W: no-documentation
mingw32-tesseract-debuginfo.noarch: E: debuginfo-without-sources
mingw64-tesseract-debuginfo.noarch: E: debuginfo-without-sources
9 packages and 0 specfiles checked; 2 errors, 19 warnings.
The only warning that is of concern is the download link. Looks like a typo.
Should be:
http://tesseract-ocr.googlecode.com/files/tesseract-ocr-%{version}.tar.gz
+ OK
! needs attention
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
native Fedora package
+ The package contains the license file (COPYING.lib)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
26adc8154f0e815053816825dde246e6 Downloads/tesseract-ocr-3.02.02.tar.gz
26adc8154f0e815053816825dde246e6 SOURCES/tesseract-ocr-3.02.02.tar.gz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
+ Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
-----------
Summary:
- The review is for "tesseract" when upstream is "tesseract-ocr". I see the
native Fedora package is "tesseract" so I will pass it here.
- Just fix the SOURCE0 url and you are good to go!
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T8lCdgz0rf&a=cc_unsubscribe
10 years, 10 months
Some packages still affected by InterlockedCompareExchange regression
by Sandro Mani
Hi,
I'm still hitting the InterlockedCompareExchange regression described
here [1] (i.e. entry point for InterlockedCompareExchange@12 could not
be located in libintl-8.dll), and noticed that some packages are still
affected, that is still have the symbol in the dll. I've found one
package (i.e. mingw-gtkspellmm30 which I've taken care to rebuild)
which, although rebuilt to fix the issue, ended up still having
InterlockedCompareExchange@12 in the symbol table, as well as another
one which was not rebuilt at all, i.e. mingw-openssl.
Unfortunately, I'm not sure which is the best way to find out which
packages need to be (re-)rebuilt? (This is on rawhide btw.)
- Sandro
[1] http://comments.gmane.org/gmane.comp.gnu.mingw.w64.general/7411
10 years, 10 months
[mingw-glib2] Update to 2.37.4
by Erik van Pienbroek
commit 1d46ad1d547f1720756d717ff85319ae44e0dca8
Author: Erik van Pienbroek <epienbro(a)fedoraproject.org>
Date: Wed Jul 10 19:25:09 2013 +0200
Update to 2.37.4
mingw-glib2.spec | 7 +++++--
sources | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/mingw-glib2.spec b/mingw-glib2.spec
index 3bf06ea..eea49ec 100644
--- a/mingw-glib2.spec
+++ b/mingw-glib2.spec
@@ -1,8 +1,8 @@
%?mingw_package_header
Name: mingw-glib2
-Version: 2.37.3
-Release: 2%{?dist}
+Version: 2.37.4
+Release: 1%{?dist}
Summary: MinGW Windows GLib2 library
License: LGPLv2+
@@ -282,6 +282,9 @@ find $RPM_BUILD_ROOT -name "*.la" -delete
%changelog
+* Wed Jul 10 2013 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 2.37.4-1
+- Update to 2.37.4
+
* Thu Jun 27 2013 Kalev Lember <kalevlember(a)gmail.com> - 2.37.3-2
- Include the COPYING file in %%doc (thanks daumas for noticing it!)
diff --git a/sources b/sources
index a29a3f0..effe0bb 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-89377eed733ceaf4a6b2506897160c7e glib-2.37.3.tar.xz
+614f3b63ea1f012c5ed370bf3e101872 glib-2.37.4.tar.xz
10 years, 10 months