[Bug 661312] Review Request: mingw32-atkmm - MinGW Windows C++ interface for the ATK library
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661312
--- Comment #2 from Thomas Sailer <t.sailer(a)alumni.ethz.ch> 2010-12-09 05:54:13 EST ---
Thanks for taking this and for the quick response!
I've updated the links above with a version incorporating all your changes.
I now get 8 rpmlint warnings:
mingw32-atkmm.src: W: no-cleaning-of-buildroot %install
mingw32-atkmm.src: W: no-cleaning-of-buildroot %clean
mingw32-atkmm.src: W: no-buildroot-tag
mingw32-atkmm.src: W: no-%clean-section
mingw32-atkmm-debuginfo.noarch: E: debuginfo-without-sources
mingw32-atkmm.spec: W: no-cleaning-of-buildroot %install
mingw32-atkmm.spec: W: no-cleaning-of-buildroot %clean
mingw32-atkmm.spec: W: no-buildroot-tag
mingw32-atkmm.spec: W: no-%clean-section
3 packages and 1 specfiles checked; 1 errors, 8 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
13 years, 5 months
Re: Proposed package blocking due to FTBFS
by Richard W.M. Jones
On Mon, Dec 06, 2010 at 11:01:20PM -0600, Matt Domsch wrote:
> mingw32-libglademm24-2.6.7-8.fc12 [u'631374 NEW'] (build/make) sailer,rjones
> mingw32-pangomm-2.26.0-1.fc12 [u'631208 NEW'] (build/make) sailer,rjones
> mingw32-plotmm-0.1.2-4.fc12 [u'631082 NEW'] (build/make) sailer,rjones
> mingw32-gtkmm24-2.19.6-1.fc14 [u'631110 NEW'] (build/make) sailer,rjones
CC-ing to the mailing list. We've hired someone to take over the
"residual maintenance" of the few mingw32 packages that people are
using but not enough to want to take ownership. Unfortunately he
doesn't start for another 3 months.
> ocaml-deriving-0.1.1a-10.fc13 [u'631141 NEW'] (build/make) rjones,ocamlmaint
This will be fixed in the coming OCaml rebuild (F15 feature).
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top
13 years, 5 months
[mingw32-sqlite] fix patch
by sailer
commit 279919f6c6d953e0ffef4a535233634e5c6b9fbd
Author: Thomas Sailer <t.sailer(a)alumni.ethz.ch>
Date: Mon Dec 6 18:54:54 2010 +0100
fix patch
mingw32-sqlite.spec | 2 +-
sqlite-3.6.6.2-lemon-snprintf.patch | 111 -----------------------------------
sqlite-3.7.3-lemon-snprintf.patch | 76 ++++++++++++++++++++++++
3 files changed, 77 insertions(+), 112 deletions(-)
---
diff --git a/mingw32-sqlite.spec b/mingw32-sqlite.spec
index 855eb4a..421668d 100644
--- a/mingw32-sqlite.spec
+++ b/mingw32-sqlite.spec
@@ -25,7 +25,7 @@ BuildArch: noarch
# Patches from Fedora native package.
Patch1: sqlite-3.6.12-libdl.patch
# Avoid insecure sprintf(), use a system path for lempar.c, patch from Debian
-Patch2: sqlite-3.6.6.2-lemon-snprintf.patch
+Patch2: sqlite-3.7.3-lemon-snprintf.patch
# Patches for MinGW port.
Patch1000: mingw32-sqlite-3.6.12-no-undefined.patch
diff --git a/sqlite-3.7.3-lemon-snprintf.patch b/sqlite-3.7.3-lemon-snprintf.patch
new file mode 100644
index 0000000..98e48e3
--- /dev/null
+++ b/sqlite-3.7.3-lemon-snprintf.patch
@@ -0,0 +1,76 @@
+diff -up sqlite-3.7.3/tool/lemon.c.lemparpath sqlite-3.7.3/tool/lemon.c
+--- sqlite-3.7.3/tool/lemon.c.lemparpath 2008-12-05 20:37:49.000000000 +0200
++++ sqlite-3.7.3/tool/lemon.c 2008-12-05 20:44:08.000000000 +0200
+@@ -2363,7 +2363,7 @@
+ for(z=psp->filename, nBack=0; *z; z++){
+ if( *z=='\\' ) nBack++;
+ }
+- sprintf(zLine, "#line %d ", psp->tokenlineno);
++ snprintf(zLine, sizeof zLine, "#line %d ", psp->tokenlineno);
+ nLine = lemonStrlen(zLine);
+ n += nLine + lemonStrlen(psp->filename) + nBack;
+ }
+@@ -2947,7 +2947,7 @@
+ while( cfp ){
+ char buf[20];
+ if( cfp->dot==cfp->rp->nrhs ){
+- sprintf(buf,"(%d)",cfp->rp->index);
++ snprintf(buf,sizeof buf,"(%d)",cfp->rp->index);
+ fprintf(fp," %5s ",buf);
+ }else{
+ fprintf(fp," ");
+@@ -3118,14 +3118,16 @@
+
+ cp = strrchr(lemp->filename,'.');
+ if( cp ){
+- sprintf(buf,"%.*s.lt",(int)(cp-lemp->filename),lemp->filename);
++ snprintf(buf,sizeof buf,"%.*s.lt",(int)(cp-lemp->filename),lemp->filename);
+ }else{
+- sprintf(buf,"%s.lt",lemp->filename);
++ snprintf(buf,sizeof buf,"%s.lt",lemp->filename);
+ }
+ if( access(buf,004)==0 ){
+ tpltname = buf;
+ }else if( access(templatename,004)==0 ){
+ tpltname = templatename;
++ }else if( access("/usr/share/lemon/lempar.c",004)==0 ){
++ tpltname = "/usr/share/lemon/lempar.c";
+ }else{
+ tpltname = pathsearch(lemp->argv0,templatename,0);
+ }
+@@ -3137,7 +3139,7 @@
+ }
+ in = fopen(tpltname,"rb");
+ if( in==0 ){
+- fprintf(stderr,"Can't open the template file \"%s\".\n",templatename);
++ fprintf(stderr,"Can't open the template file \"%s\".\n",tpltname);
+ lemp->errorcnt++;
+ return 0;
+ }
+@@ -3271,7 +3273,7 @@
+ while( n-- > 0 ){
+ c = *(zText++);
+ if( c=='%' && n>0 && zText[0]=='d' ){
+- sprintf(zInt, "%d", p1);
++ snprintf(zInt, sizeof zInt, "%d", p1);
+ p1 = p2;
+ strcpy(&z[used], zInt);
+ used += lemonStrlen(&z[used]);
+@@ -3883,7 +3885,7 @@
+ /* Generate a table containing the symbolic name of every symbol
+ */
+ for(i=0; i<lemp->nsymbol; i++){
+- sprintf(line,"\"%s\",",lemp->symbols[i]->name);
++ snprintf(line,sizeof line,"\"%s\",",lemp->symbols[i]->name);
+ fprintf(out," %-15s",line);
+ if( (i&3)==3 ){ fprintf(out,"\n"); lineno++; }
+ }
+@@ -4049,7 +4051,7 @@
+ in = file_open(lemp,".h","rb");
+ if( in ){
+ for(i=1; i<lemp->nterminal && fgets(line,LINESIZE,in); i++){
+- sprintf(pattern,"#define %s%-30s %2d\n",prefix,lemp->symbols[i]->name,i);
++ snprintf(pattern,sizeof pattern,"#define %s%-30s %2d\n",prefix,lemp->symbols[i]->name,i);
+ if( strcmp(line,pattern) ) break;
+ }
+ fclose(in);
13 years, 5 months
[mingw32-sqlite] update to 3.7.3
by sailer
commit 33b088e961a38a22572282f9ed9d7b5c89c93104
Author: Thomas Sailer <t.sailer(a)alumni.ethz.ch>
Date: Mon Dec 6 18:34:18 2010 +0100
update to 3.7.3
.gitignore | 1 +
mingw32-sqlite.spec | 5 ++++-
sources | 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 1979d9f..a893e46 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,4 @@ sqlite-3.6.14.2.tar.gz
sqlite-3.6.17.tar.gz
sqlite-3.6.20.tar.gz
sqlite-3.6.22.tar.gz
+/sqlite-3.7.3.tar.gz
diff --git a/mingw32-sqlite.spec b/mingw32-sqlite.spec
index 7d79241..855eb4a 100644
--- a/mingw32-sqlite.spec
+++ b/mingw32-sqlite.spec
@@ -10,7 +10,7 @@
%global tclversion 8.5
Name: mingw32-sqlite
-Version: 3.6.22
+Version: 3.7.3
Release: 1%{?dist}
Summary: MinGW Windows port of sqlite embeddable SQL database engine
@@ -140,6 +140,9 @@ rm -rf $RPM_BUILD_ROOT
%endif
%changelog
+* Mon Dec 6 2010 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 3.7.3-1
+- update to 3.7.3
+
* Sun Jan 31 2010 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 3.6.22-1
- update to 3.6.22
diff --git a/sources b/sources
index 7e6903f..a3301bf 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-a17bd53f1fde11f84adf79c6a1510ce5 sqlite-3.6.22.tar.gz
+5437978aae90350cf984993091e0d695 sqlite-3.7.3.tar.gz
13 years, 5 months