On Fri, Jul 30, 2010 at 02:08:42PM +0200, Andrew Beekhof wrote:
On Tue, Jul 27, 2010 at 2:03 PM, Darryl L. Pierce
<dpierce(a)redhat.com> wrote:
>
> Signed-off-by: Darryl L. Pierce <dpierce(a)redhat.com>
> ---
> src/host.cpp | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/src/host.cpp b/src/host.cpp
> index d6955a5..29dcc29 100644
> --- a/src/host.cpp
> +++ b/src/host.cpp
> @@ -162,7 +162,6 @@ host_get_architecture()
>
> if(architecture.empty())
> {
> -
> #ifdef __linux__
> struct utsname details;
>
> @@ -170,8 +169,9 @@ host_get_architecture()
> {
> architecture = string(details.machine);
> }
> -#endif
> +#elif defined WIN32
Should we fill in a default here? Perhaps:
architecture = string("win32");
Otherwise, ACK
The API needs to be more specific; i.e., this could be a 64-bit Windows
platform. But, yes, we can set the architecture for the time being to be
WIN32 based on the compiler directive at that point. I'll add that and
then push the patch.
--
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/