Code wise this looks fine, but the list of possible return values
needs to be documented somehwere. I guess the schema is the best
place for now.
--
Russell Bryant
On Thu, Aug 11, 2011 at 4:09 PM, Adam Stokes <astokes(a)fedoraproject.org> wrote:
Signed-off-by: Adam Stokes <astokes(a)fedoraproject.org>
---
src/sysconfig/sysconfig-qmf.cpp | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/sysconfig/sysconfig-qmf.cpp b/src/sysconfig/sysconfig-qmf.cpp
index 962ca3d..372f1cc 100644
--- a/src/sysconfig/sysconfig-qmf.cpp
+++ b/src/sysconfig/sysconfig-qmf.cpp
@@ -89,18 +89,18 @@ ConfigAgent::invoke(qmf::AgentSession session, qmf::AgentEvent event,
gpointer u
args["scheme"].asString().c_str(),
args["key"].asString().c_str());
if (rc == 0) {
- mh_sysconfig_set_configured(args["key"].asString().c_str());
+ rc = mh_sysconfig_set_configured(args["key"].asString().c_str());
}
- event.addReturnArgument("status", rc);
+ event.addReturnArgument("status", rc ? "ok" :
"no");
} else if (methodName == "run_string") {
rc = mh_sysconfig_run_string(args["data"].asString().c_str(),
args["flags"].asUint32(),
args["scheme"].asString().c_str(),
args["key"].asString().c_str());
if (rc == 0) {
- mh_sysconfig_set_configured(args["key"].asString().c_str());
+ rc = mh_sysconfig_set_configured(args["key"].asString().c_str());
}
- event.addReturnArgument("status", rc);
+ event.addReturnArgument("status", rc ? "ok" :
"no");
} else if (methodName == "query") {
const char *data = NULL;
data = mh_sysconfig_query(args["query"].asString().c_str(),
--
1.7.6
_______________________________________________
Matahari mailing list
Matahari(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/matahari