Thanks! I merged a slightly modified version of this patch using struct
initializers instead of memset().
On 08/17/2011 05:09 AM, Roman Rakus wrote:
Coverity is complaining about using some uninitialized values.
Signed-off-by: Roman Rakus<rrakus(a)redhat.com>
---
src/lib/dnssrv_linux.c | 2 ++
src/lib/mainloop.c | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/lib/dnssrv_linux.c b/src/lib/dnssrv_linux.c
index e6863af..4877963 100644
--- a/src/lib/dnssrv_linux.c
+++ b/src/lib/dnssrv_linux.c
@@ -39,6 +39,8 @@ mh_os_dnssrv_lookup(const char *query)
ns_rr rr;
int size, rrnum;
+ memset(&nsh, 0, sizeof(nsh));
+
size = res_query(query,
C_IN,
T_SRV,
diff --git a/src/lib/mainloop.c b/src/lib/mainloop.c
index f68a555..f398fbb 100644
--- a/src/lib/mainloop.c
+++ b/src/lib/mainloop.c
@@ -170,6 +170,8 @@ mainloop_signal(int sig, void (*dispatch)(int sig))
struct sigaction sa;
struct sigaction old;
+ memset(&sa, 0, sizeof(sa));
+
if (sigemptyset(&mask)< 0) {
mh_perror(LOG_ERR, "Call to sigemptyset failed");
return FALSE;