On Mon, May 9, 2011 at 10:06 PM, astokes@fedoraproject.org wrote:
From: Adam Stokes astokes@fedoraproject.org
- We hardcoded reconnect to True in our agent code but this can hinder us when wanting to automate testing. We set reconnect to false by default and have the user decide whether or not they want their agents to keep trying to connect to a failed/misconfigured broker.
The code part is fine, but we need to turn it on by default in our sysconfig file. Both for compatibility reasons and because thats what most people are going to want.
src/lib/mh_agent.cpp | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/lib/mh_agent.cpp b/src/lib/mh_agent.cpp index d8f8417..23f5e3f 100644 --- a/src/lib/mh_agent.cpp +++ b/src/lib/mh_agent.cpp @@ -91,6 +91,7 @@ struct option opt[] = { {"password", required_argument, NULL, 'P'}, {"service", required_argument, NULL, 's'}, {"port", required_argument, NULL, 'p'},
- {"reconnect", no_argument, NULL, 'r'},
{0, 0, 0, 0} };
@@ -106,6 +107,7 @@ print_usage(const char *proc_name) printf("\t-P | --password password to use for authentication purproses.\n"); printf("\t-s | --service service name to use for authentication purproses.\n"); printf("\t-p | --port specify broker port.\n");
- printf("\t-r | --reconnect attempt to reconnect on failure.\n");
} #endif
@@ -140,6 +142,7 @@ MatahariAgent::init(int argc, char **argv, const char* proc_name) #endif
bool gssapi = false;
- bool reconnect = false;
char *servername = NULL; char *username = NULL; char *password = NULL; @@ -201,7 +204,7 @@ MatahariAgent::init(int argc, char **argv, const char* proc_name) #else
// Get args
- while ((arg = getopt_long(argc, argv, "hdb:gu:P:s:p:v", opt, &idx)) != -1) {
- while ((arg = getopt_long(argc, argv, "hdb:gru:P:s:p:v", opt, &idx)) != -1) {
switch (arg) { case 'h': case '?': @@ -242,6 +245,9 @@ MatahariAgent::init(int argc, char **argv, const char* proc_name) case 'g': gssapi = true; break;
- case 'r':
- reconnect = true;
- break;
case 'p': if (optarg) { serverport = atoi(optarg); @@ -288,7 +294,7 @@ MatahariAgent::init(int argc, char **argv, const char* proc_name)
// Create a v2 API options map. qpid::types::Variant::Map options;
- options["reconnect"] = bool(true);
- options["reconnect"] = reconnect;
if (username && *username) { options["username"] = username; } -- 1.7.4.4
Matahari mailing list Matahari@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/matahari