On 12/07/11 18:48, Daniel P. Berrange wrote:
On Tue, Jul 12, 2011 at 06:28:23PM +0200, Zane Bitter wrote:
The following series converts libvirt-qpid into a matahari agent using the QMFv2 APIs.
Since the patches are rather large, I have also pushed them to GitHub for easier reviewing: https://github.com/zaneb/libvirt-qpid/commits/review
Any and all comments are welcome.
To my quick glance, this looks pretty reasonable. As a general question, are we maintaining compatibility with previous releases of libvirt-qpid at a schema level here, or are we starting a new v2 schema with the port to QMFv2 ?
Thus far I've attempted to keep them compatible with existing clients (although I haven't tested any). That may or may not be necessary/desirable, especially if we are changing the name anyway. So I'm happy to have that debate.
cheers, Zane.