What do you think about using a process described here:
http://progit.org/2010/08/25/notes.html
( adam stokes ) || ( adam.stokes@gmail.com )
On Tue, Apr 19, 2011 at 8:44 AM, Andrew Beekhof andrew@beekhof.net wrote:
On Tue, Apr 19, 2011 at 2:12 PM, Russell Bryant russell@russellbryant.net wrote:
On Tue, Apr 19, 2011 at 2:09 AM, Andrew Beekhof andrew@beekhof.net wrote:
ack.
btw. whats the normal git workflow for adding Signed-off-by lines? I never quite grok'd how that happened.
It's up to you what rules you want to put around commit messages of course. From what I have seen so far, it seems common to follow how the kernel uses this (and similar commit message lines). Check out section 13 of this doc:
http://www.kernel.org/doc/Documentation/SubmittingPatches
TL;DR version:
Signed-off-by: I helped write the patch
Acked-by: I approve of this going in
Reviewed-by: like Acked-by, but a more significant form of approval that indicates a more in depth review
CC: I gave this person a chance to comment but they didn't
Tested-by: this person tested it
Reported-by: this person reported what i'm fixing
The -s option to git commit automatically adds the signed-off-by line. After you ack them, I go back and git commit --amend the commit messages to add an Acked-by line.
Ok, so adding those is just a manual process. I thought there might be some automagical option for that.
Thanks for clarifying. _______________________________________________ Matahari mailing list Matahari@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/matahari