main - tests: even more aggressive throttling
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=daca6e2c225889a8ee4...
Commit: daca6e2c225889a8ee4bfe4f4724d92481df2558
Parent: bee8027cfa296bd910c75d5000a60d7ef99ecd78
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Mar 22 09:49:42 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 22 22:36:37 2021 +0100
tests: even more aggressive throttling
Try if the test gets slowed down with slower mirroring (1)
or we would need something better to beat the race.
---
test/shell/pvmove-resume-multiseg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/shell/pvmove-resume-multiseg.sh b/test/shell/pvmove-resume-multiseg.sh
index c94706ed1..5a32bc607 100644
--- a/test/shell/pvmove-resume-multiseg.sh
+++ b/test/shell/pvmove-resume-multiseg.sh
@@ -20,7 +20,7 @@ SKIP_WITH_LVMLOCKD=1
. lib/inittest
aux prepare_pvs 5 30
-aux throttle_dm_mirror 50 || :
+aux throttle_dm_mirror || :
vgcreate -s 128k $vg "$dev1" "$dev2" "$dev3"
pvcreate --metadatacopies 0 "$dev4" "$dev5"
3 years, 1 month
main - tests: skip only portion of test
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=bee8027cfa296bd910c...
Commit: bee8027cfa296bd910c75d5000a60d7ef99ecd78
Parent: 8d2ad4419a58536696474dbdfb241204d561dcf6
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sun Mar 21 23:25:16 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 22 22:36:37 2021 +0100
tests: skip only portion of test
Seems this kernel bug is taking more time to get it fixed,
so skipping only failing portion of test and ending with WARNING.
---
.../lvconvert-raid-reshape-stripes-load-reload.sh | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh b/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh
index 3b6150909..1e2ad0fb4 100644
--- a/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh
+++ b/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh
@@ -21,15 +21,6 @@ which md5sum || skip
which mkfs.ext4 || skip
aux have_raid 1 13 2 || skip
-case "$(uname -r)" in
- 5.[891]*) die "Cannot run this test on unfixed kernel." ;;
- 3.10.0-862*) skip "Cannot run this test on unfixed kernel." ;;
- 4.18.0-*.el8*)
- REL="$(uname -r)"
- REL="${REL#4.18.0-}"
- [[ "${REL%%.*}" -lt 283 ]] || die "Cannot run this test on unfixed kernel." ;;
-esac
-
mount_dir="mnt"
cleanup_mounted_and_teardown()
@@ -57,8 +48,8 @@ check lv_first_seg_field $vg/$lv1 segtype "raid5_ls"
check lv_first_seg_field $vg/$lv1 stripesize "64.00k"
check lv_first_seg_field $vg/$lv1 data_stripes 10
check lv_first_seg_field $vg/$lv1 stripes 11
-wipefs -a /dev/$vg/$lv1
-mkfs -t ext4 /dev/$vg/$lv1
+wipefs -a "$DM_DEV_DIR/$vg/$lv1"
+mkfs -t ext4 "$DM_DEV_DIR/$vg/$lv1"
mkdir -p "$mount_dir"
mount "$DM_DEV_DIR/$vg/$lv1" "$mount_dir"
@@ -80,6 +71,10 @@ check lv_first_seg_field $vg/$lv1 data_stripes 15
check lv_first_seg_field $vg/$lv1 stripes 16
# Reload table during reshape to test for data corruption
+case "$(uname -r)" in
+ 5.[891]*|3.10.0-862*|4.18.0-*.el8*)
+ should not echo "Skipping table reload test on on unfixed kernel!!!" ;;
+ *)
for i in {0..5}
do
dmsetup table $vg-$lv1|dmsetup load $vg-$lv1
@@ -88,6 +83,8 @@ do
sleep 0.3
done
+esac
+
aux delay_dev "$dev2" 0
kill -9 %% || true
3 years, 1 month
main - tests: more system defaults for installed tests
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=8d2ad4419a585366964...
Commit: 8d2ad4419a58536696474dbdfb241204d561dcf6
Parent: f1858d209d7b6f0e0db232567c886cfcf374dba1
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 20 23:50:16 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 22 22:36:37 2021 +0100
tests: more system defaults for installed tests
When testing installed binaries on system, use more 'built-in'
predefined settings to usethem with their compiled-in values.
Also it's better to use same locking dir so the system's pvscan
is not unexpectedly interferring with test commands.
---
test/lib/aux.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/test/lib/aux.sh b/test/lib/aux.sh
index 8c727e8c6..ae173b8da 100644
--- a/test/lib/aux.sh
+++ b/test/lib/aux.sh
@@ -1299,8 +1299,6 @@ activation/polling_interval = 1
activation/retry_deactivation = 1
activation/snapshot_autoextend_percent = 50
activation/snapshot_autoextend_threshold = 50
-activation/udev_rules = 1
-activation/udev_sync = 1
activation/verify_udev_operations = $LVM_VERIFY_UDEV
activation/raid_region_size = 512
allocation/wipe_signatures_when_zeroing_new_lvs = 0
@@ -1324,8 +1322,6 @@ global/cache_dump_executable = "$LVM_TEST_CACHE_DUMP_CMD"
global/cache_repair_executable = "$LVM_TEST_CACHE_REPAIR_CMD"
global/detect_internal_vg_cache_corruption = 1
global/fallback_to_local_locking = 0
-global/library_dir = "$TESTDIR/lib"
-global/locking_dir = "$TESTDIR/var/lock/lvm"
global/locking_type=$LVM_TEST_LOCKING
global/notify_dbus = 0
global/si_unit_consistency = 1
@@ -1342,12 +1338,18 @@ log/overwrite = 1
log/syslog = 0
log/verbose = 0
EOF
- # For 'rpm' builds use system installed binaries.
+ # For 'rpm' builds use system installed binaries
+ # and libraries and locking dir and some more built-in
+ # defaults
# For test suite run use binaries from builddir.
test -z "${abs_top_builddir+varset}" || {
cat >> "$config_values" <<-EOF
dmeventd/executable = "$abs_top_builddir/test/lib/dmeventd"
+activation/udev_rules = 1
+activation/udev_sync = 1
global/fsadm_executable = "$abs_top_builddir/test/lib/fsadm"
+global/library_dir = "$TESTDIR/lib"
+global/locking_dir = "$TESTDIR/var/lock/lvm"
EOF
}
}
3 years, 1 month
main - tests: remove incorrect check
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=f1858d209d7b6f0e0db...
Commit: f1858d209d7b6f0e0db232567c886cfcf374dba1
Parent: 09621725d0ea2a27e462f44139a54096ccadeb19
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 20 18:17:09 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 22 22:36:37 2021 +0100
tests: remove incorrect check
We would need to be check same status value - otherwise
we can hit race in validating 2 different states.
---
test/shell/lvcreate-raid-nosync.sh | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/test/shell/lvcreate-raid-nosync.sh b/test/shell/lvcreate-raid-nosync.sh
index 05ab848a1..c7c2d1535 100644
--- a/test/shell/lvcreate-raid-nosync.sh
+++ b/test/shell/lvcreate-raid-nosync.sh
@@ -38,12 +38,9 @@ _sync() {
_check_raid_in_loop() {
local vg=$1
local lv=$2
- local A=$3
- local B=$(echo $A | tr A a)
+ local health=$3
for i in {1..10} ; do
- check raid_leg_status $vg $lv ${A} && return 0
- # Only when there is initial 'a..a' we will wait for a while
- check raid_leg_status $vg $lv ${B} || break
+ check raid_leg_status $vg $lv ${health} && return 0
sleep .05
done
die "Cannot get $A status for $vg/$lv";
3 years, 1 month
main - gcc: declaration of tmpfile shadows a global
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=09621725d0ea2a27e46...
Commit: 09621725d0ea2a27e462f44139a54096ccadeb19
Parent: b6cff47bdeef4906d675dad71277a706db0b9127
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sun Mar 21 23:32:12 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 22 22:35:56 2021 +0100
gcc: declaration of tmpfile shadows a global
Rename tmpfile to tmppath to avoid declaration shadowing of:
/usr/include/stdio.h:174: warning: shadowed declaration is here
---
lib/device/device_id.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/device/device_id.c b/lib/device/device_id.c
index 2de8b0a14..cf5867dab 100644
--- a/lib/device/device_id.c
+++ b/lib/device/device_id.c
@@ -604,7 +604,7 @@ out:
int device_ids_write(struct cmd_context *cmd)
{
char dirpath[PATH_MAX];
- char tmpfile[PATH_MAX];
+ char tmppath[PATH_MAX];
char version_buf[VERSION_LINE_MAX] = {0};
FILE *fp;
int dir_fd;
@@ -674,14 +674,14 @@ int device_ids_write(struct cmd_context *cmd)
goto out;
}
- if (dm_snprintf(tmpfile, sizeof(tmpfile), "%s_new", cmd->devices_file_path) < 0) {
+ if (dm_snprintf(tmppath, sizeof(tmppath), "%s_new", cmd->devices_file_path) < 0) {
ret = 0;
goto out;
}
- unlink(tmpfile); /* in case a previous file was left */
+ unlink(tmppath); /* in case a previous file was left */
- if (!(fp = fopen(tmpfile, "w+"))) {
+ if (!(fp = fopen(tmppath, "w+"))) {
log_warn("Cannot open tmp devices_file to write.");
ret = 0;
goto out;
@@ -689,7 +689,7 @@ int device_ids_write(struct cmd_context *cmd)
if ((dir_fd = open(dirpath, O_RDONLY)) < 0) {
if (fclose(fp))
- log_sys_debug("fclose", tmpfile);
+ log_sys_debug("fclose", tmppath);
ret = 0;
goto out;
}
@@ -744,7 +744,7 @@ int device_ids_write(struct cmd_context *cmd)
if (fclose(fp))
stack;
- if (rename(tmpfile, cmd->devices_file_path) < 0) {
+ if (rename(tmppath, cmd->devices_file_path) < 0) {
log_error("Failed to replace devices file errno %d", errno);
ret = 0;
}
3 years, 1 month
main - lvm: Fix editline compilation
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=b6cff47bdeef4906d67...
Commit: b6cff47bdeef4906d675dad71277a706db0b9127
Parent: d6bc11bf724be4ebfd87dc60a172da2b0e4df8d9
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Mon Mar 22 10:50:42 2021 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Mon Mar 22 11:37:19 2021 +0100
lvm: Fix editline compilation
---
configure | 2 +-
configure.ac | 4 ++--
tools/lvm.c | 1 -
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 4c38cbebb..0be9f136c 100755
--- a/configure
+++ b/configure
@@ -13404,7 +13404,7 @@ $as_echo_n "checking whether to enable readline... " >&6; }
$as_echo "$READLINE" >&6; }
if test "$EDITLINE" = yes; then
- for ac_header in editline/readline.h editline/history.h
+ for ac_header in editline/readline.h
do :
as_ac_Header=`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
ac_fn_c_check_header_mongrel "$LINENO" "$ac_header" "$as_ac_Header" "$ac_includes_default"
diff --git a/configure.ac b/configure.ac
index ee21b879d..b92be0db3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1420,7 +1420,7 @@ if test "$EDITLINE" == yes; then
PKG_CHECK_MODULES([EDITLINE], [libedit], [
AC_DEFINE([EDITLINE_SUPPORT], 1,
[Define to 1 to include the LVM editline shell.])], AC_MSG_ERROR(
-[libedit could not be found which is required for the --enable-readline option.])
+[libedit could not be found which is required for the --enable-editline option.])
)
fi
@@ -1557,7 +1557,7 @@ AC_MSG_CHECKING(whether to enable readline)
AC_MSG_RESULT($READLINE)
if test "$EDITLINE" = yes; then
- AC_CHECK_HEADERS(editline/readline.h editline/history.h,,hard_bailout)
+ AC_CHECK_HEADERS(editline/readline.h,,hard_bailout)
fi
AC_MSG_CHECKING(whether to enable editline)
AC_MSG_RESULT($EDITLINE)
diff --git a/tools/lvm.c b/tools/lvm.c
index 79b1210af..cc67e924a 100644
--- a/tools/lvm.c
+++ b/tools/lvm.c
@@ -33,7 +33,6 @@ int main(int argc, char **argv)
# endif
# elif defined(EDITLINE_SUPPORT)
# include <editline/readline.h>
-# include <editline/history.h>
# endif
static struct cmdline_context *_cmdline;
3 years, 1 month
main - tests: use mirror throttling
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=d6bc11bf724be4ebfd8...
Commit: d6bc11bf724be4ebfd87dc60a172da2b0e4df8d9
Parent: 2dd43a7314ba72b0b899e161261ef5caacbade05
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 20 10:14:09 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Sat Mar 20 10:52:24 2021 +0100
tests: use mirror throttling
With small mirrors its better to throttle speed of mirror in dm-mirror.
---
test/shell/pvmove-resume-1.sh | 5 +++--
test/shell/pvmove-resume-multiseg.sh | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/test/shell/pvmove-resume-1.sh b/test/shell/pvmove-resume-1.sh
index 6b4cbe529..7b9fc0f39 100644
--- a/test/shell/pvmove-resume-1.sh
+++ b/test/shell/pvmove-resume-1.sh
@@ -20,6 +20,7 @@ SKIP_WITH_CLVMD=1
. lib/inittest
+aux throttle_dm_mirror 50 || :
aux prepare_pvs 4 30
vgcreate -s 128k $vg "$dev1"
@@ -34,9 +35,9 @@ test_pvmove_resume() {
lvcreate -an -Zn -l30 -n $lv1 $vg
lvcreate -an -Zn -l30 -n $lv1 $vg1
- aux delay_dev "$dev3" 0 1000 "$(get first_extent_sector "$dev3"):"
+ aux delay_dev "$dev3" 0 200 "$(get first_extent_sector "$dev3"):"
test -e HAVE_DM_DELAY || { lvremove -f $vg $vg1; return 0; }
- aux delay_dev "$dev4" 0 1000 "$(get first_extent_sector "$dev4"):"
+ aux delay_dev "$dev4" 0 200 "$(get first_extent_sector "$dev4"):"
pvmove -i5 "$dev1" &
PVMOVE=$!
diff --git a/test/shell/pvmove-resume-multiseg.sh b/test/shell/pvmove-resume-multiseg.sh
index 3a92dbaf3..c94706ed1 100644
--- a/test/shell/pvmove-resume-multiseg.sh
+++ b/test/shell/pvmove-resume-multiseg.sh
@@ -20,6 +20,7 @@ SKIP_WITH_LVMLOCKD=1
. lib/inittest
aux prepare_pvs 5 30
+aux throttle_dm_mirror 50 || :
vgcreate -s 128k $vg "$dev1" "$dev2" "$dev3"
pvcreate --metadatacopies 0 "$dev4" "$dev5"
@@ -33,9 +34,9 @@ test_pvmove_resume() {
# next LV on same VG and differetnt PV (we want to test 2 pvmoves per VG)
lvcreate -an -Zn -l30 -n $lv2 $vg "$dev3"
- aux delay_dev "$dev4" 0 500 "$(get first_extent_sector "$dev4"):"
+ aux delay_dev "$dev4" 0 200 "$(get first_extent_sector "$dev4"):"
test -e HAVE_DM_DELAY || { lvremove -f $vg; return 0; }
- aux delay_dev "$dev5" 0 500 "$(get first_extent_sector "$dev5"):"
+ aux delay_dev "$dev5" 0 200 "$(get first_extent_sector "$dev5"):"
pvmove -i5 "$dev1" "$dev4" &
PVMOVE=$!
3 years, 1 month
main - tests: slow down device more
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=2dd43a7314ba72b0b89...
Commit: 2dd43a7314ba72b0b899e161261ef5caacbade05
Parent: 94c4af232c6118191ac2c81a4130e6f83823f510
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 20 09:58:50 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Sat Mar 20 10:52:24 2021 +0100
tests: slow down device more
Make the race with too fast merging less likely to occure.
---
test/shell/snapshot-merge-thin.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/shell/snapshot-merge-thin.sh b/test/shell/snapshot-merge-thin.sh
index 447a93167..4e4577ca9 100644
--- a/test/shell/snapshot-merge-thin.sh
+++ b/test/shell/snapshot-merge-thin.sh
@@ -49,7 +49,7 @@ lvcreate -s -n $lv2 -L2 $vg/$lv1 "$dev2"
dd if=/dev/zero of="$DM_DEV_DIR/$vg/$lv2" bs=1M count=1 oflag=direct
lvs -a -o+lv_merging,lv_merge_failed $vg
-aux delay_dev "$dev1" 0 100 "$(get first_extent_sector "$dev1"):"
+aux delay_dev "$dev1" 0 400 "$(get first_extent_sector "$dev1"):"
# Initiate background merge
lvconvert -b --merge $vg/$lv2
3 years, 1 month
main - tests: prohibit 4K brd device with integrity
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=94c4af232c6118191ac...
Commit: 94c4af232c6118191ac2c81a4130e6f83823f510
Parent: 179f59a0ca7d4d5f779f86d990ebd336c9b13f0e
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 20 09:54:30 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Sat Mar 20 10:52:24 2021 +0100
tests: prohibit 4K brd device with integrity
Older kernels hit these errors:
device-mapper: integrity: Bio not aligned on 8 sectors: 0x8ffc, 0x4
---
test/shell/integrity-blocksize-2.sh | 2 ++
test/shell/integrity-dmeventd.sh | 4 +++-
test/shell/integrity-misc.sh | 4 +++-
test/shell/integrity-syncaction.sh | 4 +++-
test/shell/integrity.sh | 4 +++-
5 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/test/shell/integrity-blocksize-2.sh b/test/shell/integrity-blocksize-2.sh
index 3f6eb9242..ae0e72ec6 100644
--- a/test/shell/integrity-blocksize-2.sh
+++ b/test/shell/integrity-blocksize-2.sh
@@ -15,6 +15,8 @@ SKIP_WITH_LVMPOLLD=1
. lib/inittest
aux have_integrity 1 5 0 || skip
+# Avoid 4K ramdisk devices on older kernels
+aux kernel_at_least 5 10 || export LVM_TEST_PREFER_BRD=0
mnt="mnt"
mkdir -p $mnt
diff --git a/test/shell/integrity-dmeventd.sh b/test/shell/integrity-dmeventd.sh
index e82b92142..9049eb0f7 100644
--- a/test/shell/integrity-dmeventd.sh
+++ b/test/shell/integrity-dmeventd.sh
@@ -14,8 +14,10 @@ SKIP_WITH_LVMPOLLD=1
. lib/inittest
-aux have_integrity 1 5 0 || skip
which mkfs.xfs || skip
+aux have_integrity 1 5 0 || skip
+# Avoid 4K ramdisk devices on older kernels
+aux kernel_at_least 5 10 || export LVM_TEST_PREFER_BRD=0
mnt="mnt"
mkdir -p $mnt
diff --git a/test/shell/integrity-misc.sh b/test/shell/integrity-misc.sh
index 4ebf42213..e6c108a0f 100644
--- a/test/shell/integrity-misc.sh
+++ b/test/shell/integrity-misc.sh
@@ -14,8 +14,10 @@ SKIP_WITH_LVMPOLLD=1
. lib/inittest
-aux have_integrity 1 5 0 || skip
which mkfs.xfs || skip
+aux have_integrity 1 5 0 || skip
+# Avoid 4K ramdisk devices on older kernels
+aux kernel_at_least 5 10 || export LVM_TEST_PREFER_BRD=0
mnt="mnt"
mkdir -p $mnt
diff --git a/test/shell/integrity-syncaction.sh b/test/shell/integrity-syncaction.sh
index a1d96fb0e..e404f6b6d 100644
--- a/test/shell/integrity-syncaction.sh
+++ b/test/shell/integrity-syncaction.sh
@@ -14,9 +14,11 @@ SKIP_WITH_LVMPOLLD=1
. lib/inittest
-aux have_integrity 1 5 0 || skip
which mkfs.xfs || skip
which xfs_growfs || skip
+aux have_integrity 1 5 0 || skip
+# Avoid 4K ramdisk devices on older kernels
+aux kernel_at_least 5 10 || export LVM_TEST_PREFER_BRD=0
mnt="mnt"
mkdir -p $mnt
diff --git a/test/shell/integrity.sh b/test/shell/integrity.sh
index ffac50902..80ff919b2 100644
--- a/test/shell/integrity.sh
+++ b/test/shell/integrity.sh
@@ -14,9 +14,11 @@ SKIP_WITH_LVMPOLLD=1
. lib/inittest
-aux have_integrity 1 5 0 || skip
which mkfs.xfs || skip
which xfs_growfs || skip
+aux have_integrity 1 5 0 || skip
+# Avoid 4K ramdisk devices on older kernels
+aux kernel_at_least 5 10 || export LVM_TEST_PREFER_BRD=0
mnt="mnt"
mkdir -p $mnt
3 years, 1 month
main - tests: add FIXME to raid test
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=179f59a0ca7d4d5f779...
Commit: 179f59a0ca7d4d5f779f86d990ebd336c9b13f0e
Parent: 05920e3818b22c24dde59b3e562fe156466f83f2
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 20 10:39:02 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Sat Mar 20 10:52:24 2021 +0100
tests: add FIXME to raid test
We have here some kind of catch-22 - since older kernels do
use 'resync' while new 'recover' for initial raid synchronization.
So now - how do we recognize in which state of raid we are.
ATM seems to be simplest to simply keep disabled droping of primary raid
leg unless we are in sync.
FIXME: we should add a target version check and enable removal
---
test/shell/lvconvert-raid.sh | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/test/shell/lvconvert-raid.sh b/test/shell/lvconvert-raid.sh
index 6aaaf3669..aa50fbb62 100644
--- a/test/shell/lvconvert-raid.sh
+++ b/test/shell/lvconvert-raid.sh
@@ -250,7 +250,13 @@ echo "Skippen test that kills this kernel"
;;
*)
lvconvert --yes -m 1 $vg/$lv1 "$dev3"
-lvconvert --yes -m 0 $vg/$lv1 "$dev1"
+
+# FIXME: it is unclear what should happen - older kernel
+# do use 'resync' for initial array building so then
+# we are not able to recognize difference
+# Should we check version target as react differentely ??
+# Otherwise we have problem with the above test case.
+should lvconvert --yes -m 0 $vg/$lv1 "$dev1"
aux enable_dev "$dev2"
;;
esac
3 years, 1 month