stable-2.02 - WHATS_NEW: update
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=1f220e8d430f3ab94e3...
Commit: 1f220e8d430f3ab94e3e85656a3f692c6dc4051f
Parent: 0ab7fce2b3e11c89ac5091c919750a7f7f23ad32
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Tue Feb 23 15:02:47 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Tue Feb 23 15:03:03 2021 +0100
WHATS_NEW: update
---
WHATS_NEW | 1 +
1 file changed, 1 insertion(+)
diff --git a/WHATS_NEW b/WHATS_NEW
index 7a9491a8b..14b6ec2b9 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.02.188 -
==================================
+ Fix problem with unbound variable usage within fsadm.
Avoid removing LVs on error path of lvconvert during creation volumes.
Fix crashing lvdisplay when thin volume was waiting for merge.
Support option --errorwhenfull when converting volume to thin-pool.
3 years, 1 month
stable-2.02 - tests: remove local setting of LVM_BINARY
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=0ab7fce2b3e11c89ac5...
Commit: 0ab7fce2b3e11c89ac5091c919750a7f7f23ad32
Parent: c94657cc2e678b0937fa770f4280507d1118ef4c
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Tue Feb 23 14:42:47 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Tue Feb 23 15:01:53 2021 +0100
tests: remove local setting of LVM_BINARY
To better test actually fsadm in test suite - avoid setting
LVM_BINARY locally - since test setup already modifies
PATH to find test's lvm binary as the 1st. in path.
---
test/shell/fsadm-crypt.sh | 3 ---
test/shell/fsadm-renamed.sh | 3 ---
test/shell/fsadm.sh | 3 ---
test/shell/lvresize-full.sh | 2 --
4 files changed, 11 deletions(-)
diff --git a/test/shell/fsadm-crypt.sh b/test/shell/fsadm-crypt.sh
index 4b8fc4e2d..2004db957 100644
--- a/test/shell/fsadm-crypt.sh
+++ b/test/shell/fsadm-crypt.sh
@@ -76,9 +76,6 @@ dev_vg_lv="$DM_DEV_DIR/$vg_lv"
dev_vg_lv2="$DM_DEV_DIR/$vg_lv2"
dev_vg_lv3="$DM_DEV_DIR/$vg_lv3"
mount_dir="mnt"
-# for recursive call
-LVM_BINARY=$(which lvm)
-export LVM_BINARY
test ! -d "$mount_dir" && mkdir "$mount_dir"
diff --git a/test/shell/fsadm-renamed.sh b/test/shell/fsadm-renamed.sh
index 321893925..50c6d3ee5 100644
--- a/test/shell/fsadm-renamed.sh
+++ b/test/shell/fsadm-renamed.sh
@@ -27,9 +27,6 @@ dev_vg_lv_ren="$DM_DEV_DIR/$vg_lv_ren"
mount_dir="mnt"
mount_space_dir="mnt space dir"
mount_dolar_dir="mnt \$SPACE dir"
-# for recursive call
-LVM_BINARY=$(which lvm)
-export LVM_BINARY
test ! -d "$mount_dir" && mkdir "$mount_dir"
test ! -d "$mount_space_dir" && mkdir "$mount_space_dir"
diff --git a/test/shell/fsadm.sh b/test/shell/fsadm.sh
index 67f9660e6..987b1a1a9 100644
--- a/test/shell/fsadm.sh
+++ b/test/shell/fsadm.sh
@@ -45,9 +45,6 @@ dev_vg_lv="$DM_DEV_DIR/$vg_lv"
dev_vg_lv2="$DM_DEV_DIR/$vg_lv2"
mount_dir="mnt"
mount_space_dir="mnt space dir"
-# for recursive call
-LVM_BINARY=$(which lvm)
-export LVM_BINARY
test ! -d "$mount_dir" && mkdir "$mount_dir"
test ! -d "$mount_space_dir" && mkdir "$mount_space_dir"
diff --git a/test/shell/lvresize-full.sh b/test/shell/lvresize-full.sh
index 3cab52275..dcf93a7b2 100644
--- a/test/shell/lvresize-full.sh
+++ b/test/shell/lvresize-full.sh
@@ -21,8 +21,6 @@ SKIP_WITH_LVMPOLLD=1
FSCK=${FSCK-fsck}
MKFS=${MKFS-mkfs.ext3}
RESIZEFS=${RESIZEFS-resize2fs}
-LVM_BINARY=$(which lvm)
-export LVM_BINARY
which $FSCK || skip
which $MKFS || skip
3 years, 1 month
stable-2.02 - fsadm: avoid access to unbound variable
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=c94657cc2e678b0937f...
Commit: c94657cc2e678b0937fa770f4280507d1118ef4c
Parent: 87e0b1a36faa54c6fc27837cac3be01a1553eaf9
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Tue Feb 23 14:14:16 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Tue Feb 23 15:01:53 2021 +0100
fsadm: avoid access to unbound variable
---
scripts/fsadm.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/fsadm.sh b/scripts/fsadm.sh
index 2cb1fc75b..4f59cee13 100755
--- a/scripts/fsadm.sh
+++ b/scripts/fsadm.sh
@@ -163,7 +163,7 @@ cleanup() {
_FSADM_EXTOFF=$EXTOFF
export _FSADM_YES _FSADM_EXTOFF
unset FSADM_RUNNING
- test -n "$LVM_BINARY" && PATH=$_SAVEPATH
+ test -n "${LVM_BINARY-}" && PATH=$_SAVEPATH
dry exec "$LVM" lvresize $VERB $FORCE -r -L"${NEWSIZE_ORIG}b" "$VOLUME_ORIG"
fi
3 years, 1 month
main - command defs: add missing commas
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=9e836c77a0663649468...
Commit: 9e836c77a0663649468af613436c210e3ba324b2
Parent: 12667e9897ad54f5723463b4c864c8259ba0be2a
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Mon Feb 22 10:44:01 2021 -0600
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Mon Feb 22 10:44:01 2021 -0600
command defs: add missing commas
even though the parser seems to work fine without them
---
tools/command-lines.in | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tools/command-lines.in b/tools/command-lines.in
index 2aadd5f40..d6fd0e304 100644
--- a/tools/command-lines.in
+++ b/tools/command-lines.in
@@ -318,15 +318,14 @@ OO_LVCONVERT_POOL: --poolmetadata LV, --poolmetadatasize SizeMB,
--poolmetadataspare Bool, --readahead Readahead, --chunksize SizeKB,
--zero Bool, --metadataprofile String
-OO_LVCONVERT_THIN: --discards Discards --errorwhenfull Bool
+OO_LVCONVERT_THIN: --discards Discards, --errorwhenfull Bool
OO_LVCONVERT_CACHE: --cachemetadataformat CacheMetadataFormat,
--cachemode CacheMode, --cachepolicy String,
--cachesettings String, --zero Bool
-OO_LVCONVERT_VDO: --metadataprofile String --readahead Readahead,
---compression Bool, --deduplication Bool
---zero Bool
+OO_LVCONVERT_VDO: --metadataprofile String, --readahead Readahead,
+--compression Bool, --deduplication Bool, --zero Bool
OO_LVCONVERT: --alloc Alloc, --background, --force, --noudevsync
@@ -615,8 +614,7 @@ RULE: all and lv_is_visible
RULE: all not lv_is_locked lv_is_origin lv_is_merging_origin lv_is_external_origin lv_is_virtual lv_is_raid_with_integrity
lvconvert --vdopool LV_linear_striped_raid_cache
-OO: --type vdo-pool, OO_LVCONVERT_VDO, OO_LVCONVERT
---name LV_new, --virtualsize SizeMB,
+OO: --type vdo-pool, OO_LVCONVERT_VDO, OO_LVCONVERT, --name LV_new, --virtualsize SizeMB,
ID: lvconvert_to_vdopool_param
DESC: Convert LV to type vdopool.
RULE: all and lv_is_visible
3 years, 1 month
main - fix check for md raid imsm signature on 4k devices
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=12667e9897ad54f5723...
Commit: 12667e9897ad54f5723463b4c864c8259ba0be2a
Parent: 3cba07125457b82045f41bfafc67733c0dad89a2
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Thu Feb 18 11:42:32 2021 -0600
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Thu Feb 18 11:42:32 2021 -0600
fix check for md raid imsm signature on 4k devices
On devices with 4k logical block size, the imsm signature
is located 8k from the end of the device, not 1k as is
the case for devices with 512 LBS.
---
lib/device/dev-md.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/lib/device/dev-md.c b/lib/device/dev-md.c
index 36494b12b..3049b81b7 100644
--- a/lib/device/dev-md.c
+++ b/lib/device/dev-md.c
@@ -56,6 +56,16 @@ static int _dev_has_imsm_magic(struct device *dev, uint64_t devsize_sectors)
{
char imsm_signature[IMSM_SIG_LEN];
uint64_t off = (devsize_sectors * 512) - 1024;
+ unsigned int physical_block_size = 0;
+ unsigned int logical_block_size = 0;
+
+ if (!dev_get_direct_block_sizes(dev, &physical_block_size, &logical_block_size))
+ return_0;
+
+ if (logical_block_size == 4096)
+ off = (devsize_sectors * 512) - 8192;
+ else
+ off = (devsize_sectors * 512) - 1024;
if (!dev_read_bytes(dev, off, IMSM_SIG_LEN, imsm_signature))
return_0;
3 years, 1 month
main - tests: Skip test killing kernel
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3cba07125457b82045f...
Commit: 3cba07125457b82045f41bfafc67733c0dad89a2
Parent: 26a09c84c9498b187eec776150cd1eeafeda6ce7
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Wed Feb 17 13:26:06 2021 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Wed Feb 17 13:28:56 2021 +0100
tests: Skip test killing kernel
Bug 1916891
---
test/shell/lvconvert-raid-reshape-stripes-load-reload.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh b/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh
index 3920da1a5..6fe34250a 100644
--- a/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh
+++ b/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh
@@ -22,7 +22,7 @@ which mkfs.ext4 || skip
aux have_raid 1 13 2 || skip
case "$(uname -r)" in
- 5.[891]*|3.10.0-862*) die "Cannot run this test on unfixed kernel." ;;
+ 5.[891]*|3.10.0-862*|4.18.0-283.el8) die "Cannot run this test on unfixed kernel." ;;
esac
mount_dir="mnt"
3 years, 1 month
stable-2.02 - WHATS_NEW: updates
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=87e0b1a36faa54c6fc2...
Commit: 87e0b1a36faa54c6fc27837cac3be01a1553eaf9
Parent: 99d8b91422243f227c9324bdee2cd7d3d879ddbc
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Wed Feb 17 12:34:25 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Wed Feb 17 12:59:36 2021 +0100
WHATS_NEW: updates
---
WHATS_NEW | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/WHATS_NEW b/WHATS_NEW
index dafa4169a..7a9491a8b 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,9 @@
Version 2.02.188 -
==================================
+ Avoid removing LVs on error path of lvconvert during creation volumes.
+ Fix crashing lvdisplay when thin volume was waiting for merge.
+ Support option --errorwhenfull when converting volume to thin-pool.
+ Improve thin-performance profile support conversion to thin-pool.
Support resize of cached volumes.
Allocation prints better error when metadata cannot fit on a single PV.
Pvmove can better resolve full thin-pool tree move.
3 years, 1 month
stable-2.02 - make: generate
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=99d8b91422243f227c9...
Commit: 99d8b91422243f227c9324bdee2cd7d3d879ddbc
Parent: 37a97c8995a4f5ffb65ce6f735816835f9533a29
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Wed Feb 17 11:57:52 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Wed Feb 17 12:59:36 2021 +0100
make: generate
---
man/lvconvert.8_pregen | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/man/lvconvert.8_pregen b/man/lvconvert.8_pregen
index 94ad90370..d11ff04b9 100644
--- a/man/lvconvert.8_pregen
+++ b/man/lvconvert.8_pregen
@@ -66,6 +66,10 @@ lvconvert - Change logical volume layout
\fB--driverloaded\fP \fBy\fP|\fBn\fP
.ad b
.br
+.ad l
+ \fB--errorwhenfull\fP \fBy\fP|\fBn\fP
+.ad b
+.br
.ad l
\fB-f\fP|\fB--force\fP
.ad b
@@ -675,6 +679,10 @@ Convert LV to type thin-pool.
.ad b
.br
.ad l
+[ \fB--errorwhenfull\fP \fBy\fP|\fBn\fP ]
+.ad b
+.br
+.ad l
[ \fB--poolmetadata\fP \fILV\fP ]
.ad b
.br
@@ -1093,6 +1101,19 @@ For testing and debugging.
.ad b
.HP
.ad l
+\fB--errorwhenfull\fP \fBy\fP|\fBn\fP
+.br
+Specifies thin pool behavior when data space is exhausted.
+When yes, device-mapper will immediately return an error
+when a thin pool is full and an I/O request requires space.
+When no, device-mapper will queue these I/O requests for a
+period of time to allow the thin pool to be extended.
+Errors are returned if no space is available after the timeout.
+(Also see dm-thin-pool kernel module option no_space_timeout.)
+See \fBlvmthin\fP(7) for more information.
+.ad b
+.HP
+.ad l
\fB-f\fP|\fB--force\fP ...
.br
Override various checks, confirmations and protections.
3 years, 1 month
stable-2.02 - makefiles: ignore missing files
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=37a97c8995a4f5ffb65...
Commit: 37a97c8995a4f5ffb65ce6f735816835f9533a29
Parent: dee104668ea5b39518a3a220d360d4624c3f3575
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Fri Nov 30 12:54:34 2018 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Wed Feb 17 12:59:36 2021 +0100
makefiles: ignore missing files
---
Makefile.in | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Makefile.in b/Makefile.in
index 3c8f8c8cf..aa1405d1b 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -205,13 +205,13 @@ $(LCOV_TRACES):
ifneq ("$(GENHTML)", "")
lcov: $(LCOV_TRACES)
- $(RM) -r $(LCOV_REPORTS_DIR)
+ $(RM) -rf $(LCOV_REPORTS_DIR)
$(MKDIR_P) $(LCOV_REPORTS_DIR)
- for i in $(LCOV_TRACES); do \
- test -s $$i -a $$(wc -w <$$i) -ge 100 && lc="$$lc $$i"; \
- done; \
- test -z "$$lc" || $(GENHTML) -p @abs_top_builddir@ \
- -o $(LCOV_REPORTS_DIR) $$lc
+ $(LCOV) --capture --directory $(top_builddir) --ignore-errors source \
+ --output-file $(LCOV_REPORTS_DIR)/out.info
+ -test ! -s $(LCOV_REPORTS_DIR)/out.info || \
+ $(GENHTML) -o $(LCOV_REPORTS_DIR) --ignore-errors source \
+ $(LCOV_REPORTS_DIR)/out.info
endif
endif
3 years, 1 month
stable-2.02 - snapshot: create origin of virtual snap read only
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=dee104668ea5b39518a...
Commit: dee104668ea5b39518a3a220d360d4624c3f3575
Parent: 02978e1f0135b75789669ee4042855b08f57f8b4
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Tue Feb 9 22:31:31 2021 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Wed Feb 17 12:14:54 2021 +0100
snapshot: create origin of virtual snap read only
When creating old fashioned way thick virtual snapshot,
use read-only 'zero' _vorigin device.
---
lib/metadata/lv_manip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index 8dd3e7140..11fab6d7b 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -8273,7 +8273,7 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg,
/* Create zero origin volume for spare snapshot */
if (lp->virtual_extents &&
!(origin_lv = _create_virtual_origin(cmd, vg, lv->name,
- lp->permission,
+ (lp->permission & ~LVM_WRITE),
lp->virtual_extents)))
goto revert_new_lv;
3 years, 1 month