master - man pvchange: mention one option is required
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=ab1de07c9747074a5d3...
Commit: ab1de07c9747074a5d3fa0a3f49a54310854a5a0
Parent: 27736676275fefa3367db2939ddfa0c8cce48c04
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Wed May 3 15:10:10 2017 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Wed May 3 15:10:10 2017 -0500
man pvchange: mention one option is required
---
man/pvchange.8_des | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/man/pvchange.8_des b/man/pvchange.8_des
index 802850f..e914e13 100644
--- a/man/pvchange.8_des
+++ b/man/pvchange.8_des
@@ -1 +1,4 @@
pvchange changes PV attributes in the VG.
+
+For options listed in parentheses, any one is required, after which the
+others are optional.
6 years, 11 months
master - man pvchange: add description for --all
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=27736676275fefa3367...
Commit: 27736676275fefa3367db2939ddfa0c8cce48c04
Parent: f7edadf87087ab4357837f09bc9356dff24306f0
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Wed May 3 15:03:14 2017 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Wed May 3 15:03:14 2017 -0500
man pvchange: add description for --all
---
tools/args.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tools/args.h b/tools/args.h
index 87b33e7..23a56cd 100644
--- a/tools/args.h
+++ b/tools/args.h
@@ -848,6 +848,8 @@ arg(activate_ARG, 'a', "activate", activation_VAL, 0, 0,
arg(all_ARG, 'a', "all", 0, 0, 0,
"#vgreduce\n"
"Removes all empty PVs if none are named on the command line.\n"
+ "#pvchange\n"
+ "Change all visible PVs.\n"
"#lvscan\n"
"#lvdisplay\n"
"#lvs\n"
6 years, 11 months
master - commands: check for memory failures
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=f7edadf87087ab43578...
Commit: f7edadf87087ab4357837f09bc9356dff24306f0
Parent: cb573d1ec987f74cb28ccc5089be4214ed7de317
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Wed May 3 14:46:07 2017 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Wed May 3 14:46:43 2017 -0500
commands: check for memory failures
just return for now
---
tools/command.c | 27 ++++++++++++++++++++++++++-
1 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/tools/command.c b/tools/command.c
index 0f69bbb..a08d068 100644
--- a/tools/command.c
+++ b/tools/command.c
@@ -40,6 +40,8 @@
*/
#ifdef MAN_PAGE_GENERATOR
+#define stack
+
struct cmd_context {
void *libmem;
};
@@ -699,9 +701,16 @@ static void set_opt_def(struct cmd_context *cmdtool, struct command *cmd, char *
if (val_enum == constnum_VAL)
def->num = (uint64_t)atoi(name);
- if (val_enum == conststr_VAL)
+ if (val_enum == conststr_VAL) {
def->str = dm_pool_strdup(cmdtool->libmem, name);
+ if (!def->str) {
+ /* FIXME */
+ stack;
+ return;
+ }
+ }
+
if (val_enum == lv_VAL) {
if (strchr(name, '_'))
def->lvt_bits = lv_to_bits(cmd, name);
@@ -1416,6 +1425,12 @@ int define_commands(struct cmd_context *cmdtool, const char *run_name)
cmd_count++;
cmd->name = dm_pool_strdup(cmdtool->libmem, name);
+ if (!cmd->name) {
+ /* FIXME */
+ stack;
+ return 0;
+ }
+
if (run_name && strcmp(run_name, name)) {
skip = 1;
prev_was_oo_def = 0;
@@ -1447,6 +1462,10 @@ int define_commands(struct cmd_context *cmdtool, const char *run_name)
memset(newdesc, 0, newlen);
snprintf(newdesc, newlen, "%s %s", cmd->desc, desc);
cmd->desc = newdesc;
+ } else {
+ /* FIXME */
+ stack;
+ return 0;
}
} else
cmd->desc = desc;
@@ -1465,6 +1484,12 @@ int define_commands(struct cmd_context *cmdtool, const char *run_name)
if (is_id_line(line_argv[0]) && cmd) {
cmd->command_id = dm_pool_strdup(cmdtool->libmem, line_argv[1]);
+
+ if (!cmd->command_id) {
+ /* FIXME */
+ stack;
+ return 0;
+ }
continue;
}
6 years, 11 months
master - man lvmlockd: minor wording updates
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=cb573d1ec987f74cb28...
Commit: cb573d1ec987f74cb28ccc5089be4214ed7de317
Parent: a946327bb7bc746e7b2ff3aa6d179d1e12925a4a
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Wed May 3 14:45:33 2017 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Wed May 3 14:45:33 2017 -0500
man lvmlockd: minor wording updates
---
man/lvmlockd.8_main | 97 +++++++++++++++++++++++++++------------------------
1 files changed, 51 insertions(+), 46 deletions(-)
diff --git a/man/lvmlockd.8_main b/man/lvmlockd.8_main
index 1a1c2fc..552eb94 100644
--- a/man/lvmlockd.8_main
+++ b/man/lvmlockd.8_main
@@ -117,17 +117,22 @@ Assign each host a unique host_id in the range 1-2000 by setting
.SS 3. start lvmlockd
-Use a service/init file if available, or just run "lvmlockd".
+Use a unit/init file, or run the lvmlockd daemon directly:
+.br
+systemctl start lvm2-lvmlockd
.SS 4. start lock manager
.I sanlock
.br
+Use unit/init files, or start wdmd and sanlock daemons directly:
+.br
systemctl start wdmd sanlock
.I dlm
.br
-Follow external clustering documentation when applicable, otherwise:
+Follow external clustering documentation when applicable, or use
+unit/init files:
.br
systemctl start corosync dlm
@@ -146,8 +151,8 @@ vgchange --lock-start
lvmlockd requires shared VGs to be started before they are used. This is
a lock manager operation to start (join) the VG lockspace, and it may take
some time. Until the start completes, locks for the VG are not available.
-LVM commands are allowed to read the VG while start is in progress. (An
-init/unit file can also be used to start VGs.)
+LVM commands are allowed to read the VG while start is in progress. (A
+unit/init file can also be used to start VGs.)
.SS 7. create and activate LVs
@@ -247,9 +252,9 @@ clvmd for clustering. See below for converting a clvm VG to a lockd VG.
.SS lockd VGs from hosts not using lvmlockd
Only hosts that use lockd VGs should be configured to run lvmlockd.
-However, shared devices used by lockd VGs may be visible from hosts not
-using lvmlockd. From a host not using lvmlockd, visible lockd VGs are
-ignored in the same way as foreign VGs (see
+However, shared devices in lockd VGs may be visible from hosts not
+using lvmlockd. From a host not using lvmlockd, lockd VGs are ignored
+in the same way as foreign VGs (see
.BR lvmsystemid (7).)
The --shared option for reporting and display commands causes lockd VGs
@@ -267,9 +272,9 @@ for all vgcreate options.
.B vgcreate <vgname> <devices>
.IP \[bu] 2
-Creates a local VG with the local system ID when neither lvmlockd nor clvm are configured.
+Creates a local VG with the local host's system ID when neither lvmlockd nor clvm are configured.
.IP \[bu] 2
-Creates a local VG with the local system ID when lvmlockd is configured.
+Creates a local VG with the local host's system ID when lvmlockd is configured.
.IP \[bu] 2
Creates a clvm VG when clvm is configured.
@@ -300,10 +305,11 @@ LVM commands request locks from clvmd to use the VG.
.SS creating the first sanlock VG
-Creating the first sanlock VG is not protected by locking and requires
-special attention. This is because sanlock locks exist within the VG, so
-they are not available until the VG exists. The first sanlock VG will
-contain the "global lock".
+Creating the first sanlock VG is not protected by locking, so it requires
+special attention. This is because sanlock locks exist on storage within
+the VG, so they are not available until the VG exists. The first sanlock
+VG created will automatically contain the "global lock". Be aware of the
+following special considerations:
.IP \[bu] 2
The first vgcreate command needs to be given the path to a device that has
@@ -313,6 +319,11 @@ global lock, which will not be available until after the first sanlock VG
is created.
.IP \[bu] 2
+Because the first sanlock VG will contain the global lock, this VG needs
+to be accessible to all hosts that will use sanlock shared VGs. All hosts
+will need to use the global lock from the first sanlock VG.
+
+.IP \[bu] 2
While running vgcreate for the first sanlock VG, ensure that the device
being used is not used by another LVM command. Allocation of shared
devices is usually protected by the global lock, but this cannot be done
@@ -323,11 +334,6 @@ While running vgcreate for the first sanlock VG, ensure that the VG name
being used is not used by another LVM command. Uniqueness of VG names is
usually ensured by the global lock.
-.IP \[bu] 2
-Because the first sanlock VG will contain the global lock, this VG needs
-to be accessible to all hosts that will use sanlock shared VGs. All hosts
-will need to use the global lock from the first sanlock VG.
-
See below for more information about managing the sanlock global lock.
@@ -383,7 +389,7 @@ lvmlockd is running
the lock manager is running
.br
\[bu]
-the VG is visible to the system
+the VG's devices are visible on the system
.br
A lockd VG can be stopped if all LVs are deactivated.
@@ -425,22 +431,23 @@ activation {
.SS automatic starting and automatic activation
-Scripts or programs on a host that automatically start VGs will use the
-"auto" option to indicate that the command is being run automatically by
-the system:
+When system-level scripts/programs automatically start VGs, they should
+use the "auto" option. This option indicates that the command is being
+run automatically by the system:
vgchange --lock-start --lock-opt auto [<vgname> ...]
-Without any additional configuration, including the "auto" option has no
-effect; all VGs are started unless restricted by lock_start_list.
+The "auto" option causes the command to follow the lvm.conf
+activation/auto_lock_start_list. If auto_lock_start_list is undefined,
+all VGs are started, just as if the auto option was not used.
-However, when the lvm.conf activation/auto_lock_start_list is defined, the
-auto start command performs an additional filtering phase to all VGs being
-started, testing each VG name against the auto_lock_start_list. The
-auto_lock_start_list defines lockd VGs that will be started by the auto
-start command. Visible lockd VGs not included in the list are ignored by
-the auto start command. If the list is undefined, all VG names pass this
-filter. (The lock_start_list is also still used to filter all VGs.)
+When auto_lock_start_list is defined, it lists the lockd VGs that should
+be started by the auto command. VG names that do not match an item in the
+list will be ignored by the auto start command.
+
+(The lock_start_list is also still used to filter VG names from all start
+commands, i.e. with or without the auto option. When the lock_start_list
+is defined, only VGs matching a list item can be started with vgchange.)
The auto_lock_start_list allows a user to select certain lockd VGs that
should be automatically started by the system (or indirectly, those that
@@ -470,14 +477,12 @@ The set of orphan PVs and unused devices.
The properties of orphan PVs, e.g. PV size.
.br
-The global lock is used in shared mode by commands that read this
-information, or in exclusive mode by commands that change it.
-
-The command 'vgs' acquires the global lock in shared mode because it
-reports the list of all VG names.
-
-The vgcreate command acquires the global lock in exclusive mode because it
-creates a new VG name, and it takes a PV from the list of unused PVs.
+The global lock is acquired in shared mode by commands that read this
+information, or in exclusive mode by commands that change it. For
+example, the command 'vgs' acquires the global lock in shared mode because
+it reports the list of all VG names, and the vgcreate command acquires the
+global lock in exclusive mode because it creates a new VG name, and it
+takes a PV from the list of unused PVs.
When an LVM command is given a tag argument, or uses select, it must read
all VGs to match the tag or selection, which causes the global lock to be
@@ -485,10 +490,10 @@ acquired.
.I VG lock
-A VG lock is associated with each VG. The VG lock is acquired in shared
-mode to read the VG and in exclusive mode to change the VG (modify the VG
-metadata or activate LVs). This lock serializes access to a VG with all
-other LVM commands accessing the VG from all hosts.
+A VG lock is associated with each lockd VG. The VG lock is acquired in
+shared mode to read the VG and in exclusive mode to change the VG (modify
+the VG metadata or activating LVs). This lock serializes access to a VG
+with all other LVM commands accessing the VG from all hosts.
The command 'vgs' will not only acquire the GL lock to read the list of
all VG names, but will acquire the VG lock for each VG prior to reading
@@ -502,7 +507,7 @@ argument.
An LV lock is acquired before the LV is activated, and is released after
the LV is deactivated. If the LV lock cannot be acquired, the LV is not
-activated. LV locks are persistent and remain in place after the
+activated. LV locks are persistent and remain in place when the
activation command is done. GL and VG locks are transient, and are held
only while an LVM command is running.
@@ -822,8 +827,8 @@ While lvmlockd and clvmd are entirely different systems, LVM command usage
remains similar. Differences are more notable when using lvmlockd's
sanlock option.
-Visible usage differences between lockd VGs with lvmlockd and clvm VGs
-with clvmd:
+Visible usage differences between lockd VGs (using lvmlockd) and clvm VGs
+(using clvmd):
.IP \[bu] 2
lvm.conf must be configured to use either lvmlockd (use_lvmlockd=1) or
6 years, 11 months
v2_02_171 annotated tag has been created
by Alasdair Kergon
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=94b2eeae57643f32c18...
Commit: 94b2eeae57643f32c180330b910046a56177c4e6
Parent: 0000000000000000000000000000000000000000
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: 2017-05-03 10:25 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: 2017-05-03 10:25 +0000
annotated tag: v2_02_171 has been created
at 94b2eeae57643f32c180330b910046a56177c4e6 (tag)
tagging fb4bf1f4eae9ce49f9e0d606240867320dcb8dac (commit)
replaces v2_02_170
Version 2.02.171
Another development checkpoint release. We have stopped adding
features as we work towards the next stable release, but please still
only use this release for testing purposes while we continue to
find and fix bugs.
96 files changed, 1120 insertions(+), 604 deletions(-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
iEYEABECAAYFAlkJsDsACgkQIoGRwVZ+LBd0HQCffqh3CxbNW29k9Y/5iTFCPIqR
pvgAoJBZj7QxWIfILJC69UhHhw0gveRZ
=p9KX
-----END PGP SIGNATURE-----
Alasdair G Kergon (12):
post-release
conf: Add missing prefix to installation directory.
conf: Remove exec_prefix from confdir.
configure: Fix notify-dbus and dmfilemapd options.
test: Skip some reshape tests that hang on single core machines
pvresize: Prompt when non-default size supplied.
test: Add -y to pvresize --setphysicalvolumesize
pvresize: Missing a message on error path.
WHATS_NEW: pvcreate --setphysicalvolumesize
command: avoid compiler warning
man: generate
pre-release
David Teigland (14):
tests: use raid_region_size 512
configure: rename lockd to lvmlockd
spec: rename lockd to lvmlockd
WHATS_NEW: configure option enable-lvmlockd
man: quote the word no
commands: improve error messages for rules
pvcreate: add prompt when setting dev size
commands: improve syntax suggestion when no command is found
WHATS_NEW: pvcreate prompt
fix running commands from a script file
commands: fix memory debug for cmd defs
man lvmsystemid: general improvements
man lvm: define LVM and its terms
man: references to lvm entities
Heinz Mauelshagen (21):
lvcreate: raise default raid regionsize to 2MiB
WHATS_NEW: raise region_size default
lvconvert: typo in message
mirror/raid: display adjusted region size with units
raid: avoid superfluous reload on takeover
raid: define return value on error paths
raid: remove double minimum area check on takeover
test: Fix skip some reshape tests that hang on single core machines
test: Adjust previous commit
test: also prevent lvconvert-raid-reshape.sh on single core
test: add upconvert allocation failure tests
test: consider changed default
test: add raid4 to upconvert allocation failure tests
raid: avoid superfluous variable
raid: handle insufficent PVs on takeover to/from raid4
lvconvert: preserve region size on raid1 image count changes
lvconvert: fix inactive mirror up converting regression
lvconvert: FIXME
Revert "lvconvert: preserve region size on raid1 image count changes"
lvconvert: preserve region size on raid1 image count changes (v2)
test: add -y to raid1 up conversions
Jonathan Brassow (1):
typo: s/extends/extents/ in lvmthin man page
Marian Csontos (3):
test: Update pattern to match code
dbus: log_debug needs qualifier
dbus: Add --yes when --setphysicalvolumesize is used
Tony Asleson (4):
lvmdbusd: Make sure we don't hang on lvcreate
lvmdbustest.py: Handle nested setUp & tearDown
lvmdbustest.py: Add nested testing
lvmdbusd: Improve error msg to include PV
Zdenek Kabelac (1):
test: correcting binary usage
6 years, 12 months
master - post-release
by Alasdair Kergon
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=a946327bb7bc746e7b2...
Commit: a946327bb7bc746e7b2ff3aa6d179d1e12925a4a
Parent: fb4bf1f4eae9ce49f9e0d606240867320dcb8dac
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Wed May 3 11:26:58 2017 +0100
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Wed May 3 11:26:58 2017 +0100
post-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 3 +++
WHATS_NEW_DM | 3 +++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/VERSION b/VERSION
index 4f7cf0e..1e823ec 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.02.171(2)-git (2017-05-03)
+2.02.172(2)-git (2017-05-03)
diff --git a/VERSION_DM b/VERSION_DM
index bc37b73..36b0104 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.140-git (2017-05-03)
+1.02.141-git (2017-05-03)
diff --git a/WHATS_NEW b/WHATS_NEW
index 33a27e8..003a9c7 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,3 +1,6 @@
+Version 2.02.172 -
+===============================
+
Version 2.02.171 - 3rd May 2017
===============================
Fix memory warnings by using mempools for command definition processing.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 20d6220..a8b721c 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,3 +1,6 @@
+Version 1.02.141 -
+===============================
+
Version 1.02.140 - 3rd May 2017
===============================
Add missing configure --enable-dmfilemapd status message and fix --disable.
6 years, 12 months
master - pre-release
by Alasdair Kergon
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=fb4bf1f4eae9ce49f9e...
Commit: fb4bf1f4eae9ce49f9e0d606240867320dcb8dac
Parent: 6bdbb283d54c7f91abd75c0c463a8475ac5435ff
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Wed May 3 11:23:31 2017 +0100
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Wed May 3 11:23:31 2017 +0100
pre-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 5 +++--
WHATS_NEW_DM | 4 ++--
4 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/VERSION b/VERSION
index a13212a..4f7cf0e 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.02.171(2)-git (2017-04-13)
+2.02.171(2)-git (2017-05-03)
diff --git a/VERSION_DM b/VERSION_DM
index de580ee..bc37b73 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.140-git (2017-04-13)
+1.02.140-git (2017-05-03)
diff --git a/WHATS_NEW b/WHATS_NEW
index 846e998..33a27e8 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
-Version 2.02.171 -
-==================================
+Version 2.02.171 - 3rd May 2017
+===============================
+ Fix memory warnings by using mempools for command definition processing.
Fix running commands from a script file.
Add pvcreate prompt when device size doesn't match setphysicalvolumesize.
lvconvert - preserve region size on raid1 image count changes
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index c88516d..20d6220 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,5 @@
-Version 1.02.140 -
-==================================
+Version 1.02.140 - 3rd May 2017
+===============================
Add missing configure --enable-dmfilemapd status message and fix --disable.
Version 1.02.139 - 13th April 2017
6 years, 12 months
master - man: generate
by Alasdair Kergon
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=6bdbb283d54c7f91abd...
Commit: 6bdbb283d54c7f91abd75c0c463a8475ac5435ff
Parent: a0f742542f5762c4c80e52eab31819ea5abdb94b
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Wed May 3 11:23:15 2017 +0100
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Wed May 3 11:23:15 2017 +0100
man: generate
---
man/lvchange.8_pregen | 2 +-
man/lvconvert.8_pregen | 2 +-
man/lvcreate.8_pregen | 2 +-
man/lvdisplay.8_pregen | 2 +-
man/lvextend.8_pregen | 2 +-
man/lvm-fullreport.8_pregen | 2 +-
man/lvm-lvpoll.8_pregen | 2 +-
man/lvmconfig.8_pregen | 2 +-
man/lvmdiskscan.8_pregen | 2 +-
man/lvreduce.8_pregen | 2 +-
man/lvremove.8_pregen | 2 +-
man/lvrename.8_pregen | 2 +-
man/lvresize.8_pregen | 2 +-
man/lvs.8_pregen | 2 +-
man/lvscan.8_pregen | 2 +-
man/pvchange.8_pregen | 2 +-
man/pvck.8_pregen | 2 +-
man/pvcreate.8_pregen | 2 +-
man/pvdisplay.8_pregen | 2 +-
man/pvmove.8_pregen | 2 +-
man/pvremove.8_pregen | 2 +-
man/pvresize.8_pregen | 2 +-
man/pvs.8_pregen | 2 +-
man/pvscan.8_pregen | 2 +-
man/vgcfgbackup.8_pregen | 2 +-
man/vgcfgrestore.8_pregen | 2 +-
man/vgchange.8_pregen | 2 +-
man/vgck.8_pregen | 2 +-
man/vgconvert.8_pregen | 2 +-
man/vgcreate.8_pregen | 2 +-
man/vgdisplay.8_pregen | 2 +-
man/vgexport.8_pregen | 2 +-
man/vgextend.8_pregen | 2 +-
man/vgimport.8_pregen | 2 +-
man/vgimportclone.8_pregen | 2 +-
man/vgmerge.8_pregen | 2 +-
man/vgmknodes.8_pregen | 2 +-
man/vgreduce.8_pregen | 2 +-
man/vgremove.8_pregen | 2 +-
man/vgrename.8_pregen | 2 +-
man/vgs.8_pregen | 2 +-
man/vgscan.8_pregen | 2 +-
man/vgsplit.8_pregen | 2 +-
43 files changed, 43 insertions(+), 43 deletions(-)
diff --git a/man/lvchange.8_pregen b/man/lvchange.8_pregen
index 174ad32..e89ad39 100644
--- a/man/lvchange.8_pregen
+++ b/man/lvchange.8_pregen
@@ -913,7 +913,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvconvert.8_pregen b/man/lvconvert.8_pregen
index 3652303..3a96dc8 100644
--- a/man/lvconvert.8_pregen
+++ b/man/lvconvert.8_pregen
@@ -1178,7 +1178,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvcreate.8_pregen b/man/lvcreate.8_pregen
index 38edc85..3954026 100644
--- a/man/lvcreate.8_pregen
+++ b/man/lvcreate.8_pregen
@@ -1301,7 +1301,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvdisplay.8_pregen b/man/lvdisplay.8_pregen
index 49de9cf..a0ca9aa 100644
--- a/man/lvdisplay.8_pregen
+++ b/man/lvdisplay.8_pregen
@@ -349,7 +349,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvextend.8_pregen b/man/lvextend.8_pregen
index 46f1db4..ae631be 100644
--- a/man/lvextend.8_pregen
+++ b/man/lvextend.8_pregen
@@ -484,7 +484,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvm-fullreport.8_pregen b/man/lvm-fullreport.8_pregen
index 11ba4b8..8104dba 100644
--- a/man/lvm-fullreport.8_pregen
+++ b/man/lvm-fullreport.8_pregen
@@ -331,7 +331,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvm-lvpoll.8_pregen b/man/lvm-lvpoll.8_pregen
index b99a45d..1292a6c 100644
--- a/man/lvm-lvpoll.8_pregen
+++ b/man/lvm-lvpoll.8_pregen
@@ -174,7 +174,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvmconfig.8_pregen b/man/lvmconfig.8_pregen
index e6d34aa..e7f93cd 100644
--- a/man/lvmconfig.8_pregen
+++ b/man/lvmconfig.8_pregen
@@ -269,7 +269,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvmdiskscan.8_pregen b/man/lvmdiskscan.8_pregen
index 4e390d5..b346fde 100644
--- a/man/lvmdiskscan.8_pregen
+++ b/man/lvmdiskscan.8_pregen
@@ -143,7 +143,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvreduce.8_pregen b/man/lvreduce.8_pregen
index 1781600..65f3da4 100644
--- a/man/lvreduce.8_pregen
+++ b/man/lvreduce.8_pregen
@@ -222,7 +222,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvremove.8_pregen b/man/lvremove.8_pregen
index 5edb4ef..cc28563 100644
--- a/man/lvremove.8_pregen
+++ b/man/lvremove.8_pregen
@@ -203,7 +203,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvrename.8_pregen b/man/lvrename.8_pregen
index de41077..dfb9247 100644
--- a/man/lvrename.8_pregen
+++ b/man/lvrename.8_pregen
@@ -163,7 +163,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvresize.8_pregen b/man/lvresize.8_pregen
index 3e12aa2..df9d93c 100644
--- a/man/lvresize.8_pregen
+++ b/man/lvresize.8_pregen
@@ -426,7 +426,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvs.8_pregen b/man/lvs.8_pregen
index 31244e2..b16bc86 100644
--- a/man/lvs.8_pregen
+++ b/man/lvs.8_pregen
@@ -345,7 +345,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/lvscan.8_pregen b/man/lvscan.8_pregen
index 12211b2..523de90 100644
--- a/man/lvscan.8_pregen
+++ b/man/lvscan.8_pregen
@@ -190,7 +190,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvchange.8_pregen b/man/pvchange.8_pregen
index 62f909f..85ffcc8 100644
--- a/man/pvchange.8_pregen
+++ b/man/pvchange.8_pregen
@@ -264,7 +264,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvck.8_pregen b/man/pvck.8_pregen
index 0d7924c..fe5a030 100644
--- a/man/pvck.8_pregen
+++ b/man/pvck.8_pregen
@@ -136,7 +136,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvcreate.8_pregen b/man/pvcreate.8_pregen
index 55d153f..d3cb688 100644
--- a/man/pvcreate.8_pregen
+++ b/man/pvcreate.8_pregen
@@ -294,7 +294,7 @@ on the ability to use vgsplit later.)
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvdisplay.8_pregen b/man/pvdisplay.8_pregen
index 94d6ebf..9434508 100644
--- a/man/pvdisplay.8_pregen
+++ b/man/pvdisplay.8_pregen
@@ -334,7 +334,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvmove.8_pregen b/man/pvmove.8_pregen
index e6aa48f..08f35b9 100644
--- a/man/pvmove.8_pregen
+++ b/man/pvmove.8_pregen
@@ -268,7 +268,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvremove.8_pregen b/man/pvremove.8_pregen
index 57b28cf..a913ab3 100644
--- a/man/pvremove.8_pregen
+++ b/man/pvremove.8_pregen
@@ -144,7 +144,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvresize.8_pregen b/man/pvresize.8_pregen
index 1b37c72..8a03088 100644
--- a/man/pvresize.8_pregen
+++ b/man/pvresize.8_pregen
@@ -132,7 +132,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvs.8_pregen b/man/pvs.8_pregen
index d0742df..9b5162a 100644
--- a/man/pvs.8_pregen
+++ b/man/pvs.8_pregen
@@ -332,7 +332,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/pvscan.8_pregen b/man/pvscan.8_pregen
index 472728c..0148c09 100644
--- a/man/pvscan.8_pregen
+++ b/man/pvscan.8_pregen
@@ -327,7 +327,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgcfgbackup.8_pregen b/man/vgcfgbackup.8_pregen
index d085a34..6a7099d 100644
--- a/man/vgcfgbackup.8_pregen
+++ b/man/vgcfgbackup.8_pregen
@@ -185,7 +185,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgcfgrestore.8_pregen b/man/vgcfgrestore.8_pregen
index 5197f1a..d15859e 100644
--- a/man/vgcfgrestore.8_pregen
+++ b/man/vgcfgrestore.8_pregen
@@ -284,7 +284,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgchange.8_pregen b/man/vgchange.8_pregen
index d3514b9..6d95335 100644
--- a/man/vgchange.8_pregen
+++ b/man/vgchange.8_pregen
@@ -817,7 +817,7 @@ on the ability to use vgsplit later.)
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgck.8_pregen b/man/vgck.8_pregen
index fa47193..235c3cc 100644
--- a/man/vgck.8_pregen
+++ b/man/vgck.8_pregen
@@ -132,7 +132,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgconvert.8_pregen b/man/vgconvert.8_pregen
index ef524fe..60b474b 100644
--- a/man/vgconvert.8_pregen
+++ b/man/vgconvert.8_pregen
@@ -215,7 +215,7 @@ on the ability to use vgsplit later.)
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgcreate.8_pregen b/man/vgcreate.8_pregen
index d65d4e2..6311e42 100644
--- a/man/vgcreate.8_pregen
+++ b/man/vgcreate.8_pregen
@@ -367,7 +367,7 @@ on the ability to use vgsplit later.)
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgdisplay.8_pregen b/man/vgdisplay.8_pregen
index a9a9463..9b99936 100644
--- a/man/vgdisplay.8_pregen
+++ b/man/vgdisplay.8_pregen
@@ -323,7 +323,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgexport.8_pregen b/man/vgexport.8_pregen
index ee69731..6d2c6ca 100644
--- a/man/vgexport.8_pregen
+++ b/man/vgexport.8_pregen
@@ -160,7 +160,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgextend.8_pregen b/man/vgextend.8_pregen
index 23d83c9..5445f6c 100644
--- a/man/vgextend.8_pregen
+++ b/man/vgextend.8_pregen
@@ -258,7 +258,7 @@ on the ability to use vgsplit later.)
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgimport.8_pregen b/man/vgimport.8_pregen
index 138a239..ffd237c 100644
--- a/man/vgimport.8_pregen
+++ b/man/vgimport.8_pregen
@@ -168,7 +168,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgimportclone.8_pregen b/man/vgimportclone.8_pregen
index 3c5245e..ea326f7 100644
--- a/man/vgimportclone.8_pregen
+++ b/man/vgimportclone.8_pregen
@@ -153,7 +153,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgmerge.8_pregen b/man/vgmerge.8_pregen
index 8705d76..c2a071b 100644
--- a/man/vgmerge.8_pregen
+++ b/man/vgmerge.8_pregen
@@ -146,7 +146,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgmknodes.8_pregen b/man/vgmknodes.8_pregen
index 5bfd1a8..d23ecaf 100644
--- a/man/vgmknodes.8_pregen
+++ b/man/vgmknodes.8_pregen
@@ -151,7 +151,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgreduce.8_pregen b/man/vgreduce.8_pregen
index 98a2278..d5cdac3 100644
--- a/man/vgreduce.8_pregen
+++ b/man/vgreduce.8_pregen
@@ -267,7 +267,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgremove.8_pregen b/man/vgremove.8_pregen
index 8ede805..22e778c 100644
--- a/man/vgremove.8_pregen
+++ b/man/vgremove.8_pregen
@@ -163,7 +163,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgrename.8_pregen b/man/vgrename.8_pregen
index 0dd21d4..5a5b8fa 100644
--- a/man/vgrename.8_pregen
+++ b/man/vgrename.8_pregen
@@ -174,7 +174,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgs.8_pregen b/man/vgs.8_pregen
index b621666..7909af9 100644
--- a/man/vgs.8_pregen
+++ b/man/vgs.8_pregen
@@ -327,7 +327,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgscan.8_pregen b/man/vgscan.8_pregen
index df36e3a..ccc2f29 100644
--- a/man/vgscan.8_pregen
+++ b/man/vgscan.8_pregen
@@ -171,7 +171,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
diff --git a/man/vgsplit.8_pregen b/man/vgsplit.8_pregen
index 98235ea..400cdcd 100644
--- a/man/vgsplit.8_pregen
+++ b/man/vgsplit.8_pregen
@@ -244,7 +244,7 @@ on the command.
\fB-q\fP|\fB--quiet\fP ...
.br
Suppress output and log messages. Overrides --debug and --verbose.
-Repeat once to also suppress any prompts with answer no.
+Repeat once to also suppress any prompts with answer 'no'.
.ad b
.HP
.ad l
6 years, 12 months
master - command: avoid compiler warning
by Alasdair Kergon
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=a0f742542f5762c4c80...
Commit: a0f742542f5762c4c80e52eab31819ea5abdb94b
Parent: e15c7c5ff963e1a0287f25bca401bc3dbe515f76
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Wed May 3 11:19:43 2017 +0100
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Wed May 3 11:19:43 2017 +0100
command: avoid compiler warning
man-generator.c:3243: warning: declaration of ���stat��� shadows a global
declaration
---
tools/command.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/command.c b/tools/command.c
index 347475b..0f69bbb 100644
--- a/tools/command.c
+++ b/tools/command.c
@@ -3240,29 +3240,29 @@ static int include_description_file(char *name, char *des_file)
char *buf;
int fd, r = 0;
ssize_t sz;
- struct stat stat;
+ struct stat statbuf;
if ((fd = open(des_file, O_RDONLY)) < 0) {
log_error("Failed to open description file %s.", des_file);
return 0;
}
- if (fstat(fd, &stat) < 0) {
+ if (fstat(fd, &statbuf) < 0) {
log_error("Failed to stat description file %s.", des_file);
goto out_close;
}
- if (stat.st_size > MAX_MAN_DESC) {
+ if (statbuf.st_size > MAX_MAN_DESC) {
log_error("Description file %s is too large.", des_file);
goto out_close;
}
- if (!(buf = dm_malloc(stat.st_size + 1))) {
+ if (!(buf = dm_malloc(statbuf.st_size + 1))) {
log_error("Failed to allocate buffer for description file %s.", des_file);
goto out_close;
}
- if ((sz = read(fd, buf, stat.st_size)) < 0) {
+ if ((sz = read(fd, buf, statbuf.st_size)) < 0) {
log_error("Failed to read description file %s.", des_file);
goto out_free;
}
6 years, 12 months
master - man: references to lvm entities
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e15c7c5ff963e1a0287...
Commit: e15c7c5ff963e1a0287f25bca401bc3dbe515f76
Parent: 253bc5eb2e570fab788640e7256aeb52d1f51045
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Tue May 2 16:47:02 2017 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Tue May 2 16:47:02 2017 -0500
man: references to lvm entities
Try to reference lvm(8) at the start of topical
man pages, and spell out acronyms early in the
text, descriptions of which can be found in lvm(8).
---
man/lvmcache.7_main | 11 ++++++-----
man/lvmraid.7_main | 18 ++++++++++--------
man/lvmsystemid.7_main | 8 ++++----
man/lvmthin.7_main | 20 ++++++++++----------
4 files changed, 30 insertions(+), 27 deletions(-)
diff --git a/man/lvmcache.7_main b/man/lvmcache.7_main
index 3ddb7cd..e573b58 100644
--- a/man/lvmcache.7_main
+++ b/man/lvmcache.7_main
@@ -4,9 +4,9 @@ lvmcache \(em LVM caching
.SH DESCRIPTION
-The \fBcache\fP logical volume type uses a small and fast LV to improve
-the performance of a large and slow LV. It does this by storing the
-frequently used blocks on the faster LV.
+An \fBlvm\fP(8) \fBcache\fP Logical Volume (LV) uses a small and
+fast LV to improve the performance of a large and slow LV. It does this
+by storing the frequently used blocks on the faster LV.
LVM refers to the small fast LV as a \fBcache pool LV\fP. The large
slow LV is called the \fBorigin LV\fP. Due to requirements from dm-cache
(the kernel driver), LVM further splits the cache pool LV into two
@@ -16,7 +16,8 @@ origin LV to increase speed. The cache metadata LV holds the
accounting information that specifies where data blocks are stored (e.g.
on the origin LV or on the cache data LV). Users should be familiar with
these LVs if they wish to create the best and most robust cached
-logical volumes. All of these associated LVs must be in the same VG.
+LVs. All of these associated LVs must be in the same Volume
+Group (VG).
.SH Cache Terms
.nf
@@ -29,7 +30,7 @@ cache LV CacheLV OriginLV + CachePoolLV
.SH Cache Usage
-The primary method for using a cache type logical volume:
+The primary method for using a cache type LV:
.SS 0. create OriginLV
diff --git a/man/lvmraid.7_main b/man/lvmraid.7_main
index 47dc6ba..f0d28f5 100644
--- a/man/lvmraid.7_main
+++ b/man/lvmraid.7_main
@@ -5,14 +5,16 @@ lvmraid \(em LVM RAID
.SH DESCRIPTION
-LVM RAID is a way to create logical volumes (LVs) that use multiple physical
-devices to improve performance or tolerate device failure. How blocks of
-data in an LV are placed onto physical devices is determined by the RAID
-level. RAID levels are commonly referred by a level specific number
-suffixed to the string 'raid', e.g. raid1, raid5 or raid6.
-Selecting a RAID level involves tradeoffs among physical device
-requirements, fault tolerance, and performance. A description of the RAID
-levels can be found at
+\fBlvm\fP(8) RAID is a way to create a Logical Volume (LV) that uses
+multiple physical devices to improve performance or tolerate device
+failures. In LVM, the physical devices are Physical Volumes (PVs) in a
+single Volume Group (VG).
+
+How LV data blocks are placed onto PVs is determined by the RAID level.
+RAID levels are commonly referred to as 'raid' followed by a number, e.g.
+raid1, raid5 or raid6. Selecting a RAID level involves making tradeoffs
+among: physical device requirements, fault tolerance, and performance. A
+description of the RAID levels can be found at
.br
www.snia.org/sites/default/files/SNIA_DDF_Technical_Position_v2.0.pdf
diff --git a/man/lvmsystemid.7_main b/man/lvmsystemid.7_main
index c1db4c9..8c57042 100644
--- a/man/lvmsystemid.7_main
+++ b/man/lvmsystemid.7_main
@@ -5,10 +5,10 @@ lvmsystemid \(em LVM system ID
.SH DESCRIPTION
-The \fBlvm\fP(8) system ID restricts VG access to one host. This is
-useful when a VG is placed on shared storage devices, or when local
-devices are visible to both host and guest operating systems. In cases
-like these, a VG can be visible to multiple hosts at once, and some
+The \fBlvm\fP(8) system ID restricts Volume Group (VG) access to one host.
+This is useful when a VG is placed on shared storage devices, or when
+local devices are visible to both host and guest operating systems. In
+cases like these, a VG can be visible to multiple hosts at once, and some
mechanism is needed to protect it from being used by more than one host at
a time.
diff --git a/man/lvmthin.7_main b/man/lvmthin.7_main
index c5efa9c..1ebeb65 100644
--- a/man/lvmthin.7_main
+++ b/man/lvmthin.7_main
@@ -5,17 +5,17 @@ lvmthin \(em LVM thin provisioning
.SH DESCRIPTION
-Blocks in a standard logical volume are allocated when the LV is created,
-but blocks in a thin provisioned logical volume are allocated as they are
-written. Because of this, a thin provisioned LV is given a virtual size,
-and can then be much larger than physically available storage. The amount
-of physical storage provided for thin provisioned LVs can be increased
-later as the need arises.
-
-Blocks in a standard LV are allocated (during creation) from the VG, but
-blocks in a thin LV are allocated (during use) from a special "thin pool
-LV". The thin pool LV contains blocks of physical storage, and blocks in
-thin LVs just reference blocks in the thin pool LV.
+Blocks in a standard \fBlvm\fP(8) Logical Volume (LV) are allocated when
+the LV is created, but blocks in a thin provisioned LV are allocated as
+they are written. Because of this, a thin provisioned LV is given a
+virtual size, and can then be much larger than physically available
+storage. The amount of physical storage provided for thin provisioned LVs
+can be increased later as the need arises.
+
+Blocks in a standard LV are allocated (during creation) from the Volume
+Group (VG), but blocks in a thin LV are allocated (during use) from a
+special "thin pool LV". The thin pool LV contains blocks of physical
+storage, and blocks in thin LVs just reference blocks in the thin pool LV.
A thin pool LV must be created before thin LVs can be created within it.
A thin pool LV is created by combining two standard LVs: a large data LV
6 years, 12 months