master - lvmdbusd: Only disable notify_dbus after getting external event
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=2dc71fc291b3ac86129...
Commit: 2dc71fc291b3ac861298b4dd7b25963dd9325a4d
Parent: 17b56a4aed90806eac03c32f013f552440b2f596
Author: Tony Asleson <tasleson(a)redhat.com>
AuthorDate: Wed Mar 15 10:57:01 2017 -0500
Committer: Tony Asleson <tasleson(a)redhat.com>
CommitterDate: Mon Mar 20 10:08:38 2017 -0500
lvmdbusd: Only disable notify_dbus after getting external event
If we always disable the sending of notify dbus events then in the case
where all the users are lvm dbus users we will be in udev handling mode
until at least 1 external lvm command occurs. Instead we will not disable
notify dbus until after we get at least 1 external event. This makes the
service get into the correct mode of operation faster.
---
daemons/lvmdbusd/utils.py | 23 +++++++++++++----------
1 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/daemons/lvmdbusd/utils.py b/daemons/lvmdbusd/utils.py
index 2e7b808..c9a84cc 100644
--- a/daemons/lvmdbusd/utils.py
+++ b/daemons/lvmdbusd/utils.py
@@ -510,16 +510,19 @@ def add_no_notify(cmdline):
:rtype: list
"""
- if 'help' in cmdline:
- return cmdline
-
- if '--config' in cmdline:
- for i, arg in enumerate(cmdline):
- if arg == '--config':
- cmdline[i] += "global/notify_dbus=0"
- break
- else:
- cmdline.extend(['--config', 'global/notify_dbus=0'])
+ # Only after we have seen an external event will be disable lvm from sending
+ # us one when we call lvm
+ if cfg.ee:
+ if 'help' in cmdline:
+ return cmdline
+
+ if '--config' in cmdline:
+ for i, arg in enumerate(cmdline):
+ if arg == '--config':
+ cmdline[i] += "global/notify_dbus=0"
+ break
+ else:
+ cmdline.extend(['--config', 'global/notify_dbus=0'])
return cmdline
7 years, 2 months
master - tests: early detect leaking error dev
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=17b56a4aed90806eac0...
Commit: 17b56a4aed90806eac03c32f013f552440b2f596
Parent: 07040942ed02455cf168ba6cf40264a644627553
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Mar 20 14:18:50 2017 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 20 14:18:50 2017 +0100
tests: early detect leaking error dev
lvconvert should not leak 'error' device.
(This patch is not fix the problem, just makes it more easily visible
instead of more confusing 'clvmd' trace).
---
test/shell/lvconvert-raid-takeover.sh | 28 +++++++++++++++++++++++++++-
1 files changed, 27 insertions(+), 1 deletions(-)
diff --git a/test/shell/lvconvert-raid-takeover.sh b/test/shell/lvconvert-raid-takeover.sh
index 0e8e880..e1b1d98 100644
--- a/test/shell/lvconvert-raid-takeover.sh
+++ b/test/shell/lvconvert-raid-takeover.sh
@@ -22,6 +22,26 @@ aux have_raid 1 9 1 && correct_raid4_layout=1
aux prepare_vg 8
+# FIXME: lvconvert leaks 'error' devices
+detect_error_leak_()
+{
+ local err
+
+ dmsetup info -c -o name --noheadings | tee out
+ if grep $vg out ; then
+ for i in $(grep $vg out) ; do
+ if dmsetup table $i | grep "error "; then
+ err="$err $i"
+ fi
+ done
+ test -z "$err" || {
+ dmsetup table | grep $vg
+ dmsetup ls --tree
+ die "Device(s) $err should not be here."
+ }
+ fi
+}
+
function _lvcreate
{
local level=$1
@@ -56,7 +76,8 @@ function _lvconvert
[ "${level:0:5}" = "raid0" ] && wait_and_check=0
lvconvert -y --ty $req_level $R $vg/$lv
- [ $? -ne 0 ] && return $?
+ detect_error_leak_
+
check lv_field $vg/$lv segtype "$level"
check lv_field $vg/$lv data_stripes $data_stripes
check lv_field $vg/$lv stripes $stripes
@@ -112,6 +133,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Convert 3-way to 4-way mirror
lvconvert -m 3 $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "mirror"
check lv_field $vg/$lv1 stripes 4
fsck -fn "$DM_DEV_DIR/$vg/$lv1"
@@ -120,6 +142,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Takeover 4-way mirror to raid1
lvconvert --yes --type raid1 -R 64k $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "raid1"
check lv_field $vg/$lv1 stripes 4
check lv_field $vg/$lv1 regionsize "64.00k"
@@ -127,6 +150,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
## Convert 4-way raid1 to 5-way
lvconvert -m 4 -R 128K $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "raid1"
check lv_field $vg/$lv1 stripes 5
check lv_field $vg/$lv1 regionsize "128.00k"
@@ -142,6 +166,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Convert 5-way raid1 to 2-way
lvconvert --yes -m 1 $vg/$lv1
+detect_error_leak_
lvs $vg/$lv1
dmsetup status $vg-$lv1
dmsetup table $vg-$lv1
@@ -151,6 +176,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Convert 2-way raid1 to mirror
lvconvert --yes --type mirror -R 32K $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "mirror"
check lv_field $vg/$lv1 stripes 2
check lv_field $vg/$lv1 regionsize "32.00k"
7 years, 2 months
master - tests: early detect leaking error dev
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3a7590e31e6008dde6c...
Commit: 3a7590e31e6008dde6c226ec14b97adcb5331299
Parent: 07040942ed02455cf168ba6cf40264a644627553
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 18 19:39:48 2017 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Sat Mar 18 19:42:36 2017 +0100
tests: early detect leaking error dev
lvconvert should not leak 'error' device.
(This patch is not fix the problem, just makes it more easily visible
instead of more confusing 'clvmd' trace).
---
D/test/shell/pvmove-background.sh | 1 +
test/shell/lvconvert-raid-takeover.sh | 28 +++++++++++++++++++++++++++-
2 files changed, 28 insertions(+), 1 deletions(-)
diff --git a/D/test/shell/pvmove-background.sh b/D/test/shell/pvmove-background.sh
new file mode 120000
index 0000000..479c5b0
--- /dev/null
+++ b/D/test/shell/pvmove-background.sh
@@ -0,0 +1 @@
+/home/kabi/export/lvm2/test/shell/pvmove-background.sh
\ No newline at end of file
diff --git a/test/shell/lvconvert-raid-takeover.sh b/test/shell/lvconvert-raid-takeover.sh
index 0e8e880..e1b1d98 100644
--- a/test/shell/lvconvert-raid-takeover.sh
+++ b/test/shell/lvconvert-raid-takeover.sh
@@ -22,6 +22,26 @@ aux have_raid 1 9 1 && correct_raid4_layout=1
aux prepare_vg 8
+# FIXME: lvconvert leaks 'error' devices
+detect_error_leak_()
+{
+ local err
+
+ dmsetup info -c -o name --noheadings | tee out
+ if grep $vg out ; then
+ for i in $(grep $vg out) ; do
+ if dmsetup table $i | grep "error "; then
+ err="$err $i"
+ fi
+ done
+ test -z "$err" || {
+ dmsetup table | grep $vg
+ dmsetup ls --tree
+ die "Device(s) $err should not be here."
+ }
+ fi
+}
+
function _lvcreate
{
local level=$1
@@ -56,7 +76,8 @@ function _lvconvert
[ "${level:0:5}" = "raid0" ] && wait_and_check=0
lvconvert -y --ty $req_level $R $vg/$lv
- [ $? -ne 0 ] && return $?
+ detect_error_leak_
+
check lv_field $vg/$lv segtype "$level"
check lv_field $vg/$lv data_stripes $data_stripes
check lv_field $vg/$lv stripes $stripes
@@ -112,6 +133,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Convert 3-way to 4-way mirror
lvconvert -m 3 $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "mirror"
check lv_field $vg/$lv1 stripes 4
fsck -fn "$DM_DEV_DIR/$vg/$lv1"
@@ -120,6 +142,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Takeover 4-way mirror to raid1
lvconvert --yes --type raid1 -R 64k $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "raid1"
check lv_field $vg/$lv1 stripes 4
check lv_field $vg/$lv1 regionsize "64.00k"
@@ -127,6 +150,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
## Convert 4-way raid1 to 5-way
lvconvert -m 4 -R 128K $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "raid1"
check lv_field $vg/$lv1 stripes 5
check lv_field $vg/$lv1 regionsize "128.00k"
@@ -142,6 +166,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Convert 5-way raid1 to 2-way
lvconvert --yes -m 1 $vg/$lv1
+detect_error_leak_
lvs $vg/$lv1
dmsetup status $vg-$lv1
dmsetup table $vg-$lv1
@@ -151,6 +176,7 @@ fsck -fn "$DM_DEV_DIR/$vg/$lv1"
# Convert 2-way raid1 to mirror
lvconvert --yes --type mirror -R 32K $vg/$lv1
+detect_error_leak_
check lv_field $vg/$lv1 segtype "mirror"
check lv_field $vg/$lv1 stripes 2
check lv_field $vg/$lv1 regionsize "32.00k"
7 years, 2 months
master - man: advise against mirrored mirror log
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=07040942ed02455cf16...
Commit: 07040942ed02455cf168ba6cf40264a644627553
Parent: 8d7be8f5df2787354bb6cf40b6436047b82cfb58
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Fri Mar 17 11:54:39 2017 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Fri Mar 17 11:54:39 2017 -0500
man: advise against mirrored mirror log
---
tools/args.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tools/args.h b/tools/args.h
index 9d839b5..b81e2c9 100644
--- a/tools/args.h
+++ b/tools/args.h
@@ -331,7 +331,8 @@ arg(mirrorlog_ARG, '\0', "mirrorlog", mirrorlog_VAL, 0, 0,
"\\fBcore\\fP is not persistent; the log is kept only in memory.\n"
"In this case, the mirror must be synchronized (by copying LV data from\n"
"the first device to others) each time the LV is activated, e.g. after reboot.\n"
- "\\fBmirrored\\fP is a persistent log that is itself mirrored.\n")
+ "\\fBmirrored\\fP is a persistent log that is itself mirrored, but\n"
+ "should be avoided. Instead, use the raid1 type for log redundancy.\n")
arg(mirrorsonly_ARG, '\0', "mirrorsonly", 0, 0, 0,
"Only remove missing PVs from mirror LVs.\n")
7 years, 2 months
master - help: align option list in pv/lv/vgchange cases
by David Teigland
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=8d7be8f5df2787354bb...
Commit: 8d7be8f5df2787354bb6cf40b6436047b82cfb58
Parent: fec2ea76cf30f6333ff4dc6afb8a40b84d7abf7b
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Fri Mar 17 11:20:51 2017 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Fri Mar 17 11:23:38 2017 -0500
help: align option list in pv/lv/vgchange cases
Align one-required options like is done for
optional options.
---
tools/command.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++--------
1 files changed, 54 insertions(+), 10 deletions(-)
diff --git a/tools/command.c b/tools/command.c
index e14291d..a344e55 100644
--- a/tools/command.c
+++ b/tools/command.c
@@ -1708,22 +1708,69 @@ void print_usage(struct command *cmd, int longhelp, int desc_first)
printf(" %s", cmd->name);
- if (cmd->ro_count) {
+ if (onereq && cmd->ro_count) {
+ /* one required option in a set */
first = 1;
+ /* options with short and long */
+ for (ro = 0; ro < cmd->ro_count; ro++) {
+ opt_enum = cmd->required_opt_args[ro].opt;
+
+ if (!opt_names[opt_enum].short_opt)
+ continue;
+
+ if ((opt_enum == size_ARG) && command_has_alternate_extents(cmd->name))
+ include_extents = 1;
+
+ if (first)
+ printf("\n\t(");
+ else
+ printf(",\n\t ");
+ first = 0;
+
+ printf(" -%c|%s", opt_names[opt_enum].short_opt, opt_names[opt_enum].long_opt);
+
+ if (cmd->required_opt_args[ro].def.val_bits) {
+ printf(" ");
+ print_usage_def(cmd, opt_enum, &cmd->required_opt_args[ro].def);
+ }
+ }
+
+ /* options with only long */
for (ro = 0; ro < cmd->ro_count; ro++) {
opt_enum = cmd->required_opt_args[ro].opt;
+ if (opt_names[opt_enum].short_opt)
+ continue;
+
if ((opt_enum == size_ARG) && command_has_alternate_extents(cmd->name))
include_extents = 1;
- if (onereq) {
- if (first)
- printf("\n\t(");
- else
- printf(",\n\t ");
- first = 0;
+ if (first)
+ printf("\n\t(");
+ else
+ printf(",\n\t ");
+ first = 0;
+
+ printf(" %s", opt_names[opt_enum].long_opt);
+
+ if (cmd->required_opt_args[ro].def.val_bits) {
+ printf(" ");
+ print_usage_def(cmd, opt_enum, &cmd->required_opt_args[ro].def);
}
+ }
+
+ printf(" )\n");
+ }
+
+ if (!onereq && cmd->ro_count) {
+ first = 1;
+
+ for (ro = 0; ro < cmd->ro_count; ro++) {
+ opt_enum = cmd->required_opt_args[ro].opt;
+
+ if ((opt_enum == size_ARG) && command_has_alternate_extents(cmd->name))
+ include_extents = 1;
if (opt_names[opt_enum].short_opt)
printf(" -%c|%s", opt_names[opt_enum].short_opt, opt_names[opt_enum].long_opt);
@@ -1735,9 +1782,6 @@ void print_usage(struct command *cmd, int longhelp, int desc_first)
print_usage_def(cmd, opt_enum, &cmd->required_opt_args[ro].def);
}
}
-
- if (onereq)
- printf(" )\n");
}
if (cmd->rp_count) {
7 years, 2 months
master - raid: check target version for shrink support
by Heinz Mauelshagen
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=fec2ea76cf30f6333ff...
Commit: fec2ea76cf30f6333ff4dc6afb8a40b84d7abf7b
Parent: 17a8f3d6f0fa26ab01d974af409d1d075d5815a0
Author: Heinz Mauelshagen <heinzm(a)redhat.com>
AuthorDate: Fri Mar 17 16:46:33 2017 +0100
Committer: Heinz Mauelshagen <heinzm(a)redhat.com>
CommitterDate: Fri Mar 17 16:46:33 2017 +0100
raid: check target version for shrink support
Starting with dm-raid target version 1.9.0 shrinking of mapped devices is supported.
Check for support being present in lvresize and lvreduce.
Related: rhbz1394048
---
lib/metadata/lv_manip.c | 13 +++++++++++++
lib/metadata/segtype.h | 3 ++-
lib/raid/raid.c | 1 +
3 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index a249d29..0dfbad4 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -4773,6 +4773,19 @@ static int _lvresize_check(struct logical_volume *lv,
return 0;
}
+ if (lv_is_raid(lv) &&
+ lp->resize == LV_REDUCE) {
+ unsigned attrs;
+ const struct segment_type *segtype = first_seg(lv)->segtype;
+
+ if (!segtype->ops->target_present ||
+ !segtype->ops->target_present(lv->vg->cmd, NULL, &attrs) ||
+ !(attrs & RAID_FEATURE_SHRINK)) {
+ log_error("RAID module does not support shrinking.");
+ return 0;
+ }
+ }
+
if (lp->use_policies && !lv_is_cow(lv) && !lv_is_thin_pool(lv)) {
log_error("Policy-based resize is supported only for snapshot and thin pool volumes.");
return 0;
diff --git a/lib/metadata/segtype.h b/lib/metadata/segtype.h
index f99d3ad..2364db8 100644
--- a/lib/metadata/segtype.h
+++ b/lib/metadata/segtype.h
@@ -286,7 +286,8 @@ struct segment_type *init_unknown_segtype(struct cmd_context *cmd,
#define RAID_FEATURE_RAID0 (1U << 1) /* version 1.7 */
#define RAID_FEATURE_RESHAPING (1U << 2) /* version 1.8 */
#define RAID_FEATURE_RAID4 (1U << 3) /* ! version 1.8 or 1.9.0 */
-#define RAID_FEATURE_RESHAPE (1U << 4) /* version 1.10.1 */
+#define RAID_FEATURE_SHRINK (1U << 4) /* version 1.9.0 */
+#define RAID_FEATURE_RESHAPE (1U << 5) /* version 1.10.1 */
#ifdef RAID_INTERNAL
int init_raid_segtypes(struct cmd_context *cmd, struct segtype_library *seglib);
diff --git a/lib/raid/raid.c b/lib/raid/raid.c
index 6439a3e..df9796d 100644
--- a/lib/raid/raid.c
+++ b/lib/raid/raid.c
@@ -473,6 +473,7 @@ static int _raid_target_present(struct cmd_context *cmd,
const struct raid_feature _features[] = {
{ 1, 3, 0, RAID_FEATURE_RAID10, SEG_TYPE_NAME_RAID10 },
{ 1, 7, 0, RAID_FEATURE_RAID0, SEG_TYPE_NAME_RAID0 },
+ { 1, 9, 0, RAID_FEATURE_SHRINK, "shrinking" },
{ 1, 10, 1, RAID_FEATURE_RESHAPE, "reshaping" },
};
7 years, 2 months
master - raid: conditionally reject convert to striped/raid; fix
by Heinz Mauelshagen
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=17a8f3d6f0fa26ab01d...
Commit: 17a8f3d6f0fa26ab01d974af409d1d075d5815a0
Parent: 6ebf39da91678238ebea4f13cb1252bbc70238c5
Author: Heinz Mauelshagen <heinzm(a)redhat.com>
AuthorDate: Fri Mar 17 16:03:35 2017 +0100
Committer: Heinz Mauelshagen <heinzm(a)redhat.com>
CommitterDate: Fri Mar 17 16:03:35 2017 +0100
raid: conditionally reject convert to striped/raid; fix
Fix a logic flaw introduced in commit 17bee733d16e
preventing e.g. striped -> raid5 conversions.
Related: rhbz1191935
Related: rhbz1366296
---
lib/metadata/raid_manip.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c
index 7521e80..018e36d 100644
--- a/lib/metadata/raid_manip.c
+++ b/lib/metadata/raid_manip.c
@@ -6017,7 +6017,7 @@ int lv_raid_convert(struct logical_volume *lv,
}
/* Prohibit any takeover in case sub LVs to be removed still exist after a previous reshape */
- if (_get_available_removed_sublvs(lv, &available_slvs, &removed_slvs))
+ if (!_get_available_removed_sublvs(lv, &available_slvs, &removed_slvs))
return 0;
if (removed_slvs) {
log_error("Can't convert %s LV %s to %s containing sub LVs to remove after a reshape.",
7 years, 2 months
master - WHATS_NEW: conditionally reject raid convert
by Heinz Mauelshagen
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=6ebf39da91678238ebe...
Commit: 6ebf39da91678238ebea4f13cb1252bbc70238c5
Parent: 76709aaf39dd0f233ef36b4c49e5378d3735ec62
Author: Heinz Mauelshagen <heinzm(a)redhat.com>
AuthorDate: Fri Mar 17 14:51:10 2017 +0100
Committer: Heinz Mauelshagen <heinzm(a)redhat.com>
CommitterDate: Fri Mar 17 14:51:10 2017 +0100
WHATS_NEW: conditionally reject raid convert
---
WHATS_NEW | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/WHATS_NEW b/WHATS_NEW
index 5d27b6b..daca9e0 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.02.169 -
=====================================
+ Conditionally reject raid convert to striped/raid0* after reshape
Ensure raid6 upconversion restrictions
Adjust mirror+raid DSOs to aforementioned lvconvert --repair
Disable lvmetad when lvconvert --repair is run.
7 years, 2 months
master - raid: cleanup; remove unused function
by Heinz Mauelshagen
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=76709aaf39dd0f233ef...
Commit: 76709aaf39dd0f233ef36b4c49e5378d3735ec62
Parent: 07ea9887d30ccdf71cc6363e45b2edf707066203
Author: Heinz Mauelshagen <heinzm(a)redhat.com>
AuthorDate: Fri Mar 17 14:24:09 2017 +0100
Committer: Heinz Mauelshagen <heinzm(a)redhat.com>
CommitterDate: Fri Mar 17 14:24:44 2017 +0100
raid: cleanup; remove unused function
Remove unused function (lv_has_constant_stripes() is used instead).
---
lib/metadata/raid_manip.c | 16 ----------------
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c
index 808e3e1..7521e80 100644
--- a/lib/metadata/raid_manip.c
+++ b/lib/metadata/raid_manip.c
@@ -39,22 +39,6 @@ static int _check_restriping(uint32_t new_stripes, struct logical_volume *lv)
return 1;
}
-__attribute__ ((__unused__))
-/* Check that all lv has segments have exactly the required number of areas */
-static int _check_num_areas_in_lv_segments(struct logical_volume *lv, unsigned num_areas)
-{
- struct lv_segment *seg;
-
- dm_list_iterate_items(seg, &lv->segments)
- if (seg->area_count != num_areas) {
- log_error("For this operation LV %s needs exactly %u data areas per segment.",
- display_lvname(lv), num_areas);
- return 0;
- }
-
- return 1;
-}
-
/*
* Check if reshape is supported in the kernel.
*/
7 years, 2 months
master - tests: raise min dm cache version
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=07ea9887d30ccdf71cc...
Commit: 07ea9887d30ccdf71cc6363e45b2edf707066203
Parent: 4a271e7ee720402d3045cd16b04fd7296131bdf5
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Fri Mar 17 14:20:20 2017 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Fri Mar 17 14:22:33 2017 +0100
tests: raise min dm cache version
Since we want to test different cache policies with profiles mq&smq
raise version to 1.8.
TODO: maybe split in more tests so older targets can test here as well.
N.B.: passthrough is also not supported with version 1.3
---
test/shell/profiles-cache.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/shell/profiles-cache.sh b/test/shell/profiles-cache.sh
index 8b27f20..f2acadb 100644
--- a/test/shell/profiles-cache.sh
+++ b/test/shell/profiles-cache.sh
@@ -17,7 +17,7 @@ SKIP_WITH_LVMPOLLD=1
. lib/inittest
-aux have_cache 1 3 0 || skip
+aux have_cache 1 8 0 || skip
PDIR="$LVM_SYSTEM_DIR/profile"
PFILE="cache-test"
7 years, 2 months