master - doc: update --filemap usage in dmstats.8.in
by Bryn Reeves
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=74565e41fc55a9...
Commit: 74565e41fc55a99c2c7b750225fd3a616ea84648
Parent: 6a77a40501b6cc71d8e5af30393a1305fcd923ab
Author: Bryn M. Reeves <bmr(a)redhat.com>
AuthorDate: Fri Jul 8 22:05:14 2016 +0100
Committer: Bryn M. Reeves <bmr(a)redhat.com>
CommitterDate: Fri Jul 8 22:05:36 2016 +0100
doc: update --filemap usage in dmstats.8.in
---
man/dmstats.8.in | 44 ++++++++++++++++++++++++++------------------
1 files changed, 26 insertions(+), 18 deletions(-)
diff --git a/man/dmstats.8.in b/man/dmstats.8.in
index ce1368f..161ae8c 100644
--- a/man/dmstats.8.in
+++ b/man/dmstats.8.in
@@ -80,15 +80,15 @@ dmstats \(em device-mapper statistics management
.de CMD_CREATE
. ad l
. BR create
-. IR device_name
+. RB [ device_name...
+. RB | file_path... ]
. RB [ \-\-alldevices ]
. RB [ \-\-areas
. IR nr_areas | \fB\-\-areasize
. IR area_size ]
. RB [ \-\-bounds
. IR \%histogram_boundaries ]
-. RB [ \-\-filemap
-. IR path ]
+. RB [ \-\-filemap ]
. RB [ \-\-nogroup ]
. RB [ \-\-precise ]
. RB [ \-\-start
@@ -299,11 +299,11 @@ results.
.
.HP
.BR \-\-filemap
-.IR path
.br
-Instead of creating regions specified by command line options, open
-the file found at \fBpath\fP, and create regions corresponding to the
-locations of the on-disk extents allocated to the file.
+Instead of creating regions on a device as specified by command line
+options, open the file found at each \fBfile_path\fP argument, and
+create regions corresponding to the locations of the on-disk extents
+allocated to the file(s).
.
.HP
.BR \-\-groupid
@@ -544,13 +544,13 @@ By default dmstats creates regions with a \fBprogram_id\fP of
On success the \fBregion_id\fP of the newly created region is printed
to stdout.
-If the \fB\-\-filemap\fP option is given with a regular file as the
-\fBpath\fP argument, instead of creating regions with parameters
-specified on the command line, \fBdmstats\fP will open the file located
-at \fBpath\fP and create regions corresponding to the physical extents
-allocated to the file. This can be used to monitor statistics for
-individual files in the file system, for example, virtual machine
-images, swap areas, or large database files.
+If the \fB\-\-filemap\fP option is given with a regular file, or list
+of files, as the \fBfile_path\fP argument, instead of creating regions
+with parameters specified on the command line, \fBdmstats\fP will open
+the files located at \fBfile_path\fP and create regions corresponding to
+the physical extents allocated to the file. This can be used to monitor
+statistics for individual files in the file system, for example, virtual
+machine images, swap areas, or large database files.
To work with the \fB\-\-filemap\fP option, files must be located on a
local file system, backed by a device-mapper device, that supports
@@ -1045,13 +1045,21 @@ vg00-lvol1: Created new region with 1 area(s) as region ID 1
.br
vg00-lvol1: Created new region with 1 area(s) as region ID 2
.P
-Create regions mapping the file vm.img and place them into a group with
-the alias set to the same name as the file.
+Create regions mapping each file in the directory images/ and place
+them into separate groups, each named after the corresponding file
.br
#
-.B dmstats create --filemap vm.img
+.B dmstats create --filemap images/*
+.br
+images/vm1.qcow2: Created new group with 87 region(s) as group ID 0.
+.br
+images/vm1-1.qcow2: Created new group with 8 region(s) as group ID 87.
+.br
+images/vm2.qcow2: Created new group with 11 region(s) as group ID 95.
+.br
+images/vm2-1.qcow2: Created new group with 1454 region(s) as group ID 106.
.br
-vm.img: Created new group with 112 region(s) as group ID 3.
+images/vm3.img: Created new group with 2 region(s) as group ID 1560.
.P
Print raw counters for region 4 on device d0
.br
7 years, 10 months
master - dmstats: accept multiple arguments to --filemap
by Bryn Reeves
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=6a77a40501b6cc...
Commit: 6a77a40501b6cc71d8e5af30393a1305fcd923ab
Parent: 2d1f03b6164bce6f871918f563de9d8233e76f93
Author: Bryn M. Reeves <bmr(a)redhat.com>
AuthorDate: Fri Jul 8 22:02:47 2016 +0100
Committer: Bryn M. Reeves <bmr(a)redhat.com>
CommitterDate: Fri Jul 8 22:05:36 2016 +0100
dmstats: accept multiple arguments to --filemap
Make the --filemap switch take no arguments and instead accept one
or more files on the command line to be mapped and placed into
groups.
This allows --filemap to be used with a glob:
# dmstats create --filemap *
rhel5.10-1.qcow2: Created new group with 87 region(s) as group ID 1564.
rhel5.10.qcow2: Created new group with 8 region(s) as group ID 1651.
rhel7.0-1.qcow2: Created new group with 11 region(s) as group ID 1659.
rhel7.0.qcow2: Created new group with 1454 region(s) as group ID 1670.
vm.img: Created new group with 2 region(s) as group ID 3124.
---
tools/dmsetup.c | 31 ++++++++++++++-----------------
1 files changed, 14 insertions(+), 17 deletions(-)
diff --git a/tools/dmsetup.c b/tools/dmsetup.c
index 34e33d3..e21d195 100644
--- a/tools/dmsetup.c
+++ b/tools/dmsetup.c
@@ -4979,18 +4979,19 @@ static int _stats_create_file(CMD_ARGS)
}
/* _stats_create_file does not use _process_all() */
- if (names) {
- log_error("Device argument not compatible with --filemap.");
+ if (names || !argc) {
+ log_error("--filemap requires a file path argument");
return 0;
} else {
- if (argc || _switches[UUID_ARG] || _switches[MAJOR_ARG]) {
- log_error("--uuid, --major, and device argument are "
- "incompatible with --filemap.");
- return 0;
- }
- if (_switches[ALL_DEVICES_ARG]) {
- log_error("--alldevices is incompatible with "
- "--filemap.");
+ if (argc)
+ path = argv[0];
+ else {
+ if (_switches[UUID_ARG] || _switches[MAJOR_ARG])
+ log_error("--uuid and --major are incompatible "
+ "with --filemap.");
+ if (_switches[ALL_DEVICES_ARG])
+ log_error("--alldevices is incompatible with "
+ "--filemap.");
return 0;
}
}
@@ -5019,7 +5020,6 @@ static int _stats_create_file(CMD_ARGS)
if (!strlen(program_id) && !_switches[FORCE_ARG])
program_id = DM_STATS_PROGRAM_ID;
- path = _string_args[FILEMAP_ARG];
precise = _int_args[PRECISE_ARG];
group = !_switches[NOGROUP_ARG];
@@ -5069,9 +5069,8 @@ static int _stats_create_file(CMD_ARGS)
goto bad;
}
- for (region = regions; *region != DM_STATS_REGIONS_ALL; region++) {
+ for (region = regions; *region != DM_STATS_REGIONS_ALL; region++)
count++;
- }
if (group) {
printf("%s: Created new group with "FMTu64" region(s) as "
@@ -6230,7 +6229,7 @@ static int _process_switches(int *argcp, char ***argvp, const char *dev_dir)
{"deferred", 0, &ind, DEFERRED_ARG},
{"select", 1, &ind, SELECT_ARG},
{"exec", 1, &ind, EXEC_ARG},
- {"filemap", 1, &ind, FILEMAP_ARG},
+ {"filemap", 0, &ind, FILEMAP_ARG},
{"force", 0, &ind, FORCE_ARG},
{"gid", 1, &ind, GID_ARG},
{"group", 0, &ind, GROUP_ARG},
@@ -6395,10 +6394,8 @@ static int _process_switches(int *argcp, char ***argvp, const char *dev_dir)
_switches[CLEAR_ARG]++;
if (c == 'c' || c == 'C' || ind == COLS_ARG)
_switches[COLS_ARG]++;
- if (ind == FILEMAP_ARG) {
+ if (ind == FILEMAP_ARG)
_switches[FILEMAP_ARG]++;
- _string_args[FILEMAP_ARG] = optarg;
- }
if (c == 'f' || ind == FORCE_ARG)
_switches[FORCE_ARG]++;
if (c == 'r' || ind == READ_ONLY)
7 years, 10 months
master - libdm: use a constant for FIEMAP buffer size
by Bryn Reeves
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=2d1f03b6164bce...
Commit: 2d1f03b6164bce6f871918f563de9d8233e76f93
Parent: 58bfea6a6e2789896e81fefe18e504fb7222e834
Author: Bryn M. Reeves <bmr(a)redhat.com>
AuthorDate: Fri Jul 8 21:13:25 2016 +0100
Committer: Bryn M. Reeves <bmr(a)redhat.com>
CommitterDate: Fri Jul 8 22:05:36 2016 +0100
libdm: use a constant for FIEMAP buffer size
---
libdm/libdm-stats.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c
index d911c60..bf9b7e3 100644
--- a/libdm/libdm-stats.c
+++ b/libdm/libdm-stats.c
@@ -37,6 +37,7 @@
#define STATS_ROW_BUF_LEN 4096
#define STATS_MSG_BUF_LEN 1024
+#define STATS_FIE_BUF_LEN 2048
#define SECTOR_SHIFT 9L
@@ -4147,7 +4148,7 @@ static int _stats_add_extent(struct dm_pool *mem, struct fiemap_extent *fm_ext,
static struct _extent *_stats_get_extents_for_file(struct dm_pool *mem, int fd,
uint64_t *count)
{
- uint64_t buf[2048];
+ uint64_t buf[STATS_FIE_BUF_LEN];
struct fiemap *fiemap = (struct fiemap *)buf;
struct fiemap_extent *fm_ext = &fiemap->fm_extents[0];
struct fiemap_extent fm_last = {0};
7 years, 10 months
master - libdm: use SECTOR_SHIFT constant in _stats_add_extent()
by Bryn Reeves
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=58bfea6a6e2789...
Commit: 58bfea6a6e2789896e81fefe18e504fb7222e834
Parent: 7771793a560b839e6bc4083819bc5b192d94835a
Author: Bryn M. Reeves <bmr(a)redhat.com>
AuthorDate: Fri Jul 8 21:12:18 2016 +0100
Committer: Bryn M. Reeves <bmr(a)redhat.com>
CommitterDate: Fri Jul 8 22:05:36 2016 +0100
libdm: use SECTOR_SHIFT constant in _stats_add_extent()
---
libdm/libdm-stats.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/libdm/libdm-stats.c b/libdm/libdm-stats.c
index 6504289..d911c60 100644
--- a/libdm/libdm-stats.c
+++ b/libdm/libdm-stats.c
@@ -38,6 +38,8 @@
#define STATS_ROW_BUF_LEN 4096
#define STATS_MSG_BUF_LEN 1024
+#define SECTOR_SHIFT 9L
+
/* Histogram bin */
struct dm_histogram_bin {
uint64_t upper; /* Upper bound on this bin. */
@@ -4120,8 +4122,8 @@ static int _stats_add_extent(struct dm_pool *mem, struct fiemap_extent *fm_ext,
memset(&extent.list, 0, sizeof(extent.list));
/* convert bytes to dm (512b) sectors */
- extent.start = fm_ext->fe_physical >> 9;
- extent.len = fm_ext->fe_length >> 9;
+ extent.start = fm_ext->fe_physical >> SECTOR_SHIFT;
+ extent.len = fm_ext->fe_length >> SECTOR_SHIFT;
extent.id = id;
7 years, 10 months
master - man: lvconvert changes
by David Teigland
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=7771793a560b83...
Commit: 7771793a560b839e6bc4083819bc5b192d94835a
Parent: 3951ca93204742d23b56f8d253230d33f322aad5
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Fri Jul 8 11:55:42 2016 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Fri Jul 8 14:34:36 2016 -0500
man: lvconvert changes
---
man/lvconvert.8.in | 32 +++++++++++++++-----------------
1 files changed, 15 insertions(+), 17 deletions(-)
diff --git a/man/lvconvert.8.in b/man/lvconvert.8.in
index 747bb7d..e85fe96 100644
--- a/man/lvconvert.8.in
+++ b/man/lvconvert.8.in
@@ -89,7 +89,7 @@ avoid the direct use of hidden LVs.
VG/StripedLV
.br
\[bu]
-Merge StripedLV into an LV when it is a previously split mirror
+Merge StripedLV into an LV when it is a previously split mirror.
.br
\[bu]
See --splitmirror.
@@ -167,7 +167,7 @@ Number
VG/RaidLV
.br
\[bu]
-Change the number of images in a raid1 RaidLV.
+Change the number of images in raid1 RaidLV.
.B lvconvert \-\-splitmirrors
Number
@@ -197,9 +197,6 @@ Replace failed PVs in RaidLV.
.B lvconvert \-\-replace
PV
-.B [\-\-replace
-PV
-.B ...]
VG/RaidLV
.br
\[bu]
@@ -207,6 +204,9 @@ Replace specific PV(s) in a raid* LV with another PV.
.br
\[bu]
The replacement PV can be optionally specified, see below.
+.br
+\[bu]
+Repeat to replace multiple: \-\-replace PV1 \-\-replace PV2 ...
.B lvconvert \-\-type snapshot
VG/RaidLV
@@ -333,6 +333,9 @@ VG/CachePoolLV
.br
\[bu]
Split the cache LV from CachePoolLV.
+.br
+\[bu]
+Equivalent to --splitcache on CacheLV.
.SS Operations on CacheLV with type cache:
@@ -587,8 +590,8 @@ This option is required when converting an LV to a \fBraid1\fP or
This option can be used alone to change the number of mirror images in an
existing \fBraid1\fP or \fBmirror\fP LV.
-The special case \fB\-\-mirrors 0\fP indicates a linear LV with no mirror
-images.
+The special case \fB\-\-mirrors 0\fP has been used historically to
+indicate a linear LV with no mirror images.
.
.HP
.BR \-n ,
@@ -709,17 +712,12 @@ still available in "<pool>_meta<n>" LV.
.BR \-\-replace
.IR PhysicalVolume
.br
-Remove the specified device (\fIPhysicalVolume\fP) and replace it with one
+Remove the specified device \fIPhysicalVolume\fP and replace it with one
that is available in the VG, or from a specific list of PVs specified on
the command line following the LV name. This option may be repeated multiple
-times depending on the RaidLV type. Maxima for raid1 are N-1 mirrors,
-for raid4/5 1 stripe, for raid6 2 stripes and for raid10 it is the number
-of stripes, i.e. one mirror in each mirror group. It is recommended to keep
-resilience whilst replacing PVs whenever possible, i.e. only replace a maximum
-of N-2 mirrors in a raid1 LV and 1 stripe in a raid6 LV at a time;
-this is not possible with raid4/5/10 LVs, because any single replaced PV
-will render the RaidLV non-resilient against another PV failure during replacement.
-.br
+times depending on the RaidLV type. See
+.BR lvmraid (7)
+for specific limits on device replacement for each raid level.
(This option only applies to \fBraid*\fP LV types.)
.
.HP
@@ -766,7 +764,7 @@ Also see
.IR Number
.br
Specifies the number of stripes in a striped LV. This is the number of
-physical volumes (devices) across which to spread a striped LV. Data that
+physical volumes (devices) a striped LV is spread across. Data that
appears sequential in the LV is spread (striped) across multiple devices
in units of the stripe size (see below). This does not apply to existing
allocated space, only newly allocated space can be striped.
7 years, 10 months
master - lvconvert: allow splitcache on hidden/used cache pool
by David Teigland
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=3951ca93204742...
Commit: 3951ca93204742d23b56f8d253230d33f322aad5
Parent: 39921284a03fd2d2c3f3ac22c3e69cba913494bf
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Fri Jul 8 14:08:55 2016 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Fri Jul 8 14:34:36 2016 -0500
lvconvert: allow splitcache on hidden/used cache pool
lvconvert --splitcache VG/CachePool_corig
Allow the split via the hidden/used cache pool for the time being,
since the new lvconvert code did intend to allow it, but was just
missing the exception in the list of hidden LVs that were allowed.
The preferred method for splitcache is to run it on the visible
cache LV, not the hidden cache pool. That may eventually become
the only method since we try to avoid running commands on
hidden LVs.
---
tools/lvconvert.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index 0009270..0319601 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -4372,6 +4372,7 @@ static int _lvconvert(struct cmd_context *cmd, struct logical_volume *lv,
!lv_is_cache_pool_data(lv) &&
!lv_is_thin_pool_metadata(lv) &&
!lv_is_thin_pool_data(lv) &&
+ !lv_is_used_cache_pool(lv) &&
!lv_is_raid_image(lv)) {
log_error("Cannot convert internal LV %s.", display_lvname(lv));
ret = 0;
7 years, 10 months
master - lvconvert: don't show aliases in error output
by David Teigland
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=39921284a03fd2...
Commit: 39921284a03fd2d2c3f3ac22c3e69cba913494bf
Parent: 5cd39f1dc4013d5d9b150abe544187413daeaac9
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Fri Jul 8 13:29:19 2016 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Fri Jul 8 14:34:36 2016 -0500
lvconvert: don't show aliases in error output
We want to consistently use the standard command form.
The aliases are now mentioned in the man page for reference.
---
tools/lvconvert.c | 24 ++++++++++++------------
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index ce858ae..0009270 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -4076,9 +4076,9 @@ static int _convert_thin_pool(struct cmd_context *cmd, struct logical_volume *lv
log_error("Operation not permitted on thin pool LV %s", display_lvname(lv));
log_error("Operations permitted on a thin pool LV are:\n"
- " --splitcache (operates on cache sub LV)\n"
- " --uncache (operates on cache sub LV)\n"
- " --type cache | --cache (operates on data sub LV)\n"
+ " --splitcache (operates on cache sub LV)\n"
+ " --uncache (operates on cache sub LV)\n"
+ " --type cache (operates on data sub LV)\n"
" --repair\n");
return 0;
}
@@ -4137,7 +4137,7 @@ static int _convert_cache_pool(struct cmd_context *cmd, struct logical_volume *l
log_error("Operation not permitted on cache pool LV %s", display_lvname(lv));
log_error("Operations permitted on a cache pool LV are:\n"
- " --splitcache (operates on cache LV)\n");
+ " --splitcache (operates on cache LV)\n");
return 0;
}
@@ -4255,9 +4255,9 @@ static int _convert_raid(struct cmd_context *cmd, struct logical_volume *lv,
" --merge\n"
" --repair\n"
" --replace\n"
- " --type snapshot | --snapshot\n"
- " --type thin | --thin\n"
- " --type cache | --cache\n"
+ " --type snapshot\n"
+ " --type thin\n"
+ " --type cache\n"
" --type thin-pool\n"
" --type cache-pool\n"
" --type raid*\n"
@@ -4316,13 +4316,13 @@ static int _convert_striped(struct cmd_context *cmd, struct logical_volume *lv,
log_error("Operation not permitted on striped or linear LV %s", display_lvname(lv));
log_error("Operations permitted on a striped or linear LV are:\n"
" --merge\n"
- " --type snapshot | --snapshot\n"
- " --type thin | --thin\n"
- " --type cache | --cache\n"
+ " --type snapshot\n"
+ " --type thin\n"
+ " --type cache\n"
" --type thin-pool\n"
" --type cache-pool\n"
- " --type mirror | --mirrors\n"
- " --type raid* | --mirrors\n");
+ " --type mirror\n"
+ " --type raid*\n");
return 0;
}
7 years, 10 months
master - dmstats: use canonical path when reporting errors
by Bryn Reeves
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=5cd39f1dc4013d...
Commit: 5cd39f1dc4013d5d9b150abe544187413daeaac9
Parent: 17cbcc85bdd31d6b1e0d3af8e43c39a8c58561b5
Author: Bryn M. Reeves <bmr(a)redhat.com>
AuthorDate: Fri Jul 8 17:06:35 2016 +0100
Committer: Bryn M. Reeves <bmr(a)redhat.com>
CommitterDate: Fri Jul 8 17:27:52 2016 +0100
dmstats: use canonical path when reporting errors
When a 'dmstats create --filemap' operation fails (e.g. during
open(2), close(2), or dm_stats_create_regions_from_fd()), use the
canonical version of the path. This avoids cryptic/confusing error
messages when symbolic links exist in the path argument given:
# findmnt /var/lib/libvirt/images -otarget,source
TARGET SOURCE
/var/lib/libvirt/images /dev/mapper/vg_hex-lv_images
# readlink /var/lib/libvirt/images/my.img
/boot/my.img
# dmstats create --filemap /var/lib/libvirt/images/my.img
Cannot map file: not a device-mapper device.
Could not create regions from file /var/lib/libvirt/images/my.img
Command failed
Using the canonical path the error is immediately obvious:
# dmstats create --filemap /var/lib/libvirt/images/my.img
Cannot map file: not a device-mapper device.
Could not create regions from file /boot/my.img
Command failed
---
tools/dmsetup.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/dmsetup.c b/tools/dmsetup.c
index eb7c83a..34e33d3 100644
--- a/tools/dmsetup.c
+++ b/tools/dmsetup.c
@@ -5034,7 +5034,7 @@ static int _stats_create_file(CMD_ARGS)
fd = open(abspath, O_RDONLY);
if (fd < 0) {
- log_error("Could not open %s for reading", path);
+ log_error("Could not open %s for reading", abspath);
goto bad;
}
@@ -5060,12 +5060,12 @@ static int _stats_create_file(CMD_ARGS)
bounds, alias);
if (close(fd))
- log_error("Error closing %s", path);
+ log_error("Error closing %s", abspath);
fd = -1;
if (!regions) {
- log_error("Could not create regions from file %s", path);
+ log_error("Could not create regions from file %s", abspath);
goto bad;
}
7 years, 10 months
master - doc: remove obsolete --statstype references from dmstats.8.in
by Bryn Reeves
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=17cbcc85bdd31d...
Commit: 17cbcc85bdd31d6b1e0d3af8e43c39a8c58561b5
Parent: 008c57714ae81986fbac0a2c5574b9891a481906
Author: Bryn M. Reeves <bmr(a)redhat.com>
AuthorDate: Thu Jul 7 15:23:07 2016 +0100
Committer: Bryn M. Reeves <bmr(a)redhat.com>
CommitterDate: Fri Jul 8 17:27:52 2016 +0100
doc: remove obsolete --statstype references from dmstats.8.in
---
man/dmstats.8.in | 39 +++++++++++----------------------------
1 files changed, 11 insertions(+), 28 deletions(-)
diff --git a/man/dmstats.8.in b/man/dmstats.8.in
index 96aca01..ce1368f 100644
--- a/man/dmstats.8.in
+++ b/man/dmstats.8.in
@@ -148,8 +148,6 @@ dmstats \(em device-mapper statistics management
. RI [ device_name ]
. RB [ \-\-histogram ]
. OPT_PROGRAMS
-. RB [ \-\-statstype
-. IR type_list ]
. RB [ \-\-units
. IR units ]
. OPT_OBJECTS
@@ -193,8 +191,6 @@ dmstats \(em device-mapper statistics management
. IR sort_fields ]
. RB [ \-S | \-\-select
. IR selection ]
-. RB [ \-\-statstype
-. IR type_list ]
. RB [ \-\-units
. IR units ]
. RB [ \-\-nosuffix ]
@@ -469,20 +465,6 @@ the \fB\-\-nogroup\fP option is given. When grouping is enabled a group
alias may be specified using the \fB\-\-alias\fP option.
.
.HP
-.BR \-\-statstype
-.IR type_list
-.br
-Filter the types of statistics object included in a report or listing
-according to the provided list. A report may include areas, regions,
-and user-defined groups of regions that report aggregate data for all
-group members.
-
-The list may be a single object type, a comma separated list of types,
-or the special value 'all'.
-
-The currently available object types are 'area', 'region' and 'group'.
-.
-.HP
.BR \-\-units
.RI [ units ] \c
.RB [ h | H | \c
@@ -578,8 +560,8 @@ By default regions that map a file are placed into a group and the
group alias is set to the basename of the file. This behaviour can be
overridden with the \fB\-\-alias\fP and \fB\-\-nogroup\fP options.
-To display only group information when listing and reporting, use the
-\fB\-\-statstype\fP option with the 'group' type.
+Use the \fB\-\-group\fP option to only display information for groups
+when listing and reporting.
.
.HP
.CMD_DELETE
@@ -635,13 +617,13 @@ regardless of region program ID values.
By default only regions and groups are included in list output. If
\fB\-v\fP or \fB\-\-verbose\fP is given the report will also include a
row of information for each configured group and for each area contained
-in each region displayed (regions that contain a single area are by
-default omitted from the verbose list since their properties are
-identical to the area that they contain - to view all regions regardless
-of the number of areas they contain use \fB\-\-statstype\fP).
+in each region displayed.
-Specific combinations of objects may be selected using the
-\fB\-\-statstype\fP option.
+Regions that contain a single area are by default omitted from the
+verbose list since their properties are identical to the area that they
+contain - to view all regions regardless of the number of areas present
+use \fB\-\-region\fP). To also view the areas contained within regions
+use \fB\-\-area\fP.
If \fB\-\-histogram\fP is given the report will include the bin count
and latency boundary values for any configured histograms.
@@ -668,8 +650,9 @@ values and latency boundaries.
If the \fB\-\-relative\fP is used the default histogram field displays
bin values as a percentage of the total number of I/Os.
-Object types (areas, regions and groups) are selected using the
-\fB\-\-statstype\fP option.
+Object types (areas, regions and groups) to include in the report are
+selected using the \fB\-\-area\fP, \fB\-\-region\fP, and \fB\-\-group\fP
+options.
.
.HP
.CMD_UNGROUP
7 years, 10 months
master - WHATS_NEW_DM: add --segments grouping and resource leak fix
by Bryn Reeves
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=008c57714ae819...
Commit: 008c57714ae81986fbac0a2c5574b9891a481906
Parent: 6cb0c7bb5c41c4fa2bdc1604e86154efa946c600
Author: Bryn M. Reeves <bmr(a)redhat.com>
AuthorDate: Thu Jul 7 14:37:49 2016 +0100
Committer: Bryn M. Reeves <bmr(a)redhat.com>
CommitterDate: Fri Jul 8 17:27:52 2016 +0100
WHATS_NEW_DM: add --segments grouping and resource leak fix
---
WHATS_NEW_DM | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 86d000b..40452a1 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,7 @@
Version 1.02.131 -
================================
+ Automatically group regions with 'create --segments' unless --nogroup.
+ Fix resource leak when deleting the first member of a group.
Allow --bounds with 'create --filemap' for dmstats.
Enable creation of filemap regions with histograms.
Enable histogram aggregation for regions with more than one area.
7 years, 10 months