master - tests: update lvconvert test
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=746f8af2a836e6...
Commit: 746f8af2a836e662e5588a37feb29c27ed02261b
Parent: 0d5b9deff21991f0b26240ae4395ee12e76096c5
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Mar 14 23:22:19 2016 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 14 23:46:08 2016 +0100
tests: update lvconvert test
---
test/shell/lvconvert-repair-cache.sh | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/test/shell/lvconvert-repair-cache.sh b/test/shell/lvconvert-repair-cache.sh
index 9ef8716..60b0b5d 100644
--- a/test/shell/lvconvert-repair-cache.sh
+++ b/test/shell/lvconvert-repair-cache.sh
@@ -61,6 +61,10 @@ lvconvert -H --cachemode writethrough --cachepool $vg/cpool $lv1
aux disable_dev "$dev2"
+# Deactivate before remove
+# FIXME: handle this while LV is alive
+lvchange -an $vg/$lv1
+
# Check it is prompting for confirmation
not lvconvert --uncache $vg/$lv1
# --yes to drop when Check its prompting
@@ -72,6 +76,9 @@ lvconvert --yes --uncache $vg/$lv1
#lvchange -ay $vg
aux enable_dev "$dev2"
+
+# FIXME: temporary workaround
+lvcreate -L1 -n $lv5 $vg
lvremove -ff $vg
##########################
@@ -92,7 +99,7 @@ lvs -a -o+seg_pe_ranges,cachemode $vg
sync
# Seriously damage cache metadata
-aux error_dev "$dev1" 2054:2
+aux error_dev "$dev1" 2054:2
# Here we usually for the 1st. notice needs_check
check lv_attr_bit state $vg/$lv1 "c"
7 years, 9 months
master - tests: use own PID path for lvmetad checking
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=0d5b9deff21991...
Commit: 0d5b9deff21991f0b26240ae4395ee12e76096c5
Parent: 7daba90fa3c2cec085170b1c18f63d7877e483da
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Mar 14 23:16:45 2016 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 14 23:45:45 2016 +0100
tests: use own PID path for lvmetad checking
Do not try to check PID of running lvmetad and use own path.
---
test/lib/inittest.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/test/lib/inittest.sh b/test/lib/inittest.sh
index a2dcf01..a453ee6 100644
--- a/test/lib/inittest.sh
+++ b/test/lib/inittest.sh
@@ -114,6 +114,7 @@ if test -n "$LVM_TEST_LVMETAD" ; then
aux prepare_lvmetad
else
# lvmetad prepares its own lvmconf
+ export LVM_LVMETAD_PIDFILE="$TESTDIR/non-existing-file"
aux lvmconf
aux prepare_clvmd
fi
7 years, 9 months
master - lvconvert: fix error path test
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=7daba90fa3c2ce...
Commit: 7daba90fa3c2cec085170b1c18f63d7877e483da
Parent: a39563c0b08a281f170f7e70ec571aa6ef2d9147
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Mar 14 23:19:22 2016 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Mar 14 23:37:42 2016 +0100
lvconvert: fix error path test
lvremove_single toollib function returns
ECMD_FAILED or ECMD_PROCESSED.
---
WHATS_NEW | 1 +
tools/lvconvert.c | 2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/WHATS_NEW b/WHATS_NEW
index 50cf318..23d8787 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.02.147 -
==================================
+ Fix test for lvremove failure in lvconvert --uncache (2.02.146).
Version 2.02.146 - 11th March 2016
==================================
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index d80292a..f7a3df6 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -2043,7 +2043,7 @@ static int _lvconvert_uncache(struct cmd_context *cmd,
}
}
- if (!lvremove_single(cmd, remove_lv, NULL))
+ if (lvremove_single(cmd, remove_lv, NULL) != ECMD_PROCESSED)
return_0;
if (remove_lv != lv)
7 years, 9 months
master - report: Use default vg_name field width too.
by Alasdair Kergon
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=a39563c0b08a28...
Commit: a39563c0b08a281f170f7e70ec571aa6ef2d9147
Parent: a78e6960704a42ceadcda89b624137cb7bb7c72e
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Mon Mar 14 09:30:51 2016 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Mon Mar 14 09:30:51 2016 +0000
report: Use default vg_name field width too.
---
lib/report/columns.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/report/columns.h b/lib/report/columns.h
index 1abc4c8..4439047 100644
--- a/lib/report/columns.h
+++ b/lib/report/columns.h
@@ -149,7 +149,7 @@ FIELD(PVS, pv, BIN, "PInUse", id, 0, pvinuse, pv_in_use, "Set if PV is used.", 0
FIELD(VGS, vg, STR, "Fmt", cmd, 0, vgfmt, vg_fmt, "Type of metadata.", 0)
FIELD(VGS, vg, STR, "VG UUID", id, 38, uuid, vg_uuid, "Unique identifier.", 0)
-FIELD(VGS, vg, STR, "VG", name, 4, string, vg_name, "Name.", 0)
+FIELD(VGS, vg, STR, "VG", name, 0, string, vg_name, "Name.", 0)
FIELD(VGS, vg, STR, "Attr", cmd, 5, vgstatus, vg_attr, "Various attributes - see man page.", 0)
FIELD(VGS, vg, STR, "VPerms", cmd, 10, vgpermissions, vg_permissions, "VG permissions.", 0)
FIELD(VGS, vg, BIN, "Extendable", cmd, 0, vgextendable, vg_extendable, "Set if VG is extendable.", 0)
7 years, 9 months
v2_02_146 annotated tag has been created
by Alasdair Kergon
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=eddd448869573c...
Commit: eddd448869573ca03e49c009e80cd4440fb0193f
Parent: 0000000000000000000000000000000000000000
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: 2016-03-11 00:19 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: 2016-03-11 00:19 +0000
annotated tag: v2_02_146 has been created
at eddd448869573ca03e49c009e80cd4440fb0193f (tag)
tagging 2159a1429d65adb824e67a1577625663d910516e (commit)
replaces v2_02_145
Release 2.02.146.
Another development checkpoint - all recent API changes are still not frozen.
67 files changed, 985 insertions(+), 365 deletions(-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
iEYEABECAAYFAlbiDyAACgkQIoGRwVZ+LBcntwCg804fiwvLyCirQp1bAu/L6zNj
9OoAn25XIxRQzSELiLobHEHRrG68QCBC
=LtBU
-----END PGP SIGNATURE-----
Alasdair G Kergon (3):
post-release
report: Tidy some field names, widths and headings.
pre-release
David Teigland (6):
dbus: add notification from commands
vgscan: add --notifydbus to send a notification
toollib: always process in use pvs
remove unused define
pvchange, pvresize: move exported VG check
man: vgcreate shared
Heinz Mauelshagen (1):
raid_manip: allow for raid leg to be replaced when not both data and metadata image are on pvs
Marian Csontos (7):
test: Update kernels to skip thin-flags with
test: Move udev-lvmlockd-test to check_system
test: Comment out incorrect lockd setup
spec: Add missing dependency for dbusd
test: Add prepare_lvmdbusd
spec: Fix gobject dependency
test: Remove work-in-progress code from dbustest
Ondrej Kozina (2):
test: fix inverted condition
test: skip unrelated tests while testing lvmpolld
Peter Rajnoha (2):
coverity: fix possible resource leak in _print_historical_lv function
metadata: do not issue warning message about PV dev size being 0 when the device has gone just after VG read
Tony Asleson (2):
lvmdbus: Fix exception during exception handling
lvmdbus: Fix deprecated warnings for GObject use
Zdenek Kabelac (14):
libdm: parse more info from cache status
lvconvert: uncache handles missing PV
cache: check for cache fail during flush
lvconvert: improve vg parameter parsing
makefiles: avoid using vpath for rules files
man: updates
man: drop extra braces
topology: handle reported sizes smaller then sector
gcc: cast time_t to 64bit
cleanup: add backtrace
cleanup: reoder lines
cleanup: display_lvname
tests: uncache with missing PV
lvconvert: update --help
7 years, 9 months
master - post-release
by Alasdair Kergon
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=a78e6960704a42...
Commit: a78e6960704a42ceadcda89b624137cb7bb7c72e
Parent: 2159a1429d65adb824e67a1577625663d910516e
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Fri Mar 11 00:21:53 2016 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Fri Mar 11 00:21:53 2016 +0000
post-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 3 +++
WHATS_NEW_DM | 3 +++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/VERSION b/VERSION
index dc1b9ea..f56f978 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.02.146(2)-git (2016-03-11)
+2.02.147(2)-git (2016-03-11)
diff --git a/VERSION_DM b/VERSION_DM
index 1678ddf..c66683d 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.120-git (2016-03-11)
+1.02.121-git (2016-03-11)
diff --git a/WHATS_NEW b/WHATS_NEW
index 27abb4a..50cf318 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,3 +1,6 @@
+Version 2.02.147 -
+==================================
+
Version 2.02.146 - 11th March 2016
==================================
More man page cleanups in lvconvert.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index ec27a19..9ddf5e1 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,3 +1,6 @@
+Version 1.02.121 -
+==================================
+
Version 1.02.120 - 11th March 2016
==================================
Improve parsing of cache status and report Fail, Error, needs_check, ro.
7 years, 9 months
master - pre-release
by Alasdair Kergon
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=2159a1429d65ad...
Commit: 2159a1429d65adb824e67a1577625663d910516e
Parent: 6807eb88634fd0db95cdccbbc65570b2d96c989a
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Fri Mar 11 00:19:16 2016 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Fri Mar 11 00:19:16 2016 +0000
pre-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 4 +-
WHATS_NEW_DM | 4 +-
conf/example.conf.in | 14 ++++++-
configure | 107 ++++++++++++++++++++++++++++++++++++++++++++++++
include/configure.h.in | 3 +
lib/device/dev-type.c | 2 +-
8 files changed, 130 insertions(+), 8 deletions(-)
diff --git a/VERSION b/VERSION
index 4b10296..dc1b9ea 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.02.146(2)-git (2016-03-04)
+2.02.146(2)-git (2016-03-11)
diff --git a/VERSION_DM b/VERSION_DM
index 3c381cc..1678ddf 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.120-git (2016-03-04)
+1.02.120-git (2016-03-11)
diff --git a/WHATS_NEW b/WHATS_NEW
index 685cdad..27abb4a 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,5 @@
-Version 2.02.146 -
-=================================
+Version 2.02.146 - 11th March 2016
+==================================
More man page cleanups in lvconvert.
Fix makefile vpath in /udev when generating udev rules files.
Another attempt to improve VG name parsing for lvconvert (2.02.144).
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 274d1b9..ec27a19 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,5 @@
-Version 1.02.120 -
-=================================
+Version 1.02.120 - 11th March 2016
+==================================
Improve parsing of cache status and report Fail, Error, needs_check, ro.
Version 1.02.119 - 4th March 2016
diff --git a/conf/example.conf.in b/conf/example.conf.in
index 975f514..a21dd96 100644
--- a/conf/example.conf.in
+++ b/conf/example.conf.in
@@ -525,7 +525,7 @@ log {
# debug output if the class is listed here. Classes currently
# available: memory, devices, activation, allocation, lvmetad,
# metadata, cache, locking, lvmpolld. Use "all" to see everything.
- debug_classes = [ "memory", "devices", "activation", "allocation", "lvmetad", "metadata", "cache", "locking", "lvmpolld" ]
+ debug_classes = [ "memory", "devices", "activation", "allocation", "lvmetad", "metadata", "cache", "locking", "lvmpolld", "dbus" ]
}
# Configuration section backup.
@@ -1015,6 +1015,12 @@ global {
# and to use its own control group. When this option is disabled, LVM
# commands will supervise long running operations by forking themselves.
use_lvmpolld = @DEFAULT_USE_LVMPOLLD@
+
+ # Configuration option global/notify_dbus.
+ # Enable D-Bus notification from LVM commands.
+ # When enabled, an LVM command that changes PVs, changes VG metadata,
+ # or changes the activation state of an LV will send a notification.
+ notify_dbus = 1
}
# Configuration section activation.
@@ -1840,6 +1846,12 @@ activation {
# Use brackets [] to mark hidden devices.
# This configuration option has an automatic default value.
# mark_hidden_devices = 1
+
+ # Configuration option report/two_word_unknown_device.
+ # Use the two words 'unknown device' in place of '[unknown]'.
+ # This is displayed when the device for a PV is not known.
+ # This configuration option has an automatic default value.
+ # two_word_unknown_device = 0
# }
# Configuration section dmeventd.
diff --git a/configure b/configure
index 75967d7..eb55243 100755
--- a/configure
+++ b/configure
@@ -735,6 +735,7 @@ CLDWHOLEARCHIVE
CLDNOWHOLEARCHIVE
CLDFLAGS
CACHE
+BUILD_NOTIFYDBUS
BUILD_LOCKDDLM
BUILD_LOCKDSANLOCK
BUILD_LVMLOCKD
@@ -767,6 +768,8 @@ SYSTEMD_LIBS
SYSTEMD_CFLAGS
BLKID_LIBS
BLKID_CFLAGS
+NOTIFY_DBUS_LIBS
+NOTIFY_DBUS_CFLAGS
LOCKD_DLM_LIBS
LOCKD_DLM_CFLAGS
LOCKD_SANLOCK_LIBS
@@ -954,6 +957,7 @@ enable_use_lvmetad
with_lvmetad_pidfile
enable_use_lvmpolld
with_lvmpolld_pidfile
+enable_notify_dbus
enable_blkid_wiping
enable_udev_systemd_background_jobs
enable_udev_sync
@@ -1039,6 +1043,8 @@ LOCKD_SANLOCK_CFLAGS
LOCKD_SANLOCK_LIBS
LOCKD_DLM_CFLAGS
LOCKD_DLM_LIBS
+NOTIFY_DBUS_CFLAGS
+NOTIFY_DBUS_LIBS
BLKID_CFLAGS
BLKID_LIBS
SYSTEMD_CFLAGS
@@ -1685,6 +1691,7 @@ Optional Features:
--disable-use-lvmlockd disable usage of LVM lock daemon
--disable-use-lvmetad disable usage of LVM Metadata Daemon
--disable-use-lvmpolld disable usage of LVM Poll Daemon
+ --enable-notify-dbus enable LVM notification using dbus
--disable-blkid_wiping disable libblkid detection of signatures when wiping
and use native code instead
--disable-udev-systemd-background-jobs
@@ -1877,6 +1884,10 @@ Some influential environment variables:
C compiler flags for LOCKD_DLM, overriding pkg-config
LOCKD_DLM_LIBS
linker flags for LOCKD_DLM, overriding pkg-config
+ NOTIFY_DBUS_CFLAGS
+ C compiler flags for NOTIFY_DBUS, overriding pkg-config
+ NOTIFY_DBUS_LIBS
+ linker flags for NOTIFY_DBUS, overriding pkg-config
BLKID_CFLAGS
C compiler flags for BLKID, overriding pkg-config
BLKID_LIBS linker flags for BLKID, overriding pkg-config
@@ -11817,6 +11828,101 @@ _ACEOF
################################################################################
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether to build notifydbus" >&5
+$as_echo_n "checking whether to build notifydbus... " >&6; }
+# Check whether --enable-notify-dbus was given.
+if test "${enable_notify_dbus+set}" = set; then :
+ enableval=$enable_notify_dbus; NOTIFYDBUS=$enableval
+fi
+
+{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $NOTIFYDBUS" >&5
+$as_echo "$NOTIFYDBUS" >&6; }
+
+BUILD_NOTIFYDBUS=$NOTIFYDBUS
+
+if test "$BUILD_NOTIFYDBUS" = yes; then
+
+$as_echo "#define NOTIFYDBUS_SUPPORT 1" >>confdefs.h
+
+ LIBS="-lsystemd $LIBS"
+fi
+
+################################################################################
+if test "$BUILD_NOTIFYDBUS" = yes; then
+
+pkg_failed=no
+{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for NOTIFY_DBUS" >&5
+$as_echo_n "checking for NOTIFY_DBUS... " >&6; }
+
+if test -n "$NOTIFY_DBUS_CFLAGS"; then
+ pkg_cv_NOTIFY_DBUS_CFLAGS="$NOTIFY_DBUS_CFLAGS"
+ elif test -n "$PKG_CONFIG"; then
+ if test -n "$PKG_CONFIG" && \
+ { { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists --print-errors \"systemd >= 221\""; } >&5
+ ($PKG_CONFIG --exists --print-errors "systemd >= 221") 2>&5
+ ac_status=$?
+ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
+ test $ac_status = 0; }; then
+ pkg_cv_NOTIFY_DBUS_CFLAGS=`$PKG_CONFIG --cflags "systemd >= 221" 2>/dev/null`
+ test "x$?" != "x0" && pkg_failed=yes
+else
+ pkg_failed=yes
+fi
+ else
+ pkg_failed=untried
+fi
+if test -n "$NOTIFY_DBUS_LIBS"; then
+ pkg_cv_NOTIFY_DBUS_LIBS="$NOTIFY_DBUS_LIBS"
+ elif test -n "$PKG_CONFIG"; then
+ if test -n "$PKG_CONFIG" && \
+ { { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists --print-errors \"systemd >= 221\""; } >&5
+ ($PKG_CONFIG --exists --print-errors "systemd >= 221") 2>&5
+ ac_status=$?
+ $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
+ test $ac_status = 0; }; then
+ pkg_cv_NOTIFY_DBUS_LIBS=`$PKG_CONFIG --libs "systemd >= 221" 2>/dev/null`
+ test "x$?" != "x0" && pkg_failed=yes
+else
+ pkg_failed=yes
+fi
+ else
+ pkg_failed=untried
+fi
+
+
+
+if test $pkg_failed = yes; then
+ { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+$as_echo "no" >&6; }
+
+if $PKG_CONFIG --atleast-pkgconfig-version 0.20; then
+ _pkg_short_errors_supported=yes
+else
+ _pkg_short_errors_supported=no
+fi
+ if test $_pkg_short_errors_supported = yes; then
+ NOTIFY_DBUS_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors --cflags --libs "systemd >= 221" 2>&1`
+ else
+ NOTIFY_DBUS_PKG_ERRORS=`$PKG_CONFIG --print-errors --cflags --libs "systemd >= 221" 2>&1`
+ fi
+ # Put the nasty error message in config.log where it belongs
+ echo "$NOTIFY_DBUS_PKG_ERRORS" >&5
+
+ $bailout
+elif test $pkg_failed = untried; then
+ { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
+$as_echo "no" >&6; }
+ $bailout
+else
+ NOTIFY_DBUS_CFLAGS=$pkg_cv_NOTIFY_DBUS_CFLAGS
+ NOTIFY_DBUS_LIBS=$pkg_cv_NOTIFY_DBUS_LIBS
+ { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
+$as_echo "yes" >&6; }
+ HAVE_NOTIFY_DBUS=yes
+fi
+fi
+
+################################################################################
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether to enable libblkid detection of signatures when wiping" >&5
$as_echo_n "checking whether to enable libblkid detection of signatures when wiping... " >&6; }
@@ -15225,6 +15331,7 @@ LVM_LIBAPI=`echo "$VER" | $AWK -F '[()]' '{print $2}'`
+
################################################################################
ac_config_files="$ac_config_files Makefile make.tmpl daemons/Makefile daemons/clvmd/Makefile daemons/cmirrord/Makefile daemons/dmeventd/Makefile daemons/dmeventd/libdevmapper-event.pc daemons/dmeventd/plugins/Makefile daemons/dmeventd/plugins/lvm2/Makefile daemons/dmeventd/plugins/raid/Makefile daemons/dmeventd/plugins/mirror/Makefile daemons/dmeventd/plugins/snapshot/Makefile daemons/dmeventd/plugins/thin/Makefile daemons/lvmdbusd/Makefile daemons/lvmdbusd/path.py daemons/lvmetad/Makefile daemons/lvmpolld/Makefile daemons/lvmlockd/Makefile conf/Makefile conf/example.conf conf/lvmlocal.conf conf/command_profile_template.profile conf/metadata_profile_template.profile include/.symlinks include/Makefile lib/Makefile lib/format1/Makefile lib/format_pool/Makefile lib/locking/Makefile lib/mirror/Makefile lib/replicator/Makefile include/lvm-version.h lib/raid/Makefile lib/snapshot/Makefile lib/thin/Makefile lib/cache_segtype/Makefile libdaemon/Makefile libdaemon/client/Makefile lib
daemon/server/Makefile libdm/Makefile libdm/libdevmapper.pc liblvm/Makefile liblvm/liblvm2app.pc man/Makefile po/Makefile python/Makefile python/setup.py scripts/blkdeactivate.sh scripts/blk_availability_init_red_hat scripts/blk_availability_systemd_red_hat.service scripts/clvmd_init_red_hat scripts/cmirrord_init_red_hat scripts/com.redhat.lvmdbus1.service scripts/dm_event_systemd_red_hat.service scripts/dm_event_systemd_red_hat.socket scripts/lvm2_cluster_activation_red_hat.sh scripts/lvm2_cluster_activation_systemd_red_hat.service scripts/lvm2_clvmd_systemd_red_hat.service scripts/lvm2_cmirrord_systemd_red_hat.service scripts/lvm2_lvmdbusd_systemd_red_hat.service scripts/lvm2_lvmetad_init_red_hat scripts/lvm2_lvmetad_systemd_red_hat.service scripts/lvm2_lvmetad_systemd_red_hat.socket scripts/lvm2_lvmpolld_init_red_hat scripts/lvm2_lvmpolld_systemd_red_hat.service scripts/lvm2_lvmpolld_systemd_red_hat.socket scripts/lvm2_lvmlockd_systemd_red_hat.service scripts/lvm2_lvmlock
ing_systemd_red_hat.service scripts/lvm2_monitoring_init_red_hat scripts/lvm2_monitoring_systemd_red_hat.service scripts/lvm2_pvscan_systemd_red_hat@.service scripts/lvm2_tmpfiles_red_hat.conf scripts/Makefile test/Makefile test/api/Makefile test/unit/Makefile tools/Makefile udev/Makefile unit-tests/datastruct/Makefile unit-tests/regex/Makefile unit-tests/mm/Makefile"
diff --git a/include/configure.h.in b/include/configure.h.in
index 1681af0..d94d55d 100644
--- a/include/configure.h.in
+++ b/include/configure.h.in
@@ -631,6 +631,9 @@
/* The path to 'modprobe', if available. */
#undef MODPROBE_CMD
+/* Define to 1 to include code that uses dbus notification. */
+#undef NOTIFYDBUS_SUPPORT
+
/* Define to 1 to enable O_DIRECT support. */
#undef O_DIRECT_SUPPORT
diff --git a/lib/device/dev-type.c b/lib/device/dev-type.c
index 689809a..f9f1418 100644
--- a/lib/device/dev-type.c
+++ b/lib/device/dev-type.c
@@ -854,7 +854,7 @@ static unsigned long _dev_topology_attribute(struct dev_types *dt,
result = value >> SECTOR_SHIFT;
if (!result && value) {
- log_warn("WARNING: Device %s: %s is %lu and is unexpectedly less then sector.",
+ log_warn("WARNING: Device %s: %s is %lu and is unexpectedly less than sector.",
dev_name(dev), attribute, value);
result = 1;
}
7 years, 9 months
master - man: vgcreate shared
by David Teigland
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=6807eb88634fd0...
Commit: 6807eb88634fd0db95cdccbbc65570b2d96c989a
Parent: 0f10823ec910c0a6015b20580f5aa26f209cea04
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Thu Mar 10 15:40:37 2016 -0600
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Thu Mar 10 15:40:37 2016 -0600
man: vgcreate shared
---
man/vgcreate.8.in | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/man/vgcreate.8.in b/man/vgcreate.8.in
index 92ef06c..22feedf 100644
--- a/man/vgcreate.8.in
+++ b/man/vgcreate.8.in
@@ -132,7 +132,8 @@ The 2.4 kernel has a limitation of 2TiB per block device.
.B \-\-shared
Create a shared VG using lvmlockd. lvmlockd will select lock type sanlock
or dlm depending on which lock manager is running. This allows multiple
-hosts to share a VG on shared devices. See
+hosts to share a VG on shared devices. lvmlockd and a lock manager must
+be configured and running. See
.BR lvmlockd (8).
.TP
7 years, 9 months
master - pvchange, pvresize: move exported VG check
by David Teigland
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=0f10823ec910c0...
Commit: 0f10823ec910c0a6015b20580f5aa26f209cea04
Parent: 9f4451193b8db4bd9c894248f50da9319704293e
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Thu Mar 10 13:28:47 2016 -0600
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Thu Mar 10 13:37:42 2016 -0600
pvchange, pvresize: move exported VG check
Allow pvchange and pvresize to process exported VGs,
and have them check for the exported state in their
single function.
Previously, the exported VG state would trigger a
failure in vg_read()/ignore_vg() because the VGs are
being read with READ_FOR_UPDATE. Because these commands
read all VGs to search for the intended PVs, any
exported VG would trigger a failure, even if it was
not related to the intended PV.
---
tools/pvchange.c | 7 ++++++-
tools/pvresize.c | 8 ++++++--
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/tools/pvchange.c b/tools/pvchange.c
index 5f99016..e103ebe 100644
--- a/tools/pvchange.c
+++ b/tools/pvchange.c
@@ -35,6 +35,11 @@ static int _pvchange_single(struct cmd_context *cmd, struct volume_group *vg,
params->total++;
+ if (vg && vg_is_exported(vg)) {
+ log_error("Volume group %s is exported", vg->name);
+ goto bad;
+ }
+
/* If in a VG, must change using volume group. */
if (!is_orphan(pv)) {
if (tagargs && !(vg->fid->fmt->features & FMT_TAGS)) {
@@ -230,7 +235,7 @@ int pvchange(struct cmd_context *cmd, int argc, char **argv)
set_pv_notify(cmd);
- ret = process_each_pv(cmd, argc, argv, NULL, 0, READ_FOR_UPDATE, handle, _pvchange_single);
+ ret = process_each_pv(cmd, argc, argv, NULL, 0, READ_FOR_UPDATE | READ_ALLOW_EXPORTED, handle, _pvchange_single);
if (!argc)
unlock_vg(cmd, VG_GLOBAL);
diff --git a/tools/pvresize.c b/tools/pvresize.c
index 1312290..9931cc6 100644
--- a/tools/pvresize.c
+++ b/tools/pvresize.c
@@ -36,6 +36,11 @@ static int _pvresize_single(struct cmd_context *cmd,
}
params->total++;
+ if (vg && vg_is_exported(vg)) {
+ log_error("Volume group %s is exported", vg->name);
+ return ECMD_FAILED;
+ }
+
/*
* Needed to change a property on an orphan PV.
* i.e. the global lock is only needed for orphans.
@@ -89,8 +94,7 @@ int pvresize(struct cmd_context *cmd, int argc, char **argv)
handle->custom_handle = ¶ms;
- ret = process_each_pv(cmd, argc, argv, NULL, 0, READ_FOR_UPDATE, handle,
- _pvresize_single);
+ ret = process_each_pv(cmd, argc, argv, NULL, 0, READ_FOR_UPDATE | READ_ALLOW_EXPORTED, handle, _pvresize_single);
log_print_unless_silent("%d physical volume(s) resized / %d physical volume(s) "
"not resized", params.done, params.total - params.done);
7 years, 9 months
master - lvconvert: update --help
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=9f4451193b8db4...
Commit: 9f4451193b8db4bd9c894248f50da9319704293e
Parent: 5bfc0edd12d1f4e31fcd3813edd8de99816ec6c3
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Sat Mar 5 21:02:30 2016 +0100
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Mar 10 18:38:54 2016 +0100
lvconvert: update --help
Use <> around user entered option parameters to make it visually
different (just like we use Italic style in man page).
TODO:
In the future we should consistently provide such notation and
possibly generate it automagically from some internal data structures.
Preferably for man pages as well so we report actual set of supported
options.
---
tools/commands.h | 42 +++++++++++++++++++++---------------------
1 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/tools/commands.h b/tools/commands.h
index f676bbe..aba5b40 100644
--- a/tools/commands.h
+++ b/tools/commands.h
@@ -197,28 +197,28 @@ xx(lvchange,
test_ARG, writebehind_ARG, writemostly_ARG, zero_ARG)
#define COMMON_OPTS \
- "\t[--commandprofile ProfileName] [-d|--debug] [-h|-?|--help]\n" \
+ "\t[--commandprofile <ProfileName>] [-d|--debug] [-h|-?|--help]\n" \
"\t[--noudevsync] [-t|--test] [-v|--verbose] [--version] [-y|--yes]\n"
xx(lvconvert,
"Change logical volume layout",
0,
"lvconvert "
- "[-m|--mirrors Mirrors [{--mirrorlog {disk|core|mirrored}|--corelog}]]\n"
- "\t[--type SegmentType]\n"
+ "[-m|--mirrors <Mirrors> [--mirrorlog {disk|core|mirrored}|--corelog]]\n"
+ "\t[--type <SegmentType>]\n"
"\t[--repair [--use-policies]]\n"
"\t[--replace PhysicalVolume]\n"
- "\t[-R|--regionsize MirrorLogRegionSize]\n"
- "\t[--alloc AllocationPolicy]\n"
+ "\t[-R|--regionsize <MirrorLogRegionSize>]\n"
+ "\t[--alloc <AllocationPolicy>]\n"
"\t[-b|--background]\n"
"\t[-f|--force]\n"
- "\t[-i|--interval seconds]\n"
- "\t[--stripes Stripes [-I|--stripesize StripeSize]]\n"
+ "\t[-i|--interval <Seconds>]\n"
+ "\t[--stripes <Stripes> [-I|--stripesize <StripeSize>]]\n"
COMMON_OPTS
"\tLogicalVolume[Path] [PhysicalVolume[Path]...]\n\n"
"lvconvert "
- "[--splitmirrors Images --trackchanges]\n"
+ "[--splitmirrors <Images> --trackchanges]\n"
"\t[--splitmirrors Images --name SplitLogicalVolumeName]\n"
COMMON_OPTS
"\tLogicalVolume[Path] [SplittablePhysicalVolume[Path]...]\n\n"
@@ -246,7 +246,7 @@ xx(lvconvert,
"lvconvert "
"[--type snapshot|-s|--snapshot]\n"
- "\t[-c|--chunksize]\n"
+ "\t[-c|--chunksize <ChunkSize>]\n"
"\t[-Z|--zero {y|n}]\n"
COMMON_OPTS
"\tOriginalLogicalVolume[Path] SnapshotLogicalVolume[Path]\n\n"
@@ -254,20 +254,20 @@ xx(lvconvert,
"lvconvert "
"--merge\n"
"\t[-b|--background]\n"
- "\t[-i|--interval seconds]\n"
+ "\t[-i|--interval <Seconds>]\n"
COMMON_OPTS
"\tLogicalVolume[Path]\n\n"
"lvconvert "
"[--type thin[-pool]|-T|--thin]\n"
"\t[--thinpool ThinPoolLogicalVolume[Path]]\n"
- "\t[--chunksize size]\n"
+ "\t[--chunksize <ChunkSize>]\n"
"\t[--discards {ignore|nopassdown|passdown}]\n"
"\t[--poolmetadataspare {y|n}]\n"
- "\t[{--poolmetadata ThinMetadataLogicalVolume[Path] |\n"
- "\t --poolmetadatasize size}]\n"
- "\t[-r|--readahead ReadAheadSectors|auto|none]\n"
- "\t[--stripes Stripes [-I|--stripesize StripeSize]]]\n"
+ "\t[--poolmetadata ThinMetadataLogicalVolume[Path] |\n"
+ "\t --poolmetadatasize <MetadataSize>]\n"
+ "\t[-r|--readahead <ReadAheadSectors>|auto|none]\n"
+ "\t[--stripes <Stripes> [-I|--stripesize <StripeSize>]]]\n"
"\t[--originname NewExternalOriginVolumeName]]\n"
"\t[-Z|--zero {y|n}]\n"
COMMON_OPTS
@@ -276,13 +276,13 @@ xx(lvconvert,
"lvconvert "
"[--type cache[-pool]|-H|--cache]\n"
"\t[--cachepool CacheDataLogicalVolume[Path]]\n"
- "\t[--cachemode CacheMode]\n"
- "\t[--cachepolicy policy]\n"
- "\t[--cachesettings key=value]\n"
- "\t[--chunksize size]\n"
+ "\t[--cachemode <CacheMode>]\n"
+ "\t[--cachepolicy <CachePolicy>]\n"
+ "\t[--cachesettings <Key>=<Value>]\n"
+ "\t[--chunksize <ChunkSize>]\n"
+ "\t[--poolmetadata CacheMetadataLogicalVolume[Path] |\n"
+ "\t --poolmetadatasize <MetadataSize>]\n"
"\t[--poolmetadataspare {y|n}]]\n"
- "\t[{--poolmetadata CacheMetadataLogicalVolume[Path] |\n"
- "\t --poolmetadatasize size}]\n"
COMMON_OPTS
"\t[Cache|CacheDataPool]LogicalVolume[Path] [PhysicalVolumePath...]\n\n",
7 years, 9 months