Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=5cd4d46f303ecf52…
Commit: 5cd4d46f303ecf5212b5de0eb96c0a356453d289
Parent: 06346eab849b272bcd99196a9b594da29abdb19a
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Thu Jan 14 13:47:44 2016 -0600
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Mon Jan 18 09:36:55 2016 -0600
Revert "Revert "process_each_pv: remove unnecessary workaround""
This reverts commit 6d09c8c2c45ea1dea243134b8badc841a87cc979.
Try again to remove the workaround.
---
tools/toollib.c | 17 +----------------
1 files changed, 1 insertions(+), 16 deletions(-)
diff --git a/tools/toollib.c b/tools/toollib.c
index 728e61d..97cc1bf 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -3033,7 +3033,6 @@ static int _process_pvs_in_vg(struct cmd_context *cmd,
const char *pv_name;
int selected;
int process_pv;
- int dev_found;
int ret_max = ECMD_PROCESSED;
int ret = 0;
@@ -3087,21 +3086,7 @@ static int _process_pvs_in_vg(struct cmd_context *cmd,
else
log_very_verbose("Processing PV %s in VG %s.", pv_name, vg->name);
- dev_found = _device_list_remove(all_devices, pv->dev);
-
- /*
- * FIXME PVs with no mdas may turn up in an orphan VG when
- * not using lvmetad as well as their correct VG. They
- * will be missing from all_devices the second time
- * around but must not be processed twice or trigger a message.
- *
- * Missing PVs will also need processing even though they are
- * not present in all_devices.
- */
- if (!dev_found && !is_missing_pv(pv)) {
- log_verbose("Skipping PV %s in VG %s: not in device list.", pv_name, vg->name);
- continue;
- }
+ _device_list_remove(all_devices, pv->dev);
if (!skip) {
ret = process_single_pv(cmd, vg, pv, handle);
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=54b41dcd53d99059…
Commit: 54b41dcd53d99059b691f72eb6e7556d4341634d
Parent: 1ee6af344bd805d4fa847b95b326c2fe1e52d7cd
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Fri Jan 15 15:18:25 2016 -0600
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Mon Jan 18 09:35:06 2016 -0600
pvchange, pvresize: fix lockd_gl() usage
When an orphan PV is changed/resized, the
lvmlockd global lock is converted from sh
to ex. If the command is changing two
orphan PVs, the conversion to ex should
be done only once.
---
tools/pvchange.c | 7 +++++--
tools/pvresize.c | 7 +++++--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tools/pvchange.c b/tools/pvchange.c
index 91e93c1..fad28d1 100644
--- a/tools/pvchange.c
+++ b/tools/pvchange.c
@@ -87,8 +87,11 @@ static int _pvchange_single(struct cmd_context *cmd, struct volume_group *vg,
* i.e. the global lock is only needed for orphans.
* Convert sh to ex.
*/
- if (is_orphan(pv) && !lockd_gl(cmd, "ex", 0))
- return_ECMD_FAILED;
+ if (is_orphan(pv)) {
+ if (!lockd_gl(cmd, "ex", 0))
+ return_ECMD_FAILED;
+ cmd->lockd_gl_disable = 1;
+ }
if (tagargs) {
/* tag or deltag */
diff --git a/tools/pvresize.c b/tools/pvresize.c
index 0b055e6..ad59bae 100644
--- a/tools/pvresize.c
+++ b/tools/pvresize.c
@@ -41,8 +41,11 @@ static int _pvresize_single(struct cmd_context *cmd,
* i.e. the global lock is only needed for orphans.
* Convert sh to ex.
*/
- if (is_orphan(pv) && !lockd_gl(cmd, "ex", 0))
- return_ECMD_FAILED;
+ if (is_orphan(pv)) {
+ if (!lockd_gl(cmd, "ex", 0))
+ return_ECMD_FAILED;
+ cmd->lockd_gl_disable = 1;
+ }
if (!pv_resize_single(cmd, vg, pv, params->new_size))
return_ECMD_FAILED;
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=b77933b1036c5d96…
Commit: b77933b1036c5d96b103eef04ea57558ea418f9f
Parent: 0000000000000000000000000000000000000000
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: 2016-01-16 02:11 +0000
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: 2016-01-16 02:11 +0000
annotated tag: v2_02_140 has been created
at b77933b1036c5d96b103eef04ea57558ea418f9f (tag)
tagging 0faa27d4f55abcda5fa94ef92343eb44e95ada89 (commit)
replaces v2_02_139
Release 2.02.140.
49 files changed, 828 insertions(+), 448 deletions(-)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
iEYEABECAAYFAlaZpt0ACgkQIoGRwVZ+LBcFzACg7Z0algrfyu0ifBFqFlvwAhbt
t14AmgISR9XyLbWcS5PKBKrxQwRw3Er7
=AOPY
-----END PGP SIGNATURE-----
Alasdair G Kergon (3):
post-release
vgcfgrestore: Retain allocatable PV attribute.
pre-release
David Teigland (8):
pvmove: disallow moving PVs under sanlock leases
man lvmlockd: mention pvmove restriction
process_each_pv: remove unnecessary workaround
lvmlockd: fix exit code
vgchange: fix lockd_gl results
Revert "process_each_pv: remove unnecessary workaround"
Revert "lvmcache: skip drop when vg_write lock is not held"
lvmlockd: fixes for test mode
Ondrej Kozina (4):
pvscan: restore polling in autoactivation handler
test: add test for autoactivation regression
vgchange: drop redundant check
test: conditional skip of auto-activation bg polling test
Peter Rajnoha (25):
report: fix invalid memory read when reporting cache LV policy name
cleanup: use _field_set_value and _string_disp consistently in report.c
report: use brackets to signify LVs which are not visible when reporting lv_parent
report: use proper string reference in _string_disp call for _cache_policy_disp fn
lv: add common lv_convert_lv fn for use in report and dup, use brackets for invisible devices
lv: add common lv_origin_lv fn for use in report and dup, use brackets for invisible devices
lv: add common lv_mirror_log_lv for use in report and dup, use brackets for invisible devices
lv: add common lv_data_lv fn for use in report and dup, use brackets for invisible devices
lv: add common lv_metadata_lv fn for use in report and dup, use brackets for invisible devices
lv: add common lv_pool_lv fn for use in report and dup, use brackets for invisible devices
lv: use brackets for invisible devices when formatting device segments
conf: add report/mark_invisible_devices
conf: regenerate
conf: update command_profile_template.profile.in
cleanup: cleanup lv.h and put fns into categories for better readability
tests: update tests to deal with invisible devices consistently
test: add report-invisible.sh test
WHATS_NEW: reports and invisible devices
cleanup: rename 'invisible devices' to 'hidden devices'
cleanup: rename 'invisible devices' to 'hidden devices'
conf: fix 'the volume list' vs 'volume list' and '@*'
cleanup: rename 'invisible devices' to 'hidden devices'
lv: fix check for NULL origin_lv in _do_lv_origin_dup, cleanup _do_lvconvert_lv_dup
report: add kernel_discards report field to display thin pool discard used in kernel
lvm2app: fix lvm2app to return either 0 or 1 for lvm_vg_is_{clustered,exported}
Zdenek Kabelac (11):
lvmanip: add lv_is_snapshot
lvresize: check for poolmetadatasize arg earlier
segtype: check for activation
snapshot: relocate alloc_snapshot_seg
cleanup: more readable check
cleanup: simplier formula
cleanup: explicit prohibition for virtual segs
cleanup: replace log_warn
cleanup: spaces
cleanup: order ac members
lvmanip: fix last commit and drop else