master - vgchange: Prompt when setting VG cluster attr if cluster is not setup
by Jonathan Brassow
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=9399b74356f9d0...
Commit: 9399b74356f9d0c2fbbac824908b15d63c3935cd
Parent: de12310c457964e76e6558cbe079901a34ce4ef4
Author: Jonathan Brassow <jbrassow(a)redhat.com>
AuthorDate: Thu Jun 5 22:27:40 2014 -0500
Committer: Jonathan Brassow <jbrassow(a)redhat.com>
CommitterDate: Thu Jun 5 22:27:40 2014 -0500
vgchange: Prompt when setting VG cluster attr if cluster is not setup
If clvmd is not running or the locking type is not clustered and someone
attempts to set the cluster attribute on a volume group, prompt them to
see if they are sure. (Only prompt for one though. If neither are true,
simply ask them once.)
---
tools/vgchange.c | 15 +++++++++++++++
1 files changed, 15 insertions(+), 0 deletions(-)
diff --git a/tools/vgchange.c b/tools/vgchange.c
index 05e7aea..478a8ca 100644
--- a/tools/vgchange.c
+++ b/tools/vgchange.c
@@ -317,6 +317,21 @@ static int _vgchange_clustered(struct cmd_context *cmd,
return 0;
}
+ if (clustered) {
+ if (!dm_daemon_is_running(CLVMD_PIDFILE)) {
+ if (yes_no_prompt("LVM cluster daemon (clvmd) is not"
+ " running.\n"
+ "Make volume group \"%s\" clustered"
+ " anyway? [y/n]: ", vg->name) == 'n')
+ return 0;
+
+ } else if (!locking_is_clustered() &&
+ (yes_no_prompt("LVM locking type is not clustered.\n"
+ "Make volume group \"%s\" clustered"
+ " anyway? [y/n]: ", vg->name) == 'n'))
+ return 0;
+ }
+
if (!vg_set_clustered(vg, clustered))
return_0;
9 years, 11 months
master - tests: disable python failing test
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=de12310c457964...
Commit: de12310c457964e76e6558cbe079901a34ce4ef4
Parent: 7b8133e0b2cf43ef8221ce14eb140bda7490ab15
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Jun 5 23:07:23 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 23:07:23 2014 +0200
tests: disable python failing test
Aborts and needs fixes...
---
test/api/python_lvm_unit.py | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/test/api/python_lvm_unit.py b/test/api/python_lvm_unit.py
index 39a6779..ab2e86f 100755
--- a/test/api/python_lvm_unit.py
+++ b/test/api/python_lvm_unit.py
@@ -379,12 +379,12 @@ class TestLvm(unittest.TestCase):
TestLvm._create_thick_lv(device_names[2:4], thick_lv)
lv, vg = TestLvm._get_lv(None, thick_lv)
- lv.snapshot('thick_snap_shot', 1024*1024)
+# FIXME lv.snapshot('thick_snap_shot', 1024*1024)
vg.close()
- thick_ss, vg = TestLvm._get_lv(None, 'thick_snap_shot')
- self.assertTrue(thick_ss is not None)
- vg.close()
+# FIXME thick_ss, vg = TestLvm._get_lv(None, 'thick_snap_shot')
+# FIXME self.assertTrue(thick_ss is not None)
+# FIXME vg.close()
thin_lv, vg = TestLvm._get_lv(None, thin_lv)
thin_lv.snapshot('thin_snap_shot')
9 years, 11 months
master - tests: fix test compare
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=7b8133e0b2cf43...
Commit: 7b8133e0b2cf43ef8221ce14eb140bda7490ab15
Parent: eb7ca96b5901d3bf70f0ba193bee55fc616b1805
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Jun 5 23:06:45 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 23:06:45 2014 +0200
tests: fix test compare
Comparing 64T can't use -eq
---
test/shell/lvconvert-thin.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/shell/lvconvert-thin.sh b/test/shell/lvconvert-thin.sh
index a7bbe9f..2ce43b8 100644
--- a/test/shell/lvconvert-thin.sh
+++ b/test/shell/lvconvert-thin.sh
@@ -97,7 +97,7 @@ grep "WARNING: Maximum size" err
lvremove -f $vg
-if test "$TSIZE" -eq 64T; then
+if test "$TSIZE" = 64T; then
lvcreate -L24T -n $lv1 $vg
# Warning about bigger then needed (24T data and 16G -> 128K chunk)
lvconvert --yes -c 64 --thinpool $vg/$lv1 |& tee err
9 years, 11 months
master - tests: adapt test for newline delimit
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=eb7ca96b5901d3...
Commit: eb7ca96b5901d3bf70f0ba193bee55fc616b1805
Parent: 46b0cd10fe2405f281651fcfea5f536573fa7cbc
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Jun 5 23:05:52 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 23:05:52 2014 +0200
tests: adapt test for newline delimit
content of DEVICES is now delimited by newlines
---
test/api/python_lvm_unit.py | 2 +-
test/shell/lvconvert-thin.sh | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/api/python_lvm_unit.py b/test/api/python_lvm_unit.py
index 8208d91..39a6779 100755
--- a/test/api/python_lvm_unit.py
+++ b/test/api/python_lvm_unit.py
@@ -51,7 +51,7 @@ def rs(rand_len=10):
def _get_allowed_devices():
rc = os.environ.get('PY_UNIT_PVS')
if rc is not None:
- rc = rc.split(' ')
+ rc = rc.splitlines()
rc.sort()
return rc
diff --git a/test/shell/lvconvert-thin.sh b/test/shell/lvconvert-thin.sh
index 8c3b903..a7bbe9f 100644
--- a/test/shell/lvconvert-thin.sh
+++ b/test/shell/lvconvert-thin.sh
@@ -27,7 +27,7 @@ aux have_thin 1 0 0 || skip
aux prepare_pvs 4 64
# build one large PV
-vgcreate $vg1 $(cut -d ' ' -f -3 DEVICES)
+vgcreate $vg1 $(head -n 3 DEVICES)
# 32bit linux kernels are fragille with device size >= 16T
# maybe uname -m [ x86_64 | i686 ]
TSIZE=64T
@@ -36,7 +36,7 @@ lvcreate -s -l 100%FREE -n $lv $vg1 --virtualsize $TSIZE
aux extend_filter_LVMTEST
pvcreate "$DM_DEV_DIR/$vg1/$lv"
-vgcreate $vg -s 64K $(cut -d ' ' -f 4 DEVICES) "$DM_DEV_DIR/$vg1/$lv"
+vgcreate $vg -s 64K $(tail -n+4 DEVICES) "$DM_DEV_DIR/$vg1/$lv"
# create mirrored LVs for data and metadata volumes
lvcreate -aey -L10M --type mirror -m1 --mirrorlog core -n $lv1 $vg
9 years, 11 months
master - configure: do not exit with error code
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=46b0cd10fe2405...
Commit: 46b0cd10fe2405f281651fcfea5f536573fa7cbc
Parent: c4e0c6127247c421e40d9d387ba89d8cd9899f5f
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Jun 5 18:02:40 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 18:02:40 2014 +0200
configure: do not exit with error code
Since the test is the last command make a test in a form it will be
after its finished 0.
(regression from last configure cleanup)
---
configure | 2 +-
configure.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index bedccca..034ee12 100755
--- a/configure
+++ b/configure
@@ -13453,5 +13453,5 @@ $as_echo "$as_me: WARNING: Support for thin provisioning is limited since some t
test -n "$THIN_CHECK_VERSION_WARN" && { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: You should also install thin_check vsn 0.3.2 (or later) to use lvm2 thin provisioning" >&5
$as_echo "$as_me: WARNING: You should also install thin_check vsn 0.3.2 (or later) to use lvm2 thin provisioning" >&2;}
-test "$ODIRECT" != yes && { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: O_DIRECT disabled: low-memory pvmove may lock up" >&5
+test "$ODIRECT" = yes || { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: O_DIRECT disabled: low-memory pvmove may lock up" >&5
$as_echo "$as_me: WARNING: O_DIRECT disabled: low-memory pvmove may lock up" >&2;}
diff --git a/configure.in b/configure.in
index a1dfee5..12404ba 100644
--- a/configure.in
+++ b/configure.in
@@ -1762,4 +1762,4 @@ test -n "$THIN_CONFIGURE_WARN" && AC_MSG_WARN([Support for thin provisioning is
test -n "$THIN_CHECK_VERSION_WARN" && AC_MSG_WARN([You should also install thin_check vsn 0.3.2 (or later) to use lvm2 thin provisioning])
-test "$ODIRECT" != yes && AC_MSG_WARN([O_DIRECT disabled: low-memory pvmove may lock up])
+test "$ODIRECT" = yes || AC_MSG_WARN([O_DIRECT disabled: low-memory pvmove may lock up])
9 years, 11 months
master - tests: typo
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=c4e0c6127247c4...
Commit: c4e0c6127247c421e40d9d387ba89d8cd9899f5f
Parent: 54da0ea61afece94445754d3e0a8fd5e0964f1e4
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Jun 2 09:38:10 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 17:49:35 2014 +0200
tests: typo
---
test/shell/snapshot-usage.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/shell/snapshot-usage.sh b/test/shell/snapshot-usage.sh
index 589ed43..fd43650 100644
--- a/test/shell/snapshot-usage.sh
+++ b/test/shell/snapshot-usage.sh
@@ -87,7 +87,7 @@ lvchange -an $vg1
lvchange -ay $vg1
check lv_field $vg1/$lv1 lv_active "$CHECK_ACTIVE"
-# Test removal of opened (bug unmounted) snapshot (device busy) for a while
+# Test removal of opened (but unmounted) snapshot (device busy) for a while
sleep 120 < "$DM_DEV_DIR/$vg1/$lv1" &
SLEEP_PID=$!
9 years, 11 months
master - tests: use get_devs
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=54da0ea61afece...
Commit: 54da0ea61afece94445754d3e0a8fd5e0964f1e4
Parent: 77d4e317a44213baff566f6b13b4a7d930f446b4
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Jun 5 13:01:43 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 17:49:35 2014 +0200
tests: use get_devs
Check how get_devs is usable with shell array DEVICES
---
test/shell/covercmd.sh | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/test/shell/covercmd.sh b/test/shell/covercmd.sh
index a036d92..d7dde5b 100644
--- a/test/shell/covercmd.sh
+++ b/test/shell/covercmd.sh
@@ -17,6 +17,7 @@
. lib/test
aux prepare_pvs 5
+get_devs
pvcreate --metadatacopies 0 "$dev2"
pvcreate --metadatacopies 0 "$dev3"
@@ -24,7 +25,7 @@ pvcreate --metadatacopies 0 "$dev3"
# FIXME takes very long time
#pvck "$dev1"
-vgcreate $vg $(cat DEVICES)
+vgcreate $vg "${DEVICES[@]}"
lvcreate -l 5 -i5 -I256 -n $lv $vg
lvcreate -aey -l 5 -n $lv1 $vg
9 years, 11 months
master - tests: use manglename none for dmsetup
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=77d4e317a44213...
Commit: 77d4e317a44213baff566f6b13b4a7d930f446b4
Parent: 9196942312cadea3cd4bf850442d556b07ad88d4
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Thu Jun 5 12:09:02 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 17:49:34 2014 +0200
tests: use manglename none for dmsetup
---
test/lib/aux.sh | 4 ++--
test/lib/test.sh | 3 ++-
test/lib/utils.sh | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/test/lib/aux.sh b/test/lib/aux.sh
index b093e3c..445bf26 100644
--- a/test/lib/aux.sh
+++ b/test/lib/aux.sh
@@ -151,7 +151,7 @@ teardown_devs_prefixed() {
local need_udev_wait=0
init_udev_transaction
for dm in $(dm_info name --sort open | grep "$prefix"); do
- dmsetup remove --mangle none "$dm" &>/dev/null || remfail=yes
+ dmsetup remove "$dm" &>/dev/null || remfail=yes
need_udev_wait=1
done
finish_udev_transaction
@@ -164,7 +164,7 @@ teardown_devs_prefixed() {
test $num_devs -lt $num_remaining_devs -a $num_devs -ne 0; do
test "$stray" -eq 0 || echo "Removing $num_devs stray mapped devices with names beginning with $prefix: "
for dm in $(dm_info name --sort open | grep "$prefix") ; do
- dmsetup remove --mangle none -f "$dm" || true
+ dmsetup remove -f "$dm" || true
done
num_remaining_devs=$num_devs
done
diff --git a/test/lib/test.sh b/test/lib/test.sh
index 3bde1e3..731cd7a 100644
--- a/test/lib/test.sh
+++ b/test/lib/test.sh
@@ -48,6 +48,7 @@ if test -n "$LVM_TEST_FLAVOUR"; then
. flavour_overrides
fi
+DM_DEFAULT_NAME_MANGLING_MODE=none
DM_DEV_DIR="$TESTDIR/dev"
LVM_SYSTEM_DIR="$TESTDIR/etc"
mkdir "$LVM_SYSTEM_DIR" "$TESTDIR/lib" "$DM_DEV_DIR"
@@ -63,7 +64,7 @@ fi
# abort on the internal dm errors in the tests (allowing test user override)
DM_ABORT_ON_INTERNAL_ERRORS=${DM_ABORT_ON_INTERNAL_ERRORS:-1}
-export DM_DEV_DIR LVM_SYSTEM_DIR DM_ABORT_ON_INTERNAL_ERRORS
+export DM_DEFAULT_NAME_MANGLING_MODE DM_DEV_DIR LVM_SYSTEM_DIR DM_ABORT_ON_INTERNAL_ERRORS
echo "$TESTNAME" >TESTNAME
diff --git a/test/lib/utils.sh b/test/lib/utils.sh
index f28b37b..b4cfdeb 100644
--- a/test/lib/utils.sh
+++ b/test/lib/utils.sh
@@ -159,7 +159,7 @@ teardown_udev_cookies() {
}
dm_info() {
- should dmsetup info --mangle none --noheadings -c -o "$@"
+ should dmsetup info --noheadings -c -o "$@"
}
dm_table() {
9 years, 11 months
master - tests: add get_devs function
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=9196942312cade...
Commit: 9196942312cadea3cd4bf850442d556b07ad88d4
Parent: 223bdc5eb2fe69c43e0138bf097c33f1fa83d536
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Wed Jun 4 13:55:13 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 17:49:34 2014 +0200
tests: add get_devs function
Instead of rereading device list via cat - keep
the list in bash array. (Also solves problem
with spaces in device path)
Move usage of "$path" out of lvm shell usage,
since we don't support such thing there...
---
test/lib/utils.sh | 8 ++++++++
test/shell/listings.sh | 31 +++++++++++++++----------------
2 files changed, 23 insertions(+), 16 deletions(-)
diff --git a/test/lib/utils.sh b/test/lib/utils.sh
index b2e82aa..f28b37b 100644
--- a/test/lib/utils.sh
+++ b/test/lib/utils.sh
@@ -186,6 +186,14 @@ kernel_at_least() {
test "$minor2" -ge "$3" 2>/dev/null || return 1
}
+get_devs() {
+ local IFS=$IFS_NL
+ DEVICES=( $(<DEVICES) )
+ export DEVICES
+# local DEVS=( $(<DEVICES) )
+# eval "$1"'=("${DEVS[@]}")'
+}
+
prepare_test_vars() {
vg="${PREFIX}vg"
lv=LV
diff --git a/test/shell/listings.sh b/test/shell/listings.sh
index 7069707..d916a41 100644
--- a/test/shell/listings.sh
+++ b/test/shell/listings.sh
@@ -16,6 +16,7 @@
. lib/test
aux prepare_devs 5
+get_devs
# Check there is no PV
pvscan | tee out
@@ -28,21 +29,22 @@ pvcreate "$dev4"
pvcreate --metadatacopies 0 "$dev5"
#COMM bz195276 -- pvs doesn't show PVs until a VG is created
-test $(pvs --noheadings $(cat DEVICES) | wc -l) -eq 5
+pvs --noheadings "${DEVICES[@]}"
+test $(pvs --noheadings "${DEVICES[@]}" | wc -l) -eq 5
pvdisplay
#COMM pvs with segment attributes works even for orphans
-test $(pvs --noheadings -o seg_all,pv_all,lv_all,vg_all $(cat DEVICES) | wc -l) -eq 5
+test $(pvs --noheadings -o seg_all,pv_all,lv_all,vg_all "${DEVICES[@]}" | wc -l) -eq 5
-vgcreate $vg $(cat DEVICES)
+vgcreate $vg "${DEVICES[@]}"
check pv_field "$dev1" pv_uuid BADBEE-BAAD-BAAD-BAAD-BAAD-BAAD-BADBEE
#COMM pvs and vgs report mda_count, mda_free (bz202886, bz247444)
-pvs -o +pv_mda_count,pv_mda_free $(cat DEVICES)
+pvs -o +pv_mda_count,pv_mda_free "${DEVICES[@]}"
for I in "$dev2" "$dev3" "$dev5"; do
- check pv_field $I pv_mda_count 0
- check pv_field $I pv_mda_free 0
+ check pv_field "$I" pv_mda_count 0
+ check pv_field "$I" pv_mda_free 0
done
vgs -o +vg_mda_count,vg_mda_free $vg
check vg_field $vg vg_mda_count 2
@@ -64,7 +66,7 @@ lvremove -f $vg/$lv2
lvcreate -aey -l2 --type mirror -m2 -n $lv3 $vg
test $(lvs --noheadings $vg | wc -l) -eq 2
test $(lvs -a --noheadings $vg | wc -l) -eq 6
-dmsetup ls|grep "$PREFIX"|grep -v "LVMTEST.*pv."
+dmsetup ls | grep "$PREFIX" | grep -v "LVMTEST.*pv."
lvcreate -l2 -s $vg/$lv3
lvcreate -l1 -s -n inval $vg/$lv3
@@ -81,8 +83,8 @@ vgs -o pv_name,vg_name $vg
vgs -o all $vg
#COMM pvdisplay --maps feature (bz149814)
-pvdisplay $(cat DEVICES) >out
-pvdisplay --maps $(cat DEVICES) >out2
+pvdisplay "${DEVICES[@]}" >out
+pvdisplay --maps "${DEVICES[@]}" >out2
not diff out out2
aux disable_dev "$dev1"
@@ -108,8 +110,6 @@ invalid lvscan $vg
if aux have_readline; then
cat <<EOF | lvm
-pvdisplay -c "$dev1"
-pvdisplay -s "$dev1"
vgdisplay --units k $vg
vgdisplay -c $vg
vgdisplay -C $vg
@@ -120,10 +120,6 @@ lvdisplay -C $vg
lvdisplay -m $vg
lvdisplay --units g $vg
EOF
-
-for i in h b s k m g t p e H B S K M G T P E; do
- echo pvdisplay --units $i "$dev1"
-done | lvm
else
pvdisplay -c "$dev1"
pvdisplay -s "$dev1"
@@ -136,11 +132,14 @@ lvdisplay -c $vg
lvdisplay -C $vg
lvdisplay -m $vg
lvdisplay --units g $vg
+fi
+
+pvdisplay -c "$dev1"
+pvdisplay -s "$dev1"
for i in h b s k m g t p e H B S K M G T P E; do
pvdisplay --units $i "$dev1"
done
-fi
invalid lvdisplay -C -m $vg
invalid lvdisplay -c -m $vg
9 years, 11 months
master - tests: use shell arrays to keep device names
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=223bdc5eb2fe69...
Commit: 223bdc5eb2fe69c43e0138bf097c33f1fa83d536
Parent: 21db25b3c41dec54da2a6975bf3f3f52b151f1e7
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Wed Jun 4 13:46:19 2014 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Thu Jun 5 17:49:34 2014 +0200
tests: use shell arrays to keep device names
Better preserving spaces in device path name,
though admitely rest of test suite need
more repairs...
---
test/lib/aux.sh | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/test/lib/aux.sh b/test/lib/aux.sh
index 9a13cc8..b093e3c 100644
--- a/test/lib/aux.sh
+++ b/test/lib/aux.sh
@@ -349,13 +349,13 @@ prepare_devs() {
fi
local size=$(($loopsz/$n))
- devs=
-
+ local count=0
init_udev_transaction
for i in $(seq 1 $n); do
local name="${PREFIX}$pvname$i"
local dev="$DM_DEV_DIR/mapper/$name"
- devs="$devs $dev"
+ DEVICES[$count]=$dev
+ count=$(( $count + 1 ))
echo 0 $size linear "$LOOP" $((($i-1)*$size)) > "$name.table"
dmsetup create -u "TEST-$name" "$name" "$name.table"
done
@@ -370,7 +370,8 @@ prepare_devs() {
# dmsetup table $name
#done
- echo $devs > DEVICES
+ printf "%s\n" "${DEVICES[@]}" > DEVICES
+# ( IFS=$'\n'; echo "${DEVICES[*]}" ) >DEVICES
echo "ok"
}
@@ -502,14 +503,14 @@ restore_dev() {
prepare_pvs() {
prepare_devs "$@"
- pvcreate -ff $devs
+ pvcreate -ff "${DEVICES[@]}"
}
prepare_vg() {
teardown_devs
prepare_pvs "$@"
- vgcreate -s 512K $vg $devs
+ vgcreate -s 512K $vg "${DEVICES[@]}"
}
extend_filter() {
9 years, 11 months