On Fri, Nov 10, 2017 at 05:39:03PM +0100, Jan Tluka wrote:
Same variable name is used for initial assignment of test interface
and for
assignment of vlan interface in ping loop. This could have undesired effects
when someone wants to use the variable from initial assignment. To fix this
I renamed the variables in the loop.
Signed-off-by: Jan Tluka <jtluka(a)redhat.com>
---
recipes/regression_tests/phase1/3_vlans.py | 12 ++++++------
recipes/regression_tests/phase1/3_vlans_over_bond.py | 12 ++++++------
recipes/regression_tests/phase2/3_vlans_over_team.py | 12 ++++++------
3 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/recipes/regression_tests/phase1/3_vlans.py
b/recipes/regression_tests/phase1/3_vlans.py
index a8e7c23..cfcacee 100644
--- a/recipes/regression_tests/phase1/3_vlans.py
+++ b/recipes/regression_tests/phase1/3_vlans.py
@@ -241,15 +241,15 @@ for setting in offload_settings:
# Ping test
for vlan1 in vlans:
- m1_vlan1 = m1.get_interface(vlan1)
+ m1_vlan1_if = m1.get_interface(vlan1)
for vlan2 in vlans:
- m2_vlan2 = m2.get_interface(vlan2)
+ m2_vlan2_if = m2.get_interface(vlan2)
- ping_mod.update_options({"addr": m2_vlan2.get_ip(0),
- "iface": m1_vlan1.get_devname()})
+ ping_mod.update_options({"addr": m2_vlan2_if.get_ip(0),
+ "iface": m1_vlan1_if.get_devname()})
- ping_mod6.update_options({"addr": m2_vlan2.get_ip(1),
- "iface": m1_vlan1.get_ip(1)})
+ ping_mod6.update_options({"addr": m2_vlan2_if.get_ip(1),
+ "iface": m1_vlan1_if.get_ip(1)})
if vlan1 == vlan2:
# These tests should pass
diff --git a/recipes/regression_tests/phase1/3_vlans_over_bond.py
b/recipes/regression_tests/phase1/3_vlans_over_bond.py
index 81c4c5c..065f2ee 100644
--- a/recipes/regression_tests/phase1/3_vlans_over_bond.py
+++ b/recipes/regression_tests/phase1/3_vlans_over_bond.py
@@ -241,15 +241,15 @@ for setting in offload_settings:
# Ping test
for vlan1 in vlans:
- m1_vlan1 = m1.get_interface(vlan1)
+ m1_vlan1_if = m1.get_interface(vlan1)
for vlan2 in vlans:
- m2_vlan2 = m2.get_interface(vlan2)
+ m2_vlan2_if = m2.get_interface(vlan2)
- ping_mod.update_options({"addr": m2_vlan2.get_ip(0),
- "iface": m1_vlan1.get_devname()})
+ ping_mod.update_options({"addr": m2_vlan2_if.get_ip(0),
+ "iface": m1_vlan1_if.get_devname()})
- ping_mod6.update_options({"addr": m2_vlan2.get_ip(1),
- "iface": m1_vlan1.get_ip(1)})
+ ping_mod6.update_options({"addr": m2_vlan2_if.get_ip(1),
+ "iface": m1_vlan1_if.get_ip(1)})
if vlan1 == vlan2:
# These tests should pass
diff --git a/recipes/regression_tests/phase2/3_vlans_over_team.py
b/recipes/regression_tests/phase2/3_vlans_over_team.py
index ed92bca..487be60 100644
--- a/recipes/regression_tests/phase2/3_vlans_over_team.py
+++ b/recipes/regression_tests/phase2/3_vlans_over_team.py
@@ -241,15 +241,15 @@ for setting in offload_settings:
# Ping test
for vlan1 in vlans:
- m1_vlan1 = m1.get_interface(vlan1)
+ m1_vlan1_if = m1.get_interface(vlan1)
for vlan2 in vlans:
- m2_vlan2 = m2.get_interface(vlan2)
+ m2_vlan2_if = m2.get_interface(vlan2)
- ping_mod.update_options({"addr": m2_vlan2.get_ip(0),
- "iface": m1_vlan1.get_devname()})
+ ping_mod.update_options({"addr": m2_vlan2_if.get_ip(0),
+ "iface": m1_vlan1_if.get_devname()})
- ping_mod6.update_options({"addr": m2_vlan2.get_ip(1),
- "iface": m1_vlan1.get_ip(1)})
+ ping_mod6.update_options({"addr": m2_vlan2_if.get_ip(1),
+ "iface": m1_vlan1_if.get_ip(1)})
if vlan1 == vlan2:
# These tests should pass
--
2.9.5
_______________________________________________
LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
pushed, thanks
-Ondrej