From: Perry Gagne <pgagne(a)redhat.com>
I happened upon this todo when looking at this code for MPTCP.
IMHO we should probably replace this with the builtin ipaddress module, or perhaps a
customized subclass of it.
The ipaddress module contains many tools that can generate address, for example iterating
though a subnet, and others.
https://docs.python.org/3/library/ipaddress.html#module-ipaddress
Refactoring this might be a lot of work, so I don't want to do it now, but I figured I
would atleast update this todo as reminder to anyone who might be looking at the IpAddress
code and want to do it.
Signed-off-by: Perry Gagne <pgagne(a)redhat.com>
---
lnst/Common/IpAddress.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lnst/Common/IpAddress.py b/lnst/Common/IpAddress.py
index 26400077..e572f32b 100644
--- a/lnst/Common/IpAddress.py
+++ b/lnst/Common/IpAddress.py
@@ -15,8 +15,9 @@ import socket
from socket import inet_pton, inet_ntop, AF_INET, AF_INET6
from lnst.Common.LnstError import LnstError
-#TODO create various generators for IPNetworks and IPaddresses in the same
-#network
+#TODO Replace this with Python's builtin ipaddress module.
+# To make use of its IP address generators.
+#
https://docs.python.org/3/library/ipaddress.html#module-ipaddress
class BaseIpAddress(object):
def __init__(self, addr, flags=None):
--
2.30.2