----- Original Message -----
Thu, Nov 30, 2017 at 08:50:26AM CET, kjerabek(a)redhat.com wrote:
>
>
>----- Original Message -----
>> Tue, Nov 28, 2017 at 01:13:27PM CET, kjerabek(a)redhat.com wrote:
>> >This patch adds new ipsec_esp_aead test to our phase3 regression_tests.
>> >It
>> >is
>> >similar to ipsec_esp_ah_comp test. There is difference in configuration.
>> >In the test is configured only esp aead with algorithm rfc4106(gcm(aes)),
>> >key length 160bit and IV length 96bit.
>> >
>> >Signed-off-by: Kamil Jerabek <kjerabek(a)redhat.com>
>> >
>> >---
>> >changes in:
>> >*v2:
>> > * add official_result handling for PerfRepo
>>
>> When I compared first and second version of the patch there are some
>> removals
>> that should not be there IMO. I see that you removed all of these ones
>> (both
>> for tcp and udp, ipv4 and ipv6):
>>
>> - result_tcp.set_parameter('ipsec_algorithm', algo)
>> - result_tcp.set_parameter('key_length', key_len)
>> - result_tcp.set_parameter('iv_length', icv_len)
>> - result_tcp.set_parameter('msg_size', nperf_msg_size)
>> - result_tcp.set_parameter('ipsec_mode', ipsec_mode)
>> -
>>
>Hi,
>this has purpose here, because there is used different configuration.
>So it is not devided into hash and crypto algorithm with key length.
>
>Because of that I used these.
>
>I can use the same parameters as in ipsec_esp_ah_comp test with hash algo,
>length set to None and without iv_len.
>
The loop starts with:
for algo, key_len, icv_len in algorithm:
So how you're going to handle the situation when we add different values
to algorithm? Also how you're going to differentiate the results with
different msg size if it's not set as parameter?
Further I noticed that the mode is always transport, so why you provide
an alias there? Please clean up the code.
While you're at it please remove comment about "compressed check"
because this is not tested.
-Jan
Oh, yeah, I was watching the first patch and I did not understand that.
Of course, I will fix it and sorry for that, it somehow disappeared from there.
My bad, sorry.
Kamil
> >> Please fix. Thanks,
> >> -Jan
> >> _______________________________________________
> >> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> >> To unsubscribe send an email to
> >> lnst-developers-leave(a)lists.fedorahosted.org
> >>
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>