From: Jozef Urbanovsky jurbanov@redhat.com
Hi,
This is basically v2 patch of "[PATCH-next] setup.py: refactoring code for next". It contains iterative change to the first patch, where install_requires part is omitted and instead all external python dependencies are moved to its own "requirements.txt" file. This change allows us easier manipulation with additional dependencies in downstream code, as previous implementation would create issues with future merge requests.
Jozef Urbanovsky (1): setup.py: refactoring code to use requirements
requirements.txt | 4 ++++ setup.py | 9 ++------- 2 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 requirements.txt
From: Jozef Urbanovsky jurbanov@redhat.com
Added requirements.txt file with upstream dependencies Deleted install_requires part from setuptools
Signed-off-by: Jozef Urbanovsky jurbanov@redhat.com --- requirements.txt | 4 ++++ setup.py | 9 ++------- 2 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 requirements.txt
diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 0000000..a33e664 --- /dev/null +++ b/requirements.txt @@ -0,0 +1,4 @@ +pyyaml +lxml +pyroute2 +libvirt-python \ No newline at end of file diff --git a/setup.py b/setup.py index ad8bfa7..3410c4c 100755 --- a/setup.py +++ b/setup.py @@ -6,11 +6,11 @@ Install script for lnst This script will install LNST to your system. To install LNST, execute it as follows:
- pip3 install . + pip3 install -r requirements.txt .
To install lnst to a different root use:
- pip3 install --prefix <path> . + pip3 install -r requirements.txt --prefix <path> .
"""
@@ -117,10 +117,5 @@ setup(name="lnst", platforms=["linux"], license=["GNU GPLv2"], packages=find_packages(), - install_requires=[ - 'pyyaml', - 'lxml', - 'pyroute2', - 'libvirt-python'], scripts=SCRIPTS, data_files=DATA_FILES)
On Wed, Jun 26, 2019 at 02:26:27PM +0200, jurbanov@redhat.com wrote:
From: Jozef Urbanovsky jurbanov@redhat.com
Hi,
This is basically v2 patch of "[PATCH-next] setup.py: refactoring code for next". It contains iterative change to the first patch, where install_requires part is omitted and instead all external python dependencies are moved to its own "requirements.txt" file. This change allows us easier manipulation with additional dependencies in downstream code, as previous implementation would create issues with future merge requests.
Jozef Urbanovsky (1): setup.py: refactoring code to use requirements
requirements.txt | 4 ++++ setup.py | 9 ++------- 2 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 requirements.txt
-- 2.21.0 _______________________________________________ LNST-developers mailing list -- lnst-developers@lists.fedorahosted.org To unsubscribe send an email to lnst-developers-leave@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedorahos...
looks good, pushing upstream
Thanks, -Ondrej
lnst-developers@lists.fedorahosted.org
-
jurbanov＠redhat.com -
Ondrej Lichtner