This patch modifies all tests that set rx offload. We saw that setting this offload off for certain NICs such as ixgbe does reset of the device. Therefore the link goes down and a delay has to be added after the offload setting so that data sent over the device pass through.
Signed-off-by: Jan Tluka jtluka@redhat.com --- recipes/regression_tests/phase1/3_vlans.py | 5 +++++ recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py | 5 +++++ recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py | 5 +++++ recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py | 5 +++++ recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py | 5 +++++ 5 files changed, 25 insertions(+)
diff --git a/recipes/regression_tests/phase1/3_vlans.py b/recipes/regression_tests/phase1/3_vlans.py index fdb58e0..502c76c 100644 --- a/recipes/regression_tests/phase1/3_vlans.py +++ b/recipes/regression_tests/phase1/3_vlans.py @@ -181,6 +181,11 @@ for setting in offload_settings: m2.run("ethtool -K %s %s" % (m2_phy1.get_devname(), dev_features))
+ if ("rx", "off") in setting: + # when rx offload is turned off some of the cards might get reset + # and link goes down, so wait a few seconds until NIC is ready + ctl.wait(15) + if ipv in [ 'ipv4', 'both' ]: # Netperf test (both TCP and UDP) srv_proc = m1.run(netperf_srv, bg=True) diff --git a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py index d3cc786..d15929a 100644 --- a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py +++ b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py @@ -166,6 +166,11 @@ for setting in offload_settings: h1.run("ethtool -K %s %s" % (h1_nic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
+ if ("rx", "off") in setting: + # when rx offload is turned off some of the cards might get reset + # and link goes down, so wait a few seconds until NIC is ready + ctl.wait(15) + if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
diff --git a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py index ca169af..ed12b67 100644 --- a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py +++ b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py @@ -166,6 +166,11 @@ for setting in offload_settings: h1.run("ethtool -K %s %s" % (h1_nic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
+ if ("rx", "off") in setting: + # when rx offload is turned off some of the cards might get reset + # and link goes down, so wait a few seconds until NIC is ready + ctl.wait(15) + if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
diff --git a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py index 76aa386..8ac0da4 100644 --- a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py +++ b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py @@ -153,6 +153,11 @@ for setting in offload_settings: g1.run("ethtool -K %s %s" % (g1_guestnic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
+ if ("rx", "off") in setting: + # when rx offload is turned off some of the cards might get reset + # and link goes down, so wait a few seconds until NIC is ready + ctl.wait(15) + if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
diff --git a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py index dcde1b2..5dae9da 100644 --- a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py +++ b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py @@ -152,6 +152,11 @@ for setting in offload_settings: g1.run("ethtool -K %s %s" % (g1_guestnic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
+ if ("rx", "off") in setting: + # when rx offload is turned off some of the cards might get reset + # and link goes down, so wait a few seconds until NIC is ready + ctl.wait(15) + if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
Scratch this one also, since it depends on previous one.
Thu, Dec 03, 2015 at 10:51:14AM CET, jtluka@redhat.com wrote:
This patch modifies all tests that set rx offload. We saw that setting this offload off for certain NICs such as ixgbe does reset of the device. Therefore the link goes down and a delay has to be added after the offload setting so that data sent over the device pass through.
Signed-off-by: Jan Tluka jtluka@redhat.com
recipes/regression_tests/phase1/3_vlans.py | 5 +++++ recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py | 5 +++++ recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py | 5 +++++ recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py | 5 +++++ recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py | 5 +++++ 5 files changed, 25 insertions(+)
diff --git a/recipes/regression_tests/phase1/3_vlans.py b/recipes/regression_tests/phase1/3_vlans.py index fdb58e0..502c76c 100644 --- a/recipes/regression_tests/phase1/3_vlans.py +++ b/recipes/regression_tests/phase1/3_vlans.py @@ -181,6 +181,11 @@ for setting in offload_settings: m2.run("ethtool -K %s %s" % (m2_phy1.get_devname(), dev_features))
- if ("rx", "off") in setting:
# when rx offload is turned off some of the cards might get reset# and link goes down, so wait a few seconds until NIC is readyctl.wait(15)- if ipv in [ 'ipv4', 'both' ]: # Netperf test (both TCP and UDP) srv_proc = m1.run(netperf_srv, bg=True)
diff --git a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py index d3cc786..d15929a 100644 --- a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py +++ b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_guest.py @@ -166,6 +166,11 @@ for setting in offload_settings: h1.run("ethtool -K %s %s" % (h1_nic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
- if ("rx", "off") in setting:
# when rx offload is turned off some of the cards might get reset# and link goes down, so wait a few seconds until NIC is readyctl.wait(15)- if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
diff --git a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py index ca169af..ed12b67 100644 --- a/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py +++ b/recipes/regression_tests/phase1/virtual_bridge_vlan_in_host.py @@ -166,6 +166,11 @@ for setting in offload_settings: h1.run("ethtool -K %s %s" % (h1_nic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
- if ("rx", "off") in setting:
# when rx offload is turned off some of the cards might get reset# and link goes down, so wait a few seconds until NIC is readyctl.wait(15)- if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
diff --git a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py index 76aa386..8ac0da4 100644 --- a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py +++ b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_guest.py @@ -153,6 +153,11 @@ for setting in offload_settings: g1.run("ethtool -K %s %s" % (g1_guestnic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
- if ("rx", "off") in setting:
# when rx offload is turned off some of the cards might get reset# and link goes down, so wait a few seconds until NIC is readyctl.wait(15)- if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
diff --git a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py index dcde1b2..5dae9da 100644 --- a/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py +++ b/recipes/regression_tests/phase2/virtual_ovs_bridge_vlan_in_host.py @@ -152,6 +152,11 @@ for setting in offload_settings: g1.run("ethtool -K %s %s" % (g1_guestnic.get_devname(), dev_features)) h2.run("ethtool -K %s %s" % (h2_nic.get_devname(), dev_features))
- if ("rx", "off") in setting:
# when rx offload is turned off some of the cards might get reset# and link goes down, so wait a few seconds until NIC is readyctl.wait(15)- if ipv in [ 'ipv4', 'both' ]: g1.run(ping_mod)
-- 2.4.3 _______________________________________________ LNST-developers mailing list lnst-developers@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/lnst-developers@lists.fedorahoste...
lnst-developers@lists.fedorahosted.org
-
Jan Tluka