Tue, May 09, 2017 at 09:54:40AM CEST, olichtne(a)redhat.com wrote:
On Mon, May 08, 2017 at 01:54:05PM +0300, Roi Dayan wrote:
>
>
> On 27/04/2017 14:27, Roi Dayan wrote:
> > Hi,
> >
> > The first patch is a fix to set device down when cleaning it instead of up.
> > The second patch is adding support to set addresses on the bridge interface.
> >
> > Thanks,
> > Roi
> >
> >
> > Roi Dayan (2):
> > NetConfigDeviceOvsBridge: set interface down in address cleanup
> > NetConfigDeviceOvsBridge: support set addresses on the bridge
> > interface
> >
> > lnst/Slave/NetConfigDevice.py | 4 +++-
> > schema-recipe.rng | 3 +++
> > 2 files changed, 6 insertions(+), 1 deletions(-)
> >
>
> Hi,
>
> Any comments about the patches?
>
> Thanks,
> Roi
Again, apologies for the silence.
The patches are simple enough and look ok to me.
Only, we didn't really want to push any more changes to the XML schema
AFAIK.
But considering it's a small enough change I can push this if there's no
complaints from anyone else...
@Jiri Pirko any comments on this from your side?
No, please push this. Thanks.