commit 791fd48e6a95a10dfef60ac442f2a34f225e672a Author: Radek Pazdera rpazdera@redhat.com Date: Fri Jun 8 12:19:26 2012 +0200
NetTestController: Adding missing cleanup
Call to _cleanup() was added to 'all_dump' and 'config_only' actions, so the slaves are properly deconfigured when '-c' argument is present.
Signed-off-by: Radek Pazdera rpazdera@redhat.com
NetTest/NetTestController.py | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) --- diff --git a/NetTest/NetTestController.py b/NetTest/NetTestController.py index 8f46bcb..5455921 100644 --- a/NetTest/NetTestController.py +++ b/NetTest/NetTestController.py @@ -200,10 +200,14 @@ class NetTestController: def all_dump_recipe(self): self._prepare() pprint(self._recipe) + if self._docleanup: + self._cleanup() return True
def config_only_recipe(self): self._prepare() + if self._docleanup: + self._cleanup() return True
def run_recipe(self): @@ -218,7 +222,8 @@ class NetTestController: if not res: break
- self._cleanup() + if self._docleanup: + self._cleanup() return res
def eval_expression_recipe(self, expr):
Hello, I've just come across this patch while analyzing issue with using -c option for config_only mode.
It seems that the patch below is adding cleanup also to config_only mode but I think that in this mode the cleanup option should be silently ignored otherwise you'll end up with no netconfigs applied :-)
Therefore I think the part of the patch should be reverted. I'll send the correction patch soon.
-Jan
Mon, Jun 11, 2012 at 04:05:32PM CEST, jirka@fedoraproject.org wrote:
commit 791fd48e6a95a10dfef60ac442f2a34f225e672a Author: Radek Pazdera rpazdera@redhat.com Date: Fri Jun 8 12:19:26 2012 +0200
NetTestController: Adding missing cleanup
Call to _cleanup() was added to 'all_dump' and 'config_only' actions, so the slaves are properly deconfigured when '-c' argument is present.
Signed-off-by: Radek Pazdera rpazdera@redhat.com
NetTest/NetTestController.py | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/NetTest/NetTestController.py b/NetTest/NetTestController.py index 8f46bcb..5455921 100644 --- a/NetTest/NetTestController.py +++ b/NetTest/NetTestController.py @@ -200,10 +200,14 @@ class NetTestController: def all_dump_recipe(self): self._prepare() pprint(self._recipe)
if self._docleanup:
self._cleanup() return True
def config_only_recipe(self): self._prepare()
if self._docleanup:
self._cleanup() return True
def run_recipe(self):
@@ -218,7 +222,8 @@ class NetTestController: if not res: break
self._cleanup()
if self._docleanup:
self._cleanup() return res
def eval_expression_recipe(self, expr):
LNST-developers mailing list LNST-developers@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/lnst-developers
On 06/26/2012 04:09 PM, Jan Tluka wrote:
Hello, I've just come across this patch while analyzing issue with using -c option for config_only mode.
It seems that the patch below is adding cleanup also to config_only mode but I think that in this mode the cleanup option should be silently ignored otherwise you'll end up with no netconfigs applied :-)
I thought it could make sense in case you just want to test your config and clean it up afterwards.
You can keep the netconfigs applied by omitting the -c.
Radek
Therefore I think the part of the patch should be reverted. I'll send the correction patch soon.
-Jan
Mon, Jun 11, 2012 at 04:05:32PM CEST, jirka@fedoraproject.org wrote:
commit 791fd48e6a95a10dfef60ac442f2a34f225e672a Author: Radek Pazderarpazdera@redhat.com Date: Fri Jun 8 12:19:26 2012 +0200
NetTestController: Adding missing cleanup Call to _cleanup() was added to 'all_dump' and 'config_only' actions, so the slaves are properly deconfigured when '-c' argument is present. Signed-off-by: Radek Pazdera<rpazdera@redhat.com>
NetTest/NetTestController.py | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/NetTest/NetTestController.py b/NetTest/NetTestController.py index 8f46bcb..5455921 100644 --- a/NetTest/NetTestController.py +++ b/NetTest/NetTestController.py @@ -200,10 +200,14 @@ class NetTestController: def all_dump_recipe(self): self._prepare() pprint(self._recipe)
if self._docleanup:
self._cleanup() return True
def config_only_recipe(self): self._prepare()
if self._docleanup:
self._cleanup() return True
def run_recipe(self):
@@ -218,7 +222,8 @@ class NetTestController: if not res: break
self._cleanup()
if self._docleanup:
self._cleanup() return res
def eval_expression_recipe(self, expr):
LNST-developers mailing list LNST-developers@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/lnst-developers
LNST-developers mailing list LNST-developers@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/lnst-developers
Thu, Jun 28, 2012 at 08:00:26AM CEST, rpazdera@redhat.com wrote:
On 06/26/2012 04:09 PM, Jan Tluka wrote:
Hello, I've just come across this patch while analyzing issue with using -c option for config_only mode.
It seems that the patch below is adding cleanup also to config_only mode but I think that in this mode the cleanup option should be silently ignored otherwise you'll end up with no netconfigs applied :-)
I thought it could make sense in case you just want to test your config and clean it up afterwards.
Yes, I just realized this while using it for a while. Let's keep it then.
You can keep the netconfigs applied by omitting the -c.
Radek
Therefore I think the part of the patch should be reverted. I'll send the correction patch soon.
-Jan
Mon, Jun 11, 2012 at 04:05:32PM CEST, jirka@fedoraproject.org wrote:
commit 791fd48e6a95a10dfef60ac442f2a34f225e672a Author: Radek Pazderarpazdera@redhat.com Date: Fri Jun 8 12:19:26 2012 +0200
NetTestController: Adding missing cleanup
Call to _cleanup() was added to 'all_dump' and 'config_only' actions, so the slaves are properly deconfigured when '-c' argument is present.
Signed-off-by: Radek Pazderarpazdera@redhat.com
NetTest/NetTestController.py | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/NetTest/NetTestController.py b/NetTest/NetTestController.py index 8f46bcb..5455921 100644 --- a/NetTest/NetTestController.py +++ b/NetTest/NetTestController.py @@ -200,10 +200,14 @@ class NetTestController: def all_dump_recipe(self): self._prepare() pprint(self._recipe)
if self._docleanup:
self._cleanup() return True
def config_only_recipe(self): self._prepare()
if self._docleanup:
self._cleanup() return True
def run_recipe(self):
@@ -218,7 +222,8 @@ class NetTestController: if not res: break
self._cleanup()
if self._docleanup:
self._cleanup() return res
def eval_expression_recipe(self, expr):
LNST-developers mailing list LNST-developers@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/lnst-developers
LNST-developers mailing list LNST-developers@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/lnst-developers
lnst-developers@lists.fedorahosted.org