2016-07-12 9:35 GMT+02:00 Ondrej Lichtner <olichtne@redhat.com>:
On Tue, Jul 12, 2016 at 09:29:50AM +0200, Jiri Prochazka wrote:
> 2016-07-12 9:23 GMT+02:00 Ondrej Lichtner <olichtne@redhat.com>:
> > On Mon, Apr 25, 2016 at 04:54:34PM +0200, Jan Tluka wrote:
> >> Fri, Apr 22, 2016 at 08:55:01AM CEST, jtluka@redhat.com wrote:
> >> >Thu, Apr 21, 2016 at 04:26:56PM CEST, jprochaz@redhat.com wrote:
> >> >>offload setting gro on gso on tso on tx on rx off was missing,
> >> >>this patch adds it
> >> >>
> >> >>Signed-off-by: Jiri Prochazka <jprochaz@redhat.com>
> >> >>---
> >> >
> >> >Note: Before applying we should check if this works fine.
> >> >
> >> >-Jan
> >>
> >> Acked-by: Jan Tluka <jtluka@redhat.com>
> >>
> >> The patch is ok. I have tested this on my setup.
> >>
> >> But since this will change the hashes for perfrepo, let's wait few more
> >> days before applying this so that we have time to rehash the perfrepo
> >> reports.
> >
> > Well... I'd say "few more days" passed. What do we want to do about this
> > patch? We probably should have applied this patch when we were changing
> > our testmachines and redoing all our hashes anyway... but it's too late
> > for that now... so what now?
>
> Didn't we agree that we won't apply this patch because those offloads
> are not set on purpose?

Right... based on commit 696da2144cfe86141b800ad0fb15fdd40e7670d9 we've
decided on this in October 2015... but you sent this patch "recently"...
so was that just your mistake or was there a reason behind it?

​It was my mistake, I thought we forgot to add the offloads as I didn't find the patch removing it.​

 

-Ondrej