comments inline

2015-09-14 14:05 GMT+02:00 <olichtne@redhat.com>:
From: Ondrej Lichtner <olichtne@redhat.com>

Renamed from report_delete. The method is now tested and usable.

Signed-off-by: Ondrej Lichtner <olichtne@redhat.com>
---
 lnst/Controller/PerfRepo.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/lnst/Controller/PerfRepo.py b/lnst/Controller/PerfRepo.py
index ba3fd64..3aca991 100644
--- a/lnst/Controller/PerfRepo.py
+++ b/lnst/Controller/PerfRepo.py
@@ -966,8 +966,11 @@ class PerfRepoRESTAPI(object):
             logging.info("Obj url: %s" % self.get_obj_url(report))
             return report

-    def report_delete(self, report_id):
-        #TODO not needed yet and therefore not tested
-        delete_url = self._url + '/rest/report/delete'
-        self._session.delete(post_url)
-        return None
+    def report_delete_by_id(self, report_id):
+        delete_url = self._url + '/rest/report/id/%s' % report_id
+        response = self._session.delete(delete_url)
+        if response.status_code != 204:

​Maybe these status codes could be stored in named constants,
so it's more readable?
 
+            return False
+        else:
+            logging.info("DELETE %s success" % delete_url)
+            return True
--
2.5.2

_______________________________________________
LNST-developers mailing list
LNST-developers@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/lnst-developers



--
​Best regards,​

Jiri Prochazka 
LNST Developer 
+420 532 294 633 | jprochaz@redhat.com
Red Hat Czech | Purkyňova 71/99, 612 00 Brno