----- Original Message -----
From: "Jan Tluka" jtluka@redhat.com To: "Christos Sfakianakis" csfakian@redhat.com Cc: lnst-developers@lists.fedorahosted.org Sent: Monday, May 27, 2019 1:48:42 PM Subject: Re: [PATCH-next 3/5] lnst.Devices: add MacsecDevice
Mon, May 27, 2019 at 01:40:09PM CEST, csfakian@redhat.com wrote:
----- Original Message -----
From: "Jan Tluka" jtluka@redhat.com To: csfakian@redhat.com Cc: lnst-developers@lists.fedorahosted.org Sent: Monday, May 27, 2019 12:19:05 PM Subject: Re: [PATCH-next 3/5] lnst.Devices: add MacsecDevice
I've checked the 'ip link' man page and it's not clear what is the default value for encrypt parameter if not specified. It would be better if this is explicit in LNST code, either on or off. Is this device parameter mandatory (in LNST code)?
Ok, I will set this option as mandatory together with the 'realdev' option.
And remove the condition completely. Simply exec with encrypt + whatever is passed as the device param.
S. Dubroca informed me that the kernel policy has a default value of 'off' for 'encrypt' (so it is expected to stay so forever); I am therefore leaving the code as is for now (after our talk).
Thanks, Jan _______________________________________________ LNST-developers mailing list -- lnst-developers@lists.fedorahosted.org To unsubscribe send an email to lnst-developers-leave@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedorahos...