On Mon, Dec 21, 2020 at 01:56:07PM +0100, Jan Tluka wrote:
Fri, Dec 18, 2020 at 02:21:28PM CET, olichtne(a)redhat.com wrote:
>From: Ondrej Lichtner <olichtne(a)redhat.com>
>Most of this is centered around adding a reference to the overall
>configuration of the Recipe to the Perf.* package code. I also started
>adding a lot of type hints to make it easier to understand which "conf"
>variable refers to which type of "*Conf" instance...
>This is a preliminary version that will require at least one more round
>of refactoring to actually add all the skipped type hinting, ideally
>also splitting the commit into multiple parts.
Looks ok, but what's the purpose of adding reference to the parent config?
in evaluator code, and specifically in our internal mixin extensions for
this (database connection) I want to be able to access/inspect the
entire configuration of the recipe (at the point of the measurement -
that's why there's a copy() call there), not just the perf
configuration. I also want to be able to distinguish between them in
case it's relevant.
Like I've said in the commit message, this final commit is mostly a
preliminary version that still needs some work, so the use case may
become more apparent after I do that.