Mon, Jul 27, 2020 at 09:21:24AM CEST, olichtne(a)redhat.com wrote:
On Fri, Jul 24, 2020 at 07:00:48PM +0200, Jan Tluka wrote:
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com>
> ---
> lnst/Recipes/ENRT/BaseEnrtRecipe.py | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> index f8fafc80..46cc09ea 100644
> --- a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> +++ b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> @@ -13,6 +13,7 @@ from lnst.Common.Parameters import (
> from lnst.Common.IpAddress import AF_INET, AF_INET6
>
> from lnst.Recipes.ENRT.ConfigMixins.BaseSubConfigMixin import BaseSubConfigMixin
> +from lnst.Recipes.ENRT.PerfTestMixins import SctpFirewallPerfTestMixin
>
> from lnst.RecipeCommon.Ping.Recipe import PingTestAndEvaluate, PingConf
> from lnst.RecipeCommon.Perf.Recipe import Recipe as PerfRecipe
> @@ -32,7 +33,8 @@ class EnrtConfiguration(object):
> """
> pass
>
> -class BaseEnrtRecipe(BaseSubConfigMixin, PingTestAndEvaluate, PerfRecipe):
> +class BaseEnrtRecipe(SctpFirewallPerfTestMixin, BaseSubConfigMixin,
> + PingTestAndEvaluate, PerfRecipe):
> """Base Recipe class for the ENRT recipe package
>
> This class defines the shared *test* method defining the common test
> @@ -343,7 +345,9 @@ class BaseEnrtRecipe(BaseSubConfigMixin, PingTestAndEvaluate,
PerfRecipe):
> methods to execute, report and evaluate the results.
> """
> for perf_config in self.generate_perf_configurations(recipe_config):
> + self.apply_perf_test_tweak(perf_config)
> result = self.perf_test(perf_config)
> + self.remove_perf_test_tweak(perf_config)
This should be in a try-except-finally block, the remove_perf_test_tweak
in the "finally" part.
Just in case something crashes during perf_test and throws and
exception, let's make sure that we ensure deconfiguration.
-Ondrej
Ok, good idea. Will fix this.
> self.perf_report_and_evaluate(result)
>
> def generate_ping_configurations(self, config):
> --
> 2.21.3
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedora...