Tue, Feb 23, 2021 at 01:51:49PM CET, olichtne(a)redhat.com wrote:
is this also needed for other FlowMeasurement classes (Trex?) or will
they still work fine, just ignoring the parameter?
-Ondrej
Good point. I don't think this is an issue of TrexFlowMeasurement as it
does not use Flow directly, however a test run of OvS_DPDK_PvP recipe
failed with a traceback.
Traceback (most recent call last):
File "./do-my-test", line 38, in main
ctl.run(recipe)
File "/usr/lib/python3.6/site-packages/lnst/Controller/Controller.py", line
160, in run
recipe.test()
File "/usr/lib/python3.6/site-packages/lnst/RHExtensions/RHRecipeMixin.py",
line 73, in test
super(RHRecipeMixin, self).test()
File "/usr/lib/python3.6/site-packages/lnst/Recipes/ENRT/OvS_DPDK_PvP.py",
line 77, in test
self.pvp_test(config)
File "/usr/lib/python3.6/site-packages/lnst/Recipes/ENRT/BasePvPRecipe.py",
line 255, in pvp_test
perf_config = self.generate_perf_config(config)
File "/usr/lib/python3.6/site-packages/lnst/Recipes/ENRT/OvS_DPDK_PvP.py",
line 151, in generate_perf_config
cpupin=None))
TypeError: __init__() missing 1 required positional argument: 'receiver_port'
I'll fix this and also take a look at other code that instantiates the
Flow objects.
-Jan
On Thu, Feb 18, 2021 at 01:58:34PM +0100, Jan Tluka wrote:
> The iperf server and client params is extended with the Flow receiver_port
> property.
>
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com>
> ---
> lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
b/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
> index 722b49ed..6e6fd64f 100644
> --- a/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
> +++ b/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
> @@ -128,6 +128,9 @@ class IperfFlowMeasurement(BaseFlowMeasurement):
> elif flow.cpupin is not None:
> raise RecipeError("Negative perf cpupin value provided.")
>
> + if flow.receiver_port is not None:
> + server_params["port"] = flow.receiver_port
> +
> return host.prepare_job(IperfServer(**server_params),
> job_level=ResultLevel.NORMAL)
>
> @@ -161,6 +164,9 @@ class IperfFlowMeasurement(BaseFlowMeasurement):
> if flow.msg_size:
> client_params["blksize"] = flow.msg_size
>
> + if flow.receiver_port is not None:
> + client_params["port"] = flow.receiver_port
> +
> return host.prepare_job(IperfClient(**client_params),
> job_level=ResultLevel.NORMAL)
>
> --
> 2.26.2
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedora...
> Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure