Mon, May 27, 2019 at 01:40:09PM CEST, csfakian(a)redhat.com wrote:
----- Original Message -----
> From: "Jan Tluka" <jtluka(a)redhat.com>
> To: csfakian(a)redhat.com
> Cc: lnst-developers(a)lists.fedorahosted.org
> Sent: Monday, May 27, 2019 12:19:05 PM
> Subject: Re: [PATCH-next 3/5] lnst.Devices: add MacsecDevice
>
> I've checked the 'ip link' man page and it's not clear what is the
> default value for encrypt parameter if not specified. It would be better
> if this is explicit in LNST code, either on or off. Is this device
> parameter mandatory (in LNST code)?
>
Ok, I will set this option as mandatory together with the 'realdev' option.
And remove the condition completely. Simply exec with encrypt + whatever
is passed as the device param.
Thanks,
Jan