Fri, May 07, 2021 at 03:16:05PM CEST, olichtne(a)redhat.com wrote:
On Tue, May 04, 2021 at 11:21:12AM +0200, Jan Tluka wrote:
> Some of the recipes inheriting from the BaseTunnelRecipe may not require
> packet assert test. This could be solved by not including the
> PacketAssertTestAndEvaluate in the BaseTunnelRecipe inheritance but I plan
> to send additional tests that use the packet assert test and it's
> probably better to add a condition to execute the test.
"some tunnel recipes don't require packet assert testing"
is this because of the legacy recipe implementation - it wasn't
implemented in legacy so let's not do it here?
Or is there a more techincal reason? e.g. L2TP tunnel cannot be detected
by packet assert?
I wondering if it would maybe make sense to include packet assert test
for all tunnel recipes regardless of if we did this in legacy?
The reason was that it was not present in the legacy implementation.
I'll check and try to implement a packet assert test here. Then we can
get rid of this hack.
Thanks for review!
J.
-Ondrej