Fri, Apr 21, 2017 at 12:53:52PM CEST, jprochaz(a)redhat.com wrote:
2017-04-20 18:38 GMT+02:00 Jan Tluka <jtluka(a)redhat.com>:
> Thu, Apr 20, 2017 at 05:21:45PM CEST, jprochaz(a)redhat.com wrote:
>>We used kbit/s as output rate for STREAM tests, then we converted it to
>>bit/s. This patch changes that so the output rate is in bit/s for STREAM
>>tests and Trans/s for RR tests.
>
> Unfortunately there's a reason behind kbit/s.
>
> Ondrej's patch comment (commit 831b1861f2054d02efd12e5f9d9edee34d57746a):
>
> * The client measures speeds in kilobits by default, previously this
> wasn't set so whatever Netperf deemed appropriate was used. This helps
> with result parsing.
>
> If you don't specify it netperf would report in units it thinks are
> appropriate. I know that you're now parsing the OMNI output that includes
> the tput units but that would not work for non-omni tests.
>
> -Jan
Yes, but Ondrej's patch uses -f k, so the rate is measured in kbit/s,
and then it is converted to bits/s in the code.
In my patch, for STREAM tests, -f b is used, so the rate is measured
in bit/s and no further conversion is needed.
And this does work for both omni and non-omni tests.
Oh, I did not know that '-f b' is possible. Then it sounds good.
-Jan