Mon, Mar 22, 2021 at 07:42:08PM CET, pgagne(a)redhat.com wrote:
From: Perry Gagne <pgagne(a)redhat.com>
Turns out if neper doesn't have the response size definied on the server side, it
defaults to 1, instead of whatever the client param is.
Hello Perry.
There's additional code about versions. I'd prefer this to be in
separate commit or at least explained in the commit description.
For now I'm ok with that but please think about this in the future
commits.
Could you just explain what this change is about? What's the purpose of
this?
Thanks,
Jan
Signed-off-by: Perry Gagne <pgagne(a)redhat.com>
---
.../Perf/Measurements/NeperFlowMeasurement.py | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/lnst/RecipeCommon/Perf/Measurements/NeperFlowMeasurement.py
b/lnst/RecipeCommon/Perf/Measurements/NeperFlowMeasurement.py
index 84a00c16..236c2c9b 100644
--- a/lnst/RecipeCommon/Perf/Measurements/NeperFlowMeasurement.py
+++ b/lnst/RecipeCommon/Perf/Measurements/NeperFlowMeasurement.py
@@ -20,11 +20,17 @@ class NeperFlowMeasurement(BaseFlowMeasurement):
self._flows = flows
self._running_measurements = []
self._finished_measurements = []
+ self._host_versions = {}
@property
def flows(self) -> List[Flow]:
return self._flows
+ @property
+ def version(self):
+ return {"measurement_version": self._MEASUREMENT_VERSION,
+ "hosts_neper_versions": self._host_versions}
+
def start(self):
if len(self._running_measurements) > 0:
raise MeasurementError("Measurement already running!")
@@ -78,6 +84,10 @@ class NeperFlowMeasurement(BaseFlowMeasurement):
elif flow.cpupin is not None:
raise RecipeError("Negative perf cpupin value provided.")
+ if flow.msg_size:
+ server_params["request_size"] = flow.msg_size
+ server_params["response_size"] = flow.msg_size
+
return host.prepare_job(NeperServer(**server_params),
job_level=ResultLevel.NORMAL)
@@ -123,10 +133,14 @@ class NeperFlowMeasurement(BaseFlowMeasurement):
generator_stats = self._parse_job_samples(test_flow.client_job)
flow_results.generator_results = generator_stats[0]
flow_results.generator_cpu_stats = generator_stats[1]
+ self._host_versions[test_flow.flow.generator] = \
+ test_flow.client_job.result["data"]["VERSION"]
receiver_stats = self._parse_job_samples(test_flow.server_job)
flow_results.receiver_results = receiver_stats[0]
flow_results.receiver_cpu_stats = receiver_stats[1]
+ self._host_versions[test_flow.flow.receiver] = \
+ test_flow.server_job.result["data"]["VERSION"]
results.append(flow_results)
--
2.30.2
_______________________________________________
LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedora...
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure