comments inline

2015-09-14 14:05 GMT+02:00 <olichtne@redhat.com>:
From: Ondrej Lichtner <olichtne@redhat.com>

Some PerfRepo objects were missing a few get methods for their
attributes. This patch fixes that.

Signed-off-by: Ondrej Lichtner <olichtne@redhat.com>
---
 lnst/Controller/PerfRepo.py | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/lnst/Controller/PerfRepo.py b/lnst/Controller/PerfRepo.py
index 3aca991..f7949d0 100644
--- a/lnst/Controller/PerfRepo.py
+++ b/lnst/Controller/PerfRepo.py
@@ -118,6 +118,13 @@ class PerfRepoTest(PerfRepoObject):
     def set_groupid(self, groupid):
         self._groupid = groupid

+    def add_metric(self, metric):
+        if not isinstance(metric, PerfRepoMetric):
+            return None
+        else:
+            self._metrics.append(metric)
+            return metric
+

​this is not get method and should be added in separate patch​

 
     def to_xml(self):
         root = Element('test')
         self._set_element_atrib(root, 'id', self._id)
@@ -206,9 +213,15 @@ class PerfRepoTestExecution(PerfRepoObject):
     def set_id(self, id):
         self._id = id

+    def get_id(self):
+        return self._id
+
     def set_name(self, name):
         self._name = name

+    def get_name(self):
+        return self._name
+
     def set_started(self, date=None):
         if isinstance(date, NoneType):
             date = datetime.datetime.utcnow().isoformat()
@@ -216,12 +229,18 @@ class PerfRepoTestExecution(PerfRepoObject):
         else:
             self._started = date

+    def get_started(self):
+        return self._started
+
     def set_testId(self, testId):
         if isinstance(testId, PerfRepoTest):
             self._testId = testId.get_id()
         else:
             self._testId = testId

+    def get_testId(self):
+        return self._testId
+
     def set_testUid(self, testUid):
         if isinstance(testUid, PerfRepoTest):
             self._testUid = testUid.get_uid()
@@ -234,6 +253,9 @@ class PerfRepoTestExecution(PerfRepoObject):
     def set_comment(self, comment):
         self._comment = comment

+    def get_comment(self):
+        return self._comment
+
     def add_value(self, value):
         self._values.append(value)

@@ -352,6 +374,9 @@ class PerfRepoValue(PerfRepoObject):
     def add_parameter(self, name, value):
         self._parameters.append((name, value))

+    def get_parameters(self):
+        return self._parameters
+
     def get_metricName(self):
         return self._metricName

--
2.5.2

_______________________________________________
LNST-developers mailing list
LNST-developers@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/lnst-developers



--
​Best regards,​

Jiri Prochazka 
LNST Developer 
+420 532 294 633 | jprochaz@redhat.com
Red Hat Czech | Purkyňova 71/99, 612 00 Brno