Re: [PATCH 08/15] Task: add new ControllerAPI methods

Wed, Jul 13, 2016 at 01:51:43PM CEST, jprochaz@redhat.com wrote:

2016-07-12 14:43 GMT+02:00 Jiri Pirko jiri@resnulli.us:

...

Tue, Jul 12, 2016 at 11:00:29AM CEST, jprochaz@redhat.com wrote:

...

Signed-off-by: Jiri Prochazka jprochaz@redhat.com

lnst/Controller/Task.py | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)

diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py index 9fc11e3..6645acc 100644 --- a/lnst/Controller/Task.py +++ b/lnst/Controller/Task.py @@ -90,7 +90,11 @@ class ControllerAPI(object):

def __init__(self, ctl, hosts):
    self._ctl = ctl

•    self.run_mode = ctl.run_mode
    self._result = True
  

•    self.first_run = True
  

•    self._m_id_seq = 0
  

•    self.mreq = {}
  
    self._perf_repo_api = PerfRepoAPI()
  
  

@@ -98,6 +102,35 @@ class ControllerAPI(object): for host_id, host in hosts.iteritems(): self._hosts[host_id] = HostAPI(self, host_id, host)

• def get_mreq(self):

•    return self.mreq
  

• def cleanup_slaves(self):

You use this and other methods in previous patch. Does not look bisectable :)

​They are added, but are not called anywhere​ so it shouldn't affect bisect.

^^^^^^ ^^^^^^ magic again!

I see it!

+def match(): + ctl.cleanup_slaves()