Tag 'livecd-tools-0.3.6' created by Brian C. Lane bcl@redhat.com at 2010-11-15 21:03 +0000
Tag as livecd-tools-0.3.6
Changes since livecd-tools-034: Alan Pevec (1): edit-livecd: add new attribute compress_type
Brian C. Lane (7): Changing version to NVR Add proxy support to livecd-creator (#649546) Add support for timeout and totaltimeout to livecd-iso-to-disk (#531566) Update dracut args (#652484) Pass dracut args during check (#589778) Add a release target Bump version to 0.3.6
Bruno Wolff III (12): Revise basic video change to fix issue with default menu item Missing parts of regex fix patch Fix label for basic video boot menu item Still needed to fix one /dev/loop* . Fix bad path brought in using old patch. Thanks Spot! Note that lzo can be used as a compressor. setfiles parameter list fix for relabelling. Starting with syslinux 4 ldlinux.sys is used on all file systems. Allow image to be put on a btrfs file system on a live usb. Provide for support for $releasever in repo commands. Add documentation for repo command extensions. Typo. Need space before ].
Frederick Grose (4): Cleanup EOL spaces (#652522) Cleanup tabs (#652522) Set indentation to 4 spaces (#652522) Misc. fixups (#652522)
--- Makefile | 6 docs/livecd-creator.pod | 11 docs/livecd-iso-to-disk.pod | 8 imgcreate/creator.py | 6 imgcreate/kickstart.py | 7 imgcreate/live.py | 45 +- imgcreate/yuminst.py | 1 tools/edit-livecd | 3 tools/livecd-creator | 2 tools/livecd-iso-to-disk.sh | 752 ++++++++++++++++++++++---------------------- 10 files changed, 448 insertions(+), 393 deletions(-) ---
Changes since livecd-tools-034:
Frederick Grose (4): Cleanup EOL spaces (#652522) Cleanup tabs (#652522) Set indentation to 4 spaces (#652522) Misc. fixups (#652522)
This is quite depressing.
The price to pay for any reformatting is added noise in git log and breakage of git blame, merge, apply,... to be weighed against the better readability and consistency.
In this specific case here the breakage is very wide (touching a vast number of lines), and the readability improvement is... zero:
https://bugzilla.redhat.com/attachment.cgi?id=460144&action=diff
On Tue, Nov 16, 2010 at 03:05:08PM +0000, Marc Herbert wrote:
Changes since livecd-tools-034:
Frederick Grose (4): Cleanup EOL spaces (#652522) Cleanup tabs (#652522) Set indentation to 4 spaces (#652522) Misc. fixups (#652522)
This is quite depressing.
The price to pay for any reformatting is added noise in git log and breakage of git blame, merge, apply,... to be weighed against the better readability and consistency.
In this specific case here the breakage is very wide (touching a vast number of lines), and the readability improvement is... zero:
https://bugzilla.redhat.com/attachment.cgi?id=460144&action=diff
It depends on your editor. Tabs are to be avoided in everything except Makefiles. And seriously, how often do you need to use git blame on livecd-tools?
Brian
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 11/16/2010 09:49 AM, Brian C. Lane wrote:
It depends on your editor. Tabs are to be avoided in everything except Makefiles. And seriously, how often do you need to use git blame on livecd-tools?
Git blame can also be instructed to look at specific versions or back from a specific point in time. Code moves all the time, the person who put a line of code in a particular spot isn't necessarily the person who wrote it. I find myself using git log -p and then searching for that particular line of code from the bottom up to see who originally introduced it to a project.
- -- Jesse Keating RHCE (http://jkeating.livejournal.com) Fedora Project (http://fedoraproject.org/wiki/JesseKeating) GPG Public Key (geek.j2solutions.net/jkeating.j2solutions.pub) identi.ca (http://identi.ca/jkeating)
It depends on your editor. Tabs are to be avoided in everything except Makefiles.
I hate tabs, but it is a minor hassle to configure your editor to display them the way you want. Very minor compared to breaking the history.
Note that there is a huge difference between a "no (new) tabs" policy versus "repairing" the existing ones: only the latter breaks history.
The price to pay for any reformatting is added noise in git log and breakage of git blame, merge, apply,... to be weighed against the better readability and consistency.
And seriously, how often do you need to use git blame on livecd-tools?
"blame" is the most obvious example but most advanced Version Control features are broken just the same. Like for instance moving patches around, conveniently reviewing the difference between two tags, etc.
In my experience no one committing such a massive amount of whitespace has ever performed real maintenance work. Otherwise they know better.
livecd@lists.fedoraproject.org