On Sun, Aug 29, 2010 at 4:12 AM, Jasper Hartline <jasper.hartline@gmail.com> wrote:

{...}
 
About patches, do you have any in particular you're looking at?
Most of any of them that were not submitted by Frederick Grose were
updated by myself, to apply against git, but it is up to your
discretion if you want to apply
and test any of them. The only two I wish we could really apply soon
soon, like when you do it
is these two:

1) https://bugzilla.redhat.com/attachment.cgi?id=436736&action=diff&context=patch&collapsed=&headers=1&format=raw
2) https://bugzilla.redhat.com/attachment.cgi?id=424664

1) Fix bug with vfat only disks, including adding support for Ext4

Comment added to https://bugzilla.redhat.com/show_bug.cgi?id=603277.
See https://bugzilla.redhat.com/show_bug.cgi?id=587411 livecd-iso-to-disk --format fails with SD/MMC partitions.

The umount ${device}? will fail with an SD/MMC partition that uses a device-partition# separator, such as the 'p' in /dev/mmcblk0p1

umount ${device}* would work, but would also unmount all partitions.

Having the partition number 1 hardcoded as USBDEV=${device}1 could also fail with some SD/MMC drivers.
Attachment, https://bugzilla.redhat.com/attachment.cgi?id=413572&action=edit , has some replacement code:

-    USBDEV=${device}1

+    partition=$( awk '$4 ~ /'${device#/dev/}'.*[0-9]$/ {print $4}' /proc/partitions )
+    partnum=${partition##${device#/dev/}}
+    USBDEV=${device}${partnum}
         --Fred