Wed, Aug 08, 2018 at 11:04:13AM CEST, Paul.D.Smith(a)metaswitch.com wrote:
I following the instructions as far as, and including, using the 'git
format-patch' command but my version of Git does not have the 'git send-email'
command so I just cut-n-pasted the patch into an e-mail by hand.
Okay. That's the problem. "git send-email" is usually distributed in
a separate package. In Fedora it is in "git-email" package.
The motivation for the change is that we found that the code just didn't work; my
understanding is that regardless of which team device we were attempting to program, the
superclass init() always attempted to program the '0' team device.
I'll drop you more info next week when my colleague, who hit this when developing our
code and can probably give you a more detailed answer, returns from holiday.
Okay. So it is a bugfix. Yeah, please provide this info in the patch
description. Also, if you find the offending commit tha actually caused
this issue, it is fine to add line similar to this:
Fixes: d5a1c8ee9e36 ("utils: add bond2team conversion tool")
Please see "git log" and find for "Fixes" to see how is it used.
>From: Jiri Pirko <jiri(a)resnulli.us>
>Sent: 08 August 2018 09:39
>To: Paul D. Smith <Paul.D.Smith(a)metaswitch.com>
>Subject: Re: [patch libteam] Pass device ID through to super class init.
>Mon, Aug 06, 2018 at 02:46:30PM CEST, Paul.D.Smith(a)metaswitch.com wrote:
>>From 34bccf0221af3f063686d58704d1255eab5f15b9 Mon Sep 17 00:00:00 2001
>>From: "Paul D.Smith" <paul.d.smith(a)metaswitch.com>
>>Date: Mon, 6 Aug 2018 13:41:28 +0100
>>Subject: [patch libteam] Pass device ID through to super class init.
>These 4 lines does not supposed to be there. Odd. Did you use "git
format-patch" and "git send-email"?
>Also, please provide a bit of description of the change. At least some motivation for
>>Signed-off-by: Paul D.Smith <paul.d.smith(a)metaswitch.com>
>>binding/python/team/core.py | 2 +-
>>1 file changed, 1 insertion(+), 1 deletion(-)
>>diff --git a/binding/python/team/core.py b/binding/python/team/core.py
>>index 54161bf..e784930 100644
>>@@ -348,7 +348,7 @@ class Team(TeamNetDevice):
>> if not th:
>> raise TeamLibError("Failed to allocate team handle.")
>>- super(Team, self).__init__(th)
>>+ super(Team, self).__init__(th, teamdev)
>> if isinstance(teamdev, str):
>> err = 0