Branch: refs/heads/master
Home:
https://github.com/jpirko/libteam
Commit: 3d1e9efa37976fce3546e343a948a582da1dd203
https://github.com/jpirko/libteam/commit/3d1e9efa37976fce3546e343a948a582...
Author: Xin Long <lucien.xin(a)gmail.com>
Date: 2017-05-08 (Mon, 08 May 2017)
Changed paths:
M teamd/teamd_runner_lacp.c
Log Message:
-----------
teamd: set correct bits for standby ports
Patrick reported an issue that Collecting & Distributing & Synchronization
bits shouldn't be set in LACPDUs for the ports associated with standby agg.
It would also cause team to work differently from bonding.
Jamie and Patrick concluded from section 5.6.1 of IEEE 802.1AX-2008:
- Standby ports MAY set Collecting and Distributing bits
- Standby ports MUST NOT set Synchronization bit
This patch is to fix it by setting these three sits only when the selected
ports associated with a selected agg.
Reported-by: Patrick Talbert <ptalbert(a)redhat.com>
Signed-off-by: Xin Long <lucien.xin(a)gmail.com>
Signed-off-by: Jiri Pirko <jiri(a)mellanox.com>
Commit: 9a9fbff3e75f78cbff76e9dbd1cfa0a05fd1f120
https://github.com/jpirko/libteam/commit/9a9fbff3e75f78cbff76e9dbd1cfa0a0...
Author: Xin Long <lucien.xin(a)gmail.com>
Date: 2017-05-08 (Mon, 08 May 2017)
Changed paths:
M teamd/teamd_lw_nsna_ping.c
Log Message:
-----------
teamd: check ipv6 packet only with the 4 bits version
Now in lw_nsnap_receive, it checks if the packet is ipv6 or not by
ip6h.ip6_vfc != 0x60. But ip6_vfc in ipv6 header is 4 bits version
and top 4 bits tclass.
The na packet from some switch may set this top 4 bits tclass. It
will cause to fail to validate the ipv6 na packet, and nsna_ping
couldn't work.
This patch is to fix it by only using the 4 bits version to check
ipv6 packet.
Reported-by: Amit Supugade <asupugad(a)redhat.com>
Signed-off-by: Xin Long <lucien.xin(a)gmail.com>
Signed-off-by: Jiri Pirko <jiri(a)mellanox.com>
Commit: 49c1de9b67a5a26f120294743d206f3a9286a314
https://github.com/jpirko/libteam/commit/49c1de9b67a5a26f120294743d206f3a...
Author: Xin Long <lucien.xin(a)gmail.com>
Date: 2017-05-08 (Mon, 08 May 2017)
Changed paths:
M teamd/teamd_lw_nsna_ping.c
Log Message:
-----------
teamd: check target host with nap.nah.nd_na_target
Now in lw_nsnap_receive, it compares ip6h.ip6_src with nsnap_ppriv->dst
to check target host.
But when target_host is set with a global addr, the na packet from some
switch may use it's link/local addr as the ip6_src addr, instead of the
global addr. It will cause to fail to validate the ipv6 na packet, and
nsna_ping couldn't work.
Since nap.nah.nd_na_target is always set with target_host, this patch is
to fix it by using nap.nah.nd_na_target to compare with nsnap_ppriv->dst
to check target host instead.
Reported-by: Amit Supugade <asupugad(a)redhat.com>
Signed-off-by: Xin Long <lucien.xin(a)gmail.com>
Signed-off-by: Jiri Pirko <jiri(a)mellanox.com>
Compare:
https://github.com/jpirko/libteam/compare/ee01c00ecaac...49c1de9b67a5